Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-12-05 Thread Jesse Gross
On Tue, Dec 2, 2014 at 10:26 AM, Jesse Gross wrote: > On Mon, Dec 1, 2014 at 4:09 PM, Tom Herbert wrote: >> On Mon, Dec 1, 2014 at 3:53 PM, Jesse Gross wrote: >>> On Mon, Dec 1, 2014 at 3:47 PM, Tom Herbert wrote: On Mon, Dec 1, 2014 at 3:35 PM, Joe Stringer wrote: > On 21 Novem

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Joe Stringer
On 2 December 2014 at 10:26, Jesse Gross wrote: > On Mon, Dec 1, 2014 at 4:09 PM, Tom Herbert wrote: >> On Mon, Dec 1, 2014 at 3:53 PM, Jesse Gross wrote: >>> On Mon, Dec 1, 2014 at 3:47 PM, Tom Herbert wrote: On Mon, Dec 1, 2014 at 3:35 PM, Joe Stringer wrote: > On 21 November

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-12-02 Thread Jesse Gross
On Mon, Dec 1, 2014 at 4:09 PM, Tom Herbert wrote: > On Mon, Dec 1, 2014 at 3:53 PM, Jesse Gross wrote: >> On Mon, Dec 1, 2014 at 3:47 PM, Tom Herbert wrote: >>> On Mon, Dec 1, 2014 at 3:35 PM, Joe Stringer wrote: On 21 November 2014 at 09:59, Joe Stringer wrote: > On 20 November 2014

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-12-01 Thread Tom Herbert
On Mon, Dec 1, 2014 at 3:53 PM, Jesse Gross wrote: > On Mon, Dec 1, 2014 at 3:47 PM, Tom Herbert wrote: >> On Mon, Dec 1, 2014 at 3:35 PM, Joe Stringer wrote: >>> On 21 November 2014 at 09:59, Joe Stringer wrote: On 20 November 2014 16:19, Jesse Gross wrote: > I don't know if we need

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-12-01 Thread Joe Stringer
On 1 December 2014 at 15:53, Jesse Gross wrote: > On Mon, Dec 1, 2014 at 3:47 PM, Tom Herbert wrote: >> On Mon, Dec 1, 2014 at 3:35 PM, Joe Stringer wrote: >>> On 21 November 2014 at 09:59, Joe Stringer wrote: On 20 November 2014 16:19, Jesse Gross wrote: > I don't know if we need to

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-12-01 Thread Jesse Gross
On Mon, Dec 1, 2014 at 3:47 PM, Tom Herbert wrote: > On Mon, Dec 1, 2014 at 3:35 PM, Joe Stringer wrote: >> On 21 November 2014 at 09:59, Joe Stringer wrote: >>> On 20 November 2014 16:19, Jesse Gross wrote: I don't know if we need to have the check at all for IPIP though - after all

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-12-01 Thread Tom Herbert
On Mon, Dec 1, 2014 at 3:35 PM, Joe Stringer wrote: > On 21 November 2014 at 09:59, Joe Stringer wrote: >> On 20 November 2014 16:19, Jesse Gross wrote: >>> I don't know if we need to have the check at all for IPIP though - >>> after all the driver doesn't expose support for it all (actually it

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-12-01 Thread Joe Stringer
On 21 November 2014 at 09:59, Joe Stringer wrote: > On 20 November 2014 16:19, Jesse Gross wrote: >> I don't know if we need to have the check at all for IPIP though - >> after all the driver doesn't expose support for it all (actually it >> doesn't expose GRE either). This raises kind of an inte

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-11-21 Thread Joe Stringer
On 20 November 2014 16:19, Jesse Gross wrote: > On Thu, Nov 20, 2014 at 3:11 PM, Joe Stringer wrote: >> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c >> b/drivers/net/ethernet/intel/i40e/i40e_main.c >> index c3a7f4a..2b01c8d 100644 >> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-11-20 Thread Jesse Gross
On Thu, Nov 20, 2014 at 3:11 PM, Joe Stringer wrote: > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c > b/drivers/net/ethernet/intel/i40e/i40e_main.c > index c3a7f4a..2b01c8d 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c >

Re: [PATCHv2 net] i40e: Implement ndo_gso_check()

2014-11-20 Thread Jeff Kirsher
On Thu, 2014-11-20 at 15:11 -0800, Joe Stringer wrote: > ndo_gso_check() was recently introduced to allow NICs to report the > offloading support that they have on a per-skb basis. Add an > implementation for this driver which checks for IPIP, GRE, UDP > tunnels. > > Signed-off-by: Joe Stringer >

[PATCHv2 net] i40e: Implement ndo_gso_check()

2014-11-20 Thread Joe Stringer
ndo_gso_check() was recently introduced to allow NICs to report the offloading support that they have on a per-skb basis. Add an implementation for this driver which checks for IPIP, GRE, UDP tunnels. Signed-off-by: Joe Stringer --- v2: Expand to include IP in IP and IPv4/IPv6 inside GRE/UDP tunn