Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-09-02 Thread Izabela Bakollari
Thank you for your review. I am working on a patch v3 and will apply your suggestions where possible. Best, Izabela On Mon, Aug 31, 2020 at 3:18 PM Michal Schmidt wrote: > > Dne 04. 08. 20 v 18:09 izabela.bakoll...@gmail.com napsala: > > From: Izabela Bakollari > > > > Dropwatch is a utility

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-31 Thread Michal Schmidt
Dne 04. 08. 20 v 18:09 izabela.bakoll...@gmail.com napsala: From: Izabela Bakollari Dropwatch is a utility that monitors dropped frames by having userspace record them over the dropwatch protocol over a file. This augument allows live monitoring of dropped frames using tools like tcpdump.

Re: [Linux-kernel-mentees] [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-10 Thread Greg KH
On Mon, Aug 10, 2020 at 03:39:40PM +0200, Izabela Bakollari wrote: > I have worked on this feature as part of the Linux Kernel Mentorship > Program. Your review would really help me in this learning process. You sent this just a bit less than 1 week ago, and it's the middle of the kernel merge

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-10 Thread Izabela Bakollari
I have worked on this feature as part of the Linux Kernel Mentorship Program. Your review would really help me in this learning process. Thanks, Izabela On Tue, Aug 4, 2020 at 6:09 PM wrote: > > From: Izabela Bakollari > > Dropwatch is a utility that monitors dropped frames by having userspace

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-05 Thread Neil Horman
On Tue, Aug 04, 2020 at 04:14:14PM -0700, David Miller wrote: > From: izabela.bakoll...@gmail.com > Date: Tue, 4 Aug 2020 18:09:08 +0200 > > > @@ -1315,6 +1334,53 @@ static int net_dm_cmd_trace(struct sk_buff *skb, > > return -EOPNOTSUPP; > > } > > > > +static int

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread David Miller
From: izabela.bakoll...@gmail.com Date: Tue, 4 Aug 2020 18:09:08 +0200 > @@ -1315,6 +1334,53 @@ static int net_dm_cmd_trace(struct sk_buff *skb, > return -EOPNOTSUPP; > } > > +static int net_dm_interface_start(struct net *net, const char *ifname) > +{ > + struct net_device *nd =

Re: [Linux-kernel-mentees] [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread Neil Horman
On Tue, Aug 04, 2020 at 02:28:28PM -0700, Cong Wang wrote: > On Tue, Aug 4, 2020 at 9:14 AM wrote: > > > > From: Izabela Bakollari > > > > Dropwatch is a utility that monitors dropped frames by having userspace > > record them over the dropwatch protocol over a file. This augument > > allows

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread Cong Wang
On Tue, Aug 4, 2020 at 9:14 AM wrote: > > From: Izabela Bakollari > > Dropwatch is a utility that monitors dropped frames by having userspace > record them over the dropwatch protocol over a file. This augument > allows live monitoring of dropped frames using tools like tcpdump. > > With this

[PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread izabela . bakollari
From: Izabela Bakollari Dropwatch is a utility that monitors dropped frames by having userspace record them over the dropwatch protocol over a file. This augument allows live monitoring of dropped frames using tools like tcpdump. With this feature, dropwatch allows two additional commands