Re: [PATCHv3] irqchip: arm-gic: take gic_lock when updating irq type

2018-03-28 Thread Marc Zyngier
Hi Aniruddha, On 28/03/18 09:54, Aniruddha Banerjee wrote: > The kernel documentation states that the locking of the irq-chip > registers should be handled by the irq-chip driver. In the irq-gic, > the accesses to the irqchip are seemingly not protected and multiple > writes to SPIs from

Re: [PATCHv3] irqchip: arm-gic: take gic_lock when updating irq type

2018-03-28 Thread Marc Zyngier
Hi Aniruddha, On 28/03/18 09:54, Aniruddha Banerjee wrote: > The kernel documentation states that the locking of the irq-chip > registers should be handled by the irq-chip driver. In the irq-gic, > the accesses to the irqchip are seemingly not protected and multiple > writes to SPIs from

Re: [PATCHv3] irqchip: arm-gic: take gic_lock when updating irq type

2018-03-28 Thread Greg KH
On Wed, Mar 28, 2018 at 02:24:30PM +0530, Aniruddha Banerjee wrote: > The kernel documentation states that the locking of the irq-chip > registers should be handled by the irq-chip driver. In the irq-gic, > the accesses to the irqchip are seemingly not protected and multiple > writes to SPIs from

Re: [PATCHv3] irqchip: arm-gic: take gic_lock when updating irq type

2018-03-28 Thread Greg KH
On Wed, Mar 28, 2018 at 02:24:30PM +0530, Aniruddha Banerjee wrote: > The kernel documentation states that the locking of the irq-chip > registers should be handled by the irq-chip driver. In the irq-gic, > the accesses to the irqchip are seemingly not protected and multiple > writes to SPIs from

[PATCHv3] irqchip: arm-gic: take gic_lock when updating irq type

2018-03-28 Thread Aniruddha Banerjee
The kernel documentation states that the locking of the irq-chip registers should be handled by the irq-chip driver. In the irq-gic, the accesses to the irqchip are seemingly not protected and multiple writes to SPIs from different irq descriptors do RMW requests without taking the irq-chip lock.

[PATCHv3] irqchip: arm-gic: take gic_lock when updating irq type

2018-03-28 Thread Aniruddha Banerjee
The kernel documentation states that the locking of the irq-chip registers should be handled by the irq-chip driver. In the irq-gic, the accesses to the irqchip are seemingly not protected and multiple writes to SPIs from different irq descriptors do RMW requests without taking the irq-chip lock.