Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-12-11 Thread Daniel Wang
Got it. Thank you. On Tue, Dec 11, 2018 at 10:06 PM Sergey Senozhatsky wrote: > > On (12/11/18 21:59), Daniel Wang wrote: > > No worries. I will follow up. You would recommend that all four > > patches in this set to be backported though, right? > > Just the last one, which makes consoles

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-12-11 Thread Sergey Senozhatsky
On (12/11/18 21:59), Daniel Wang wrote: > No worries. I will follow up. You would recommend that all four > patches in this set to be backported though, right? Just the last one, which makes consoles re-entrant panic: avoid deadlocks in re-entrant console drivers Because only this one

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-12-11 Thread Daniel Wang
No worries. I will follow up. You would recommend that all four patches in this set to be backported though, right? On Tue, Dec 11, 2018 at 9:23 PM Sergey Senozhatsky wrote: > > On (12/11/18 16:53), Daniel Wang wrote: > > Is it okay to tag this commit with `Cc: sta...@vger.kernel.org` so > >

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-12-11 Thread Sergey Senozhatsky
On (12/11/18 16:53), Daniel Wang wrote: > Is it okay to tag this commit with `Cc: sta...@vger.kernel.org` so > that it'll get applied to the stable trees once merged into Linux's > tree, if it's not too late? Otherwise I'll follow up on the stable > merges separately. Thanks for making the changes

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-12-11 Thread Daniel Wang
Is it okay to tag this commit with `Cc: sta...@vger.kernel.org` so that it'll get applied to the stable trees once merged into Linux's tree, if it's not too late? Otherwise I'll follow up on the stable merges separately. Thanks for making the changes anyway. On Thu, Nov 22, 2018 at 5:12 AM Petr

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-11-22 Thread Petr Mladek
On Thu 2018-11-01 09:08:08, Petr Mladek wrote: > On Thu 2018-11-01 10:48:21, Sergey Senozhatsky wrote: > > On (10/31/18 13:27), Petr Mladek wrote: > > > > > > > > Signed-off-by: Sergey Senozhatsky > > > > > > The patch makes sense to me. The locks should stay busted also for > > >

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-11-22 Thread Petr Mladek
On Thu 2018-11-01 09:08:08, Petr Mladek wrote: > On Thu 2018-11-01 10:48:21, Sergey Senozhatsky wrote: > > On (10/31/18 13:27), Petr Mladek wrote: > > > > > > > > Signed-off-by: Sergey Senozhatsky > > > > > > The patch makes sense to me. The locks should stay busted also for > > >

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-11-01 Thread Petr Mladek
On Thu 2018-11-01 10:48:21, Sergey Senozhatsky wrote: > On (10/31/18 13:27), Petr Mladek wrote: > > > > > > Signed-off-by: Sergey Senozhatsky > > > > The patch makes sense to me. The locks should stay busted also for > > console_flush_on_panic(). > > > > With the added #include : > > > >

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-11-01 Thread Petr Mladek
On Thu 2018-11-01 10:48:21, Sergey Senozhatsky wrote: > On (10/31/18 13:27), Petr Mladek wrote: > > > > > > Signed-off-by: Sergey Senozhatsky > > > > The patch makes sense to me. The locks should stay busted also for > > console_flush_on_panic(). > > > > With the added #include : > > > >

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-31 Thread Sergey Senozhatsky
On (10/31/18 13:27), Petr Mladek wrote: > > > > Signed-off-by: Sergey Senozhatsky > > The patch makes sense to me. The locks should stay busted also for > console_flush_on_panic(). > > With the added #include : > > Reviewed-by: Petr Mladek Thanks! Since there are no objections - how shall

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-31 Thread Sergey Senozhatsky
On (10/31/18 13:27), Petr Mladek wrote: > > > > Signed-off-by: Sergey Senozhatsky > > The patch makes sense to me. The locks should stay busted also for > console_flush_on_panic(). > > With the added #include : > > Reviewed-by: Petr Mladek Thanks! Since there are no objections - how shall

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-31 Thread Petr Mladek
On Thu 2018-10-25 19:10:36, Sergey Senozhatsky wrote: > >From printk()/serial console point of view panic() is special, because > it may force CPU to re-enter printk() or/and serial console driver. > Therefore, some of serial consoles drivers are re-entrant. E.g. 8250: > >

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-31 Thread Petr Mladek
On Thu 2018-10-25 19:10:36, Sergey Senozhatsky wrote: > >From printk()/serial console point of view panic() is special, because > it may force CPU to re-enter printk() or/and serial console driver. > Therefore, some of serial consoles drivers are re-entrant. E.g. 8250: > >

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-25 Thread Sergey Senozhatsky
On (10/25/18 18:51), kbuild test robot wrote: > > [auto build test ERROR on linux-sof-driver/master] > [also build test ERROR on v4.19 next-20181019] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > My bad, sorry! +#include This should

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-25 Thread Sergey Senozhatsky
On (10/25/18 18:51), kbuild test robot wrote: > > [auto build test ERROR on linux-sof-driver/master] > [also build test ERROR on v4.19 next-20181019] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > My bad, sorry! +#include This should

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-25 Thread kbuild test robot
Hi Sergey, I love your patch! Yet something to improve: [auto build test ERROR on linux-sof-driver/master] [also build test ERROR on v4.19 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-25 Thread kbuild test robot
Hi Sergey, I love your patch! Yet something to improve: [auto build test ERROR on linux-sof-driver/master] [also build test ERROR on v4.19 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-25 Thread Sergey Senozhatsky
>From printk()/serial console point of view panic() is special, because it may force CPU to re-enter printk() or/and serial console driver. Therefore, some of serial consoles drivers are re-entrant. E.g. 8250: serial8250_console_write() { if (port->sysrq) locked = 0;

[PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-25 Thread Sergey Senozhatsky
>From printk()/serial console point of view panic() is special, because it may force CPU to re-enter printk() or/and serial console driver. Therefore, some of serial consoles drivers are re-entrant. E.g. 8250: serial8250_console_write() { if (port->sysrq) locked = 0;