Re: [PATCHv3] perf stat: Ensure group is defined on top of the same cpu mask

2020-06-02 Thread Ian Rogers
On Tue, Jun 2, 2020 at 3:17 AM Jiri Olsa wrote: > > Jin Yao reported the issue (and posted first versions of this change) > with groups being defined over events with different cpu mask. > > This causes assert aborts in get_group_fd, like: > > # perf stat -M "C2_Pkg_Residency" -a -- sleep 1 >

Re: [PATCHv3] perf stat: Ensure group is defined on top of the same cpu mask

2020-06-02 Thread Jiri Olsa
On Tue, Jun 02, 2020 at 12:03:52PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > right, it disables 'grouping', events are scheduled/counted individualy > > Ok, I applied this already, we can fix this in the next cycle. > > > this way we will not hit the issue when looking for group_fd FD > >

Re: [PATCHv3] perf stat: Ensure group is defined on top of the same cpu mask

2020-06-02 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 02, 2020 at 04:05:08PM +0200, Jiri Olsa escreveu: > On Tue, Jun 02, 2020 at 10:42:56AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jun 02, 2020 at 12:17:36PM +0200, Jiri Olsa escreveu: > > > Jin Yao reported the issue (and posted first versions of this change) > > > with groups b

Re: [PATCHv3] perf stat: Ensure group is defined on top of the same cpu mask

2020-06-02 Thread Jiri Olsa
On Tue, Jun 02, 2020 at 10:42:56AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 02, 2020 at 12:17:36PM +0200, Jiri Olsa escreveu: > > Jin Yao reported the issue (and posted first versions of this change) > > with groups being defined over events with different cpu mask. > > > This causes

Re: [PATCHv3] perf stat: Ensure group is defined on top of the same cpu mask

2020-06-02 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 02, 2020 at 12:17:36PM +0200, Jiri Olsa escreveu: > Jin Yao reported the issue (and posted first versions of this change) > with groups being defined over events with different cpu mask. > This causes assert aborts in get_group_fd, like: > # perf stat -M "C2_Pkg_Residency" -a -- s

[PATCHv3] perf stat: Ensure group is defined on top of the same cpu mask

2020-06-02 Thread Jiri Olsa
Jin Yao reported the issue (and posted first versions of this change) with groups being defined over events with different cpu mask. This causes assert aborts in get_group_fd, like: # perf stat -M "C2_Pkg_Residency" -a -- sleep 1 perf: util/evsel.c:1464: get_group_fd: Assertion `!(fd == -1)'