Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 03:01:00PM +0200, Jiri Olsa escreveu: > On Tue, Jul 28, 2020 at 02:54:56PM +0200, Jiri Olsa wrote: > > On Tue, Jul 28, 2020 at 09:39:55AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Jul 20, 2020 at 09:16:25PM +0200, Jiri Olsa escreveu: > > > > On Mon, Jul 20, 2020

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-28 Thread Jiri Olsa
On Tue, Jul 28, 2020 at 02:54:56PM +0200, Jiri Olsa wrote: > On Tue, Jul 28, 2020 at 09:39:55AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jul 20, 2020 at 09:16:25PM +0200, Jiri Olsa escreveu: > > > On Mon, Jul 20, 2020 at 02:32:40PM +0530, kajoljain wrote: > > > > > > > > > > > > On

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-28 Thread Jiri Olsa
On Tue, Jul 28, 2020 at 09:39:55AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jul 20, 2020 at 09:16:25PM +0200, Jiri Olsa escreveu: > > On Mon, Jul 20, 2020 at 02:32:40PM +0530, kajoljain wrote: > > > > > > > > > On 7/20/20 1:49 PM, Jiri Olsa wrote: > > > > On Mon, Jul 20, 2020 at

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2020 at 10:59:58AM -0500, Paul A. Clarke escreveu: > On Wed, Jul 22, 2020 at 08:11:58PM +0200, Jiri Olsa wrote: > > On Tue, Jul 21, 2020 at 09:48:48AM -0500, Paul A. Clarke wrote: > > > On Sun, Jul 19, 2020 at 08:13:01PM +0200, Jiri Olsa wrote: > > > > hi, > > > > this patchset is

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 20, 2020 at 09:16:25PM +0200, Jiri Olsa escreveu: > On Mon, Jul 20, 2020 at 02:32:40PM +0530, kajoljain wrote: > > > > > > On 7/20/20 1:49 PM, Jiri Olsa wrote: > > > On Mon, Jul 20, 2020 at 01:39:24PM +0530, kajoljain wrote: > > > > > > SNIP > > > > > >> This is with your

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-26 Thread kajoljain
On 7/25/20 5:21 PM, Jiri Olsa wrote: > On Fri, Jul 24, 2020 at 11:22:28AM +0530, kajoljain wrote: > > SNIP > >> >> Hi Jiri, >>The change looks good to me. I tried with adding this patch on top of >> your perf/metric branch. It did resolve the issue of not printing >> all chips data.

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-25 Thread Jiri Olsa
On Thu, Jul 23, 2020 at 10:59:58AM -0500, Paul A. Clarke wrote: > On Wed, Jul 22, 2020 at 08:11:58PM +0200, Jiri Olsa wrote: > > On Tue, Jul 21, 2020 at 09:48:48AM -0500, Paul A. Clarke wrote: > > > On Sun, Jul 19, 2020 at 08:13:01PM +0200, Jiri Olsa wrote: > > > > hi, > > > > this patchset is

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-25 Thread Jiri Olsa
On Fri, Jul 24, 2020 at 11:22:28AM +0530, kajoljain wrote: SNIP > > Hi Jiri, >The change looks good to me. I tried with adding this patch on top of > your perf/metric branch. It did resolve the issue of not printing > all chips data. And now I can see proper values for hv-24x7 metric

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-23 Thread kajoljain
On 7/21/20 12:46 AM, Jiri Olsa wrote: > On Mon, Jul 20, 2020 at 02:32:40PM +0530, kajoljain wrote: >> >> >> On 7/20/20 1:49 PM, Jiri Olsa wrote: >>> On Mon, Jul 20, 2020 at 01:39:24PM +0530, kajoljain wrote: >>> >>> SNIP >>> This is with your perf/metric branch: command# ./perf stat

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-23 Thread Andi Kleen
> perf: util/evsel.c:1452: get_group_fd: Assertion `!(!leader->core.fd)' > failed. > Aborted (core dumped) > ``` This usually happens when you run out of file descriptors -Andi

RE: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-23 Thread Paul A. Clarke
On Wed, Jul 22, 2020 at 08:11:58PM +0200, Jiri Olsa wrote: > On Tue, Jul 21, 2020 at 09:48:48AM -0500, Paul A. Clarke wrote: > > On Sun, Jul 19, 2020 at 08:13:01PM +0200, Jiri Olsa wrote: > > > hi, > > > this patchset is adding the support to reused metric in > > > another metric. > > > > > > For

RE: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-23 Thread Paul A. Clarke
On Wed, Jul 22, 2020 at 08:11:58PM +0200, Jiri Olsa wrote: > On Tue, Jul 21, 2020 at 09:48:48AM -0500, Paul A. Clarke wrote: > > On Sun, Jul 19, 2020 at 08:13:01PM +0200, Jiri Olsa wrote: > > > hi, > > > this patchset is adding the support to reused metric in > > > another metric. > > > > > > For

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-22 Thread Jiri Olsa
On Tue, Jul 21, 2020 at 09:48:48AM -0500, Paul A. Clarke wrote: > On Sun, Jul 19, 2020 at 08:13:01PM +0200, Jiri Olsa wrote: > > hi, > > this patchset is adding the support to reused metric in > > another metric. > > > > For example, to define IPC by using CPI with change like: > > > > { >

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-21 Thread Paul A. Clarke
On Sun, Jul 19, 2020 at 08:13:01PM +0200, Jiri Olsa wrote: > hi, > this patchset is adding the support to reused metric in > another metric. > > For example, to define IPC by using CPI with change like: > > { > "BriefDescription": "Instructions Per Cycle (per Logical Processor)", >

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-20 Thread Jiri Olsa
On Mon, Jul 20, 2020 at 02:32:40PM +0530, kajoljain wrote: > > > On 7/20/20 1:49 PM, Jiri Olsa wrote: > > On Mon, Jul 20, 2020 at 01:39:24PM +0530, kajoljain wrote: > > > > SNIP > > > >> This is with your perf/metric branch: > >> command# ./perf stat -M PowerBUS_Frequency -C 0 -I 1000 > >>

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-20 Thread kajoljain
On 7/20/20 1:49 PM, Jiri Olsa wrote: > On Mon, Jul 20, 2020 at 01:39:24PM +0530, kajoljain wrote: > > SNIP > >> This is with your perf/metric branch: >> command# ./perf stat -M PowerBUS_Frequency -C 0 -I 1000 >> assertion failed at util/metricgroup.c:709 >> # time counts

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-20 Thread Jiri Olsa
On Mon, Jul 20, 2020 at 01:39:24PM +0530, kajoljain wrote: SNIP > This is with your perf/metric branch: > command# ./perf stat -M PowerBUS_Frequency -C 0 -I 1000 > assertion failed at util/metricgroup.c:709 > # time counts unit events > 1.54545 7,807,505

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-20 Thread kajoljain
On 7/20/20 12:52 PM, Jiri Olsa wrote: > On Mon, Jul 20, 2020 at 12:14:00PM +0530, kajoljain wrote: >> >> >> On 7/19/20 11:43 PM, Jiri Olsa wrote: >>> hi, >>> this patchset is adding the support to reused metric in >>> another metric. >>> >>> For example, to define IPC by using CPI with change

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-20 Thread Jiri Olsa
On Mon, Jul 20, 2020 at 12:14:00PM +0530, kajoljain wrote: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > hi, > > this patchset is adding the support to reused metric in > > another metric. > > > > For example, to define IPC by using CPI with change like: > > > > { > >

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-20 Thread kajoljain
On 7/19/20 11:43 PM, Jiri Olsa wrote: > hi, > this patchset is adding the support to reused metric in > another metric. > > For example, to define IPC by using CPI with change like: > > { > "BriefDescription": "Instructions Per Cycle (per Logical Processor)", > -

[PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-19 Thread Jiri Olsa
hi, this patchset is adding the support to reused metric in another metric. For example, to define IPC by using CPI with change like: { "BriefDescription": "Instructions Per Cycle (per Logical Processor)", -"MetricExpr": "INST_RETIRED.ANY / CPU_CLK_UNHALTED.THREAD", +