RE: [PATCHv3 09/27] PCI: mobiveil: correct inbound/outbound window setup routines

2019-02-17 Thread Z.q. Hou
; bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; > lorenzo.pieral...@arm.com; catalin.mari...@arm.com; > will.dea...@arm.com; Mingkai Hu ; M.h. Lian > ; Xiaowei Bao > Subject: Re: [PATCHv3 09/27] PCI: mobiveil: correct inbound/outb

Re: [PATCHv3 09/27] PCI: mobiveil: correct inbound/outbound window setup routines

2019-02-04 Thread Subrahmanya Lingappa
ZQ, please correct the tab spacing of the macro definitions, otherwise its OK. Reviewed-by: Subrahmanya Lingappa On Tue, Jan 29, 2019 at 1:39 PM Z.q. Hou wrote: > > From: Hou Zhiqiang > > Outbound window routine: > - Removed unused var definition and register read operations. > - Added the

[PATCHv3 09/27] PCI: mobiveil: correct inbound/outbound window setup routines

2019-01-29 Thread Z.q. Hou
From: Hou Zhiqiang Outbound window routine: - Removed unused var definition and register read operations. - Added the upper 32-bit cpu address setup of the window. - Instead of blindly write, only change the fields specified. - Masked the lower bits of window size in case override the