Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-24 Thread Sebastian Reichel
Hi, > > > I'd suggest just simple "autorepeat", so that we get rid of ugly > > > double-negation. > > The idea was that majority of setups want autorepeat so in the absence > > of the property autorepeat is turned on. > > I see... but autorepeat on by default makes sense on devices that are >

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-24 Thread Sebastian Reichel
Hi, I'd suggest just simple autorepeat, so that we get rid of ugly double-negation. The idea was that majority of setups want autorepeat so in the absence of the property autorepeat is turned on. I see... but autorepeat on by default makes sense on devices that are usually querty

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-19 Thread Pavel Machek
Hi! > > > DRIVER CODEDOCUMENTATION > > > twl4030-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat > > > omap4-keypadlinux,input-no-autorepeat linux,keypad-no-autorepeat > > > samsung-keypad linux,input-no-autorepeat

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-19 Thread Pavel Machek
Hi! DRIVER CODEDOCUMENTATION twl4030-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat omap4-keypadlinux,input-no-autorepeat linux,keypad-no-autorepeat samsung-keypad linux,input-no-autorepeat

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-17 Thread Dmitry Torokhov
On Sun, Nov 17, 2013 at 07:28:40PM +0100, Pavel Machek wrote: > Hi! > > > On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote: > > > > + if (of_get_property(np, "linux,input-no-autorepeat", NULL)) > > > > + keypad_data->no_autorepeat = true; > > > > > > From 2/2: > >

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-17 Thread Pavel Machek
Hi! > On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote: > > > + if (of_get_property(np, "linux,input-no-autorepeat", NULL)) > > > + keypad_data->no_autorepeat = true; > > > > From 2/2: > > > > +Optional Properties specific to linux: > > +- linux,keypad-no-autorepeat: do not

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-17 Thread Pavel Machek
Hi! On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote: + if (of_get_property(np, linux,input-no-autorepeat, NULL)) + keypad_data-no_autorepeat = true; From 2/2: +Optional Properties specific to linux: +- linux,keypad-no-autorepeat: do not enable autorepeat

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-17 Thread Dmitry Torokhov
On Sun, Nov 17, 2013 at 07:28:40PM +0100, Pavel Machek wrote: Hi! On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote: + if (of_get_property(np, linux,input-no-autorepeat, NULL)) + keypad_data-no_autorepeat = true; From 2/2: +Optional

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-11 Thread Sebastian Reichel
Hi, On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote: > > + if (of_get_property(np, "linux,input-no-autorepeat", NULL)) > > + keypad_data->no_autorepeat = true; > > From 2/2: > > +Optional Properties specific to linux: > +- linux,keypad-no-autorepeat: do not enable

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-11 Thread Pavel Machek
Hi! > + if (of_get_property(np, "linux,input-no-autorepeat", NULL)) > + keypad_data->no_autorepeat = true; >From 2/2: +Optional Properties specific to linux: +- linux,keypad-no-autorepeat: do not enable autorepeat feature. I'm confused now. -- (english)

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-11 Thread Pavel Machek
Hi! + if (of_get_property(np, linux,input-no-autorepeat, NULL)) + keypad_data-no_autorepeat = true; From 2/2: +Optional Properties specific to linux: +- linux,keypad-no-autorepeat: do not enable autorepeat feature. I'm confused now. -- (english)

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-11 Thread Sebastian Reichel
Hi, On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote: + if (of_get_property(np, linux,input-no-autorepeat, NULL)) + keypad_data-no_autorepeat = true; From 2/2: +Optional Properties specific to linux: +- linux,keypad-no-autorepeat: do not enable autorepeat

[PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-08 Thread Sebastian Reichel
Add device tree support for twl4030 keypad driver. Tested on Nokia N900. Signed-off-by: Sebastian Reichel --- drivers/input/keyboard/twl4030_keypad.c | 91 +++-- 1 file changed, 74 insertions(+), 17 deletions(-) diff --git a/drivers/input/keyboard/twl4030_keypad.c

[PATCHv3 1/2] Input: twl4030-keypad - add device tree support

2013-11-08 Thread Sebastian Reichel
Add device tree support for twl4030 keypad driver. Tested on Nokia N900. Signed-off-by: Sebastian Reichel s...@debian.org --- drivers/input/keyboard/twl4030_keypad.c | 91 +++-- 1 file changed, 74 insertions(+), 17 deletions(-) diff --git