Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread Timur Tabi
On Sun, Mar 2, 2014 at 8:42 PM, Xiubo Li wrote: > For some CODEC drivers like who act as the MFDs children are ignored > by this patch. This makes no sense to me. Is there a comma missing, maybe? Regardless, I think this patch description is too short. -- To unsubscribe from this list: send the

RE: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. > > On 03/10/2014 08:38 AM, Mark Brown wrote: > > On Mon, Mar 10, 2014 at 07:57:38AM +0100, Lars-Peter Clausen wrote: > >> On 03/10/2014 04:51 AM, li.xi...@freescale.com wrote: > > >

Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread Lars-Peter Clausen
On 03/10/2014 08:38 AM, Mark Brown wrote: On Mon, Mar 10, 2014 at 07:57:38AM +0100, Lars-Peter Clausen wrote: On 03/10/2014 04:51 AM, li.xi...@freescale.com wrote: Has there any other problems about this patch series? And this I had tested on our Vybrid-Twr board based on SGTL5000 codec and

Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread Mark Brown
On Mon, Mar 10, 2014 at 07:57:38AM +0100, Lars-Peter Clausen wrote: > On 03/10/2014 04:51 AM, li.xi...@freescale.com wrote: > >Has there any other problems about this patch series? And this I had tested > >on > >our Vybrid-Twr board based on SGTL5000 codec and SAI drivers. If not, I can >

Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread Lars-Peter Clausen
On 03/10/2014 04:51 AM, li.xi...@freescale.com wrote: Subject: Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: /* Default to using ALC auto offset calibration mode. */ snd_soc_update_bits(codec

Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread Lars-Peter Clausen
On 03/10/2014 04:51 AM, li.xi...@freescale.com wrote: Subject: Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: /* Default to using ALC auto offset calibration mode. */ snd_soc_update_bits(codec

Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread Mark Brown
On Mon, Mar 10, 2014 at 07:57:38AM +0100, Lars-Peter Clausen wrote: On 03/10/2014 04:51 AM, li.xi...@freescale.com wrote: Has there any other problems about this patch series? And this I had tested on our Vybrid-Twr board based on SGTL5000 codec and SAI drivers. If not, I can continue with

Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread Lars-Peter Clausen
On 03/10/2014 08:38 AM, Mark Brown wrote: On Mon, Mar 10, 2014 at 07:57:38AM +0100, Lars-Peter Clausen wrote: On 03/10/2014 04:51 AM, li.xi...@freescale.com wrote: Has there any other problems about this patch series? And this I had tested on our Vybrid-Twr board based on SGTL5000 codec and

RE: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread li.xi...@freescale.com
Subject: Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. On 03/10/2014 08:38 AM, Mark Brown wrote: On Mon, Mar 10, 2014 at 07:57:38AM +0100, Lars-Peter Clausen wrote: On 03/10/2014 04:51 AM, li.xi...@freescale.com wrote: Has there any other problems about

Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-10 Thread Timur Tabi
On Sun, Mar 2, 2014 at 8:42 PM, Xiubo Li li.xi...@freescale.com wrote: For some CODEC drivers like who act as the MFDs children are ignored by this patch. This makes no sense to me. Is there a comma missing, maybe? Regardless, I think this patch description is too short. -- To unsubscribe from

RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-09 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. > > On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: > > > > > /* Default to using ALC auto offset calibration mode. */ > > > > snd_soc

RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-09 Thread li.xi...@freescale.com
Subject: Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code. On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: /* Default to using ALC auto offset calibration mode. */ snd_soc_update_bits(codec, DA7213_ALC_CTRL1

Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-03 Thread Mark Brown
On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: > > > /* Default to using ALC auto offset calibration mode. */ > > > snd_soc_update_bits(codec, DA7213_ALC_CTRL1, > > > DA7213_ALC_CALIB_MODE_MAN, 0); > > This one will fail. > Sorry, I'm not very

Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-03 Thread Mark Brown
On Mon, Mar 03, 2014 at 07:24:36AM +, li.xi...@freescale.com wrote: /* Default to using ALC auto offset calibration mode. */ snd_soc_update_bits(codec, DA7213_ALC_CTRL1, DA7213_ALC_CALIB_MODE_MAN, 0); This one will fail. Sorry, I'm not very understand

RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
> > static int ak4535_probe(struct snd_soc_codec *codec) > > { > > - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec); > > - int ret; > > - > > - codec->control_data = ak4535->regmap; > > - ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP); > > - if (ret < 0) {

Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread Mark Brown
On Mon, Mar 03, 2014 at 10:42:22AM +0800, Xiubo Li wrote: > static int ak4535_probe(struct snd_soc_codec *codec) > { > - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec); > - int ret; > - > - codec->control_data = ak4535->regmap; > - ret =

[PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread Xiubo Li
For some CODEC drivers like who act as the MFDs children are ignored by this patch. Signed-off-by: Xiubo Li --- sound/soc/codecs/ad193x.c| 10 +- sound/soc/codecs/adau1373.c | 7 --- sound/soc/codecs/adav80x.c | 7 --- sound/soc/codecs/ak4535.c| 9

[PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread Xiubo Li
For some CODEC drivers like who act as the MFDs children are ignored by this patch. Signed-off-by: Xiubo Li --- sound/soc/codecs/ad193x.c| 10 +- sound/soc/codecs/adau1373.c | 7 --- sound/soc/codecs/adav80x.c | 7 --- sound/soc/codecs/ak4535.c| 9

[PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread Xiubo Li
For some CODEC drivers like who act as the MFDs children are ignored by this patch. Signed-off-by: Xiubo Li li.xi...@freescale.com --- sound/soc/codecs/ad193x.c| 10 +- sound/soc/codecs/adau1373.c | 7 --- sound/soc/codecs/adav80x.c | 7 ---

[PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread Xiubo Li
For some CODEC drivers like who act as the MFDs children are ignored by this patch. Signed-off-by: Xiubo Li li.xi...@freescale.com --- sound/soc/codecs/ad193x.c| 10 +- sound/soc/codecs/adau1373.c | 7 --- sound/soc/codecs/adav80x.c | 7 ---

Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread Mark Brown
On Mon, Mar 03, 2014 at 10:42:22AM +0800, Xiubo Li wrote: static int ak4535_probe(struct snd_soc_codec *codec) { - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec); - int ret; - - codec-control_data = ak4535-regmap; - ret = snd_soc_codec_set_cache_io(codec,

RE: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

2014-03-02 Thread li.xi...@freescale.com
static int ak4535_probe(struct snd_soc_codec *codec) { - struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec); - int ret; - - codec-control_data = ak4535-regmap; - ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP); - if (ret 0) { -