Re: [PATCHv3 3/4] watchdog: rti-wdt: attach to running watchdog during probe

2020-07-14 Thread Guenter Roeck
On 7/14/20 12:13 AM, Tero Kristo wrote: [ ... ] >>> Well, you can re-program it but... It does not take effect until next >>> window starts, so basically we need to take care of the currently running >>> window anyways after which re-programming it doesn't make much sense >>> anymore. And handl

Re: [PATCHv3 3/4] watchdog: rti-wdt: attach to running watchdog during probe

2020-07-14 Thread Tero Kristo
On 14/07/2020 10:06, Guenter Roeck wrote: On 7/13/20 11:50 PM, Tero Kristo wrote: On 14/07/2020 08:15, Guenter Roeck wrote: On 7/13/20 6:18 AM, Tero Kristo wrote: If the RTI watchdog is running already during probe, the driver must configure itself to match the HW. Window size and timeout is p

Re: [PATCHv3 3/4] watchdog: rti-wdt: attach to running watchdog during probe

2020-07-14 Thread Guenter Roeck
On 7/13/20 11:50 PM, Tero Kristo wrote: > On 14/07/2020 08:15, Guenter Roeck wrote: >> On 7/13/20 6:18 AM, Tero Kristo wrote: >>> If the RTI watchdog is running already during probe, the driver must >>> configure itself to match the HW. Window size and timeout is probed from >>> hardware, and the l

Re: [PATCHv3 3/4] watchdog: rti-wdt: attach to running watchdog during probe

2020-07-13 Thread Tero Kristo
On 14/07/2020 08:15, Guenter Roeck wrote: On 7/13/20 6:18 AM, Tero Kristo wrote: If the RTI watchdog is running already during probe, the driver must configure itself to match the HW. Window size and timeout is probed from hardware, and the last keepalive ping is adjusted to match it also. Sign

Re: [PATCHv3 3/4] watchdog: rti-wdt: attach to running watchdog during probe

2020-07-13 Thread Guenter Roeck
On 7/13/20 6:18 AM, Tero Kristo wrote: > If the RTI watchdog is running already during probe, the driver must > configure itself to match the HW. Window size and timeout is probed from > hardware, and the last keepalive ping is adjusted to match it also. > > Signed-off-by: Tero Kristo > --- > dr

Re: [PATCHv3 3/4] watchdog: rti-wdt: attach to running watchdog during probe

2020-07-13 Thread kernel test robot
Hi Tero, I love your patch! Yet something to improve: [auto build test ERROR on hwmon/hwmon-next] [also build test ERROR on linux/master linus/master v5.8-rc5 next-20200713] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as do

Re: [PATCHv3 3/4] watchdog: rti-wdt: attach to running watchdog during probe

2020-07-13 Thread kernel test robot
Hi Tero, I love your patch! Yet something to improve: [auto build test ERROR on hwmon/hwmon-next] [also build test ERROR on linux/master linus/master v5.8-rc5 next-20200713] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as do

[PATCHv3 3/4] watchdog: rti-wdt: attach to running watchdog during probe

2020-07-13 Thread Tero Kristo
If the RTI watchdog is running already during probe, the driver must configure itself to match the HW. Window size and timeout is probed from hardware, and the last keepalive ping is adjusted to match it also. Signed-off-by: Tero Kristo --- drivers/watchdog/rti_wdt.c | 111 ++