Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Santosh Shilimkar
Mark, On Thursday 07 February 2013 10:47 PM, Mark Rutland wrote: [..] I believe the patch below will fix this for Tegra and any other platforms where broadcast is required in low power states. From the Stephan's crash the issue is pretty clear and your patch make sense. Some how I didn't man

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Santosh Shilimkar
On Thursday 07 February 2013 10:21 PM, Stephen Warren wrote: On 02/07/2013 04:40 AM, Santosh Shilimkar wrote: [...] Stephan, Do we have crash log seen on Tegra ? Which tegra CPUIDLE driver is being used when crash is seen ? The crash log is below. It's simply because td->evt->broadcast is N

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Mark Rutland
[...] > > The intent of 12ad100046: "clockevents: Add generic timer broadcast > > function" > > was to setup the broadcast function both for non-functional/dummy timers and > > those that stop in low-power states (CLOCK_EVT_FEAT_C3STOP). I missed the > > CLOCK_EVT_FEAT_C3STOP case. > > > > I bel

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Mark Rutland
[...] > > The intent of 12ad100046: "clockevents: Add generic timer broadcast > > function" > > was to setup the broadcast function both for non-functional/dummy timers and > > those that stop in low-power states (CLOCK_EVT_FEAT_C3STOP). I missed the > > CLOCK_EVT_FEAT_C3STOP case. > > > I am not

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Stephen Warren
On 02/07/2013 04:40 AM, Santosh Shilimkar wrote: > Mark, > > On Thursday 07 February 2013 03:34 PM, Mark Rutland wrote: >> Hi Stephen, >> >> Sorry about this; I'm to blame for the bug. >> >> On Wed, Feb 06, 2013 at 08:51:43PM +, Stephen Warren wrote: >>> On 01/14/2013 10:05 AM, Mark Rutland wr

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Stephen Warren
On 02/07/2013 03:04 AM, Mark Rutland wrote: > Hi Stephen, > > Sorry about this; I'm to blame for the bug. > > On Wed, Feb 06, 2013 at 08:51:43PM +, Stephen Warren wrote: >> On 01/14/2013 10:05 AM, Mark Rutland wrote: >>> Implement timer_broadcast for the arm architecture, allowing for the use

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Santosh Shilimkar
Mark, On Thursday 07 February 2013 03:34 PM, Mark Rutland wrote: Hi Stephen, Sorry about this; I'm to blame for the bug. On Wed, Feb 06, 2013 at 08:51:43PM +, Stephen Warren wrote: On 01/14/2013 10:05 AM, Mark Rutland wrote: Implement timer_broadcast for the arm architecture, allowing fo

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Mark Rutland
Hi Stephen, Sorry about this; I'm to blame for the bug. On Wed, Feb 06, 2013 at 08:51:43PM +, Stephen Warren wrote: > On 01/14/2013 10:05 AM, Mark Rutland wrote: > > Implement timer_broadcast for the arm architecture, allowing for the use > > of clock_event_device_drivers decoupled from the t

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-06 Thread Stephen Warren
On 01/14/2013 10:05 AM, Mark Rutland wrote: > Implement timer_broadcast for the arm architecture, allowing for the use > of clock_event_device_drivers decoupled from the timer tick broadcast > mechanism. Mark, this patch is now in next-20130206 and causes a crash during boot on Tegra. The reason a

[PATCHv3 4/4] arm: Add generic timer broadcast support

2013-01-14 Thread Mark Rutland
Implement timer_broadcast for the arm architecture, allowing for the use of clock_event_device_drivers decoupled from the timer tick broadcast mechanism. Signed-off-by: Mark Rutland Reviewed-by: Santosh Shilimkar Tested-by: Santosh Shilimkar Reviewed-by: Stephen Boyd --- arch/arm/Kconfig