Re: [PATCHv3 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Joe Stringer
On 4 December 2014 at 12:17, Tom Herbert wrote: > On Thu, Dec 4, 2014 at 10:39 AM, Joe Stringer wrote: >> ndo_gso_check() was recently introduced to allow NICs to report the >> offloading support that they have on a per-skb basis. Add an >> implementation for this driver which checks for IPIP, GR

Re: [linux-nics] [PATCHv3 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Joe Stringer
>> > +#define MAX_TUNNEL_HDR_LEN 80 >> >> I'd #define this just above the function, if not at the start of the >> file... Right, the style for most of this file is to place the #define like this above the function. I'll do that. -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCHv3 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Tom Herbert
On Thu, Dec 4, 2014 at 10:39 AM, Joe Stringer wrote: > ndo_gso_check() was recently introduced to allow NICs to report the > offloading support that they have on a per-skb basis. Add an > implementation for this driver which checks for IPIP, GRE, UDP tunnels. > > Signed-off-by: Joe Stringer > ---

Re: [linux-nics] [PATCHv3 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Jeff Kirsher
On Thu, 2014-12-04 at 22:11 +0300, Sergei Shtylyov wrote: > Hello. > > On 12/04/2014 09:39 PM, Joe Stringer wrote: > > > ndo_gso_check() was recently introduced to allow NICs to report the > > offloading support that they have on a per-skb basis. Add an > > implementation for this driver which ch

Re: [PATCHv3 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Sergei Shtylyov
Hello. On 12/04/2014 09:39 PM, Joe Stringer wrote: ndo_gso_check() was recently introduced to allow NICs to report the offloading support that they have on a per-skb basis. Add an implementation for this driver which checks for IPIP, GRE, UDP tunnels. Signed-off-by: Joe Stringer --- v3: Dro

Re: [PATCHv3 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Jeff Kirsher
On Thu, 2014-12-04 at 10:39 -0800, Joe Stringer wrote: > ndo_gso_check() was recently introduced to allow NICs to report the > offloading support that they have on a per-skb basis. Add an > implementation for this driver which checks for IPIP, GRE, UDP > tunnels. > > Signed-off-by: Joe Stringer >

[PATCHv3 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Joe Stringer
ndo_gso_check() was recently introduced to allow NICs to report the offloading support that they have on a per-skb basis. Add an implementation for this driver which checks for IPIP, GRE, UDP tunnels. Signed-off-by: Joe Stringer --- v3: Drop IPIP and GRE (no driver support even though hw supports