Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-28 Thread Sai Prakash Ranjan
On 1/28/2019 10:45 PM, Mathieu Poirier wrote: For SDM845(A75 based): *0xB_B8_03* does indicate that the JEP106 identification code is 0x3B and continuation code is 0x4 which is of ARM and not QCOM(JEP106 ID is 0x70) which is expected. And the other values of PIDR0[0:7] and PIDR1[3:0] are

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-28 Thread Mathieu Poirier
On Thu, 24 Jan 2019 at 11:21, Sai Prakash Ranjan wrote: > > Hi Suzuki, > > On 1/24/2019 4:49 PM, Suzuki K Poulose wrote: > > Hi Sai, > > > > > > That looks fine with me. But as Mathieu said, this needs to be a separate > > patch. But before all that please could you provide me the PIDR4 value for

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-24 Thread Sai Prakash Ranjan
Good day Mathieu, On 1/24/2019 9:37 PM, Mathieu Poirier wrote: Good day Sai, On Wed, 23 Jan 2019 at 13:18, Sai Prakash Ranjan wrote: Hi Mathieu, On 1/24/2019 12:44 AM, Mathieu Poirier wrote: On Wed, 23 Jan 2019 at 05:12, Sai Prakash Ranjan wrote: That depends on whether the ETMs have

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-24 Thread Sai Prakash Ranjan
On 1/24/2019 9:37 PM, Marc Gonzalez wrote: On 23/01/2019 21:17, Sai Prakash Ranjan wrote: On 1/24/2019 12:44 AM, Mathieu Poirier wrote: What version of the Kryo CPU? There is no Kryo version for MSM8996 (its only given as Kryo), MSM8998 onwards we have Kryo versions like Kryo 280 and so

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-24 Thread Sai Prakash Ranjan
Hi Suzuki, On 1/24/2019 4:49 PM, Suzuki K Poulose wrote: Hi Sai, That looks fine with me. But as Mathieu said, this needs to be a separate patch. But before all that please could you provide me the PIDR4 value for the Kryo A75 and A55 please ? Sure. PIDR4 value is 0x4. I get it now. So

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-24 Thread Mathieu Poirier
Good day Sai, On Wed, 23 Jan 2019 at 13:18, Sai Prakash Ranjan wrote: > > Hi Mathieu, > > On 1/24/2019 12:44 AM, Mathieu Poirier wrote: > > On Wed, 23 Jan 2019 at 05:12, Sai Prakash Ranjan > > wrote: > > > > That depends on whether the ETMs have been modified at all, something > > Suzuki has

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-24 Thread Marc Gonzalez
On 23/01/2019 21:17, Sai Prakash Ranjan wrote: > On 1/24/2019 12:44 AM, Mathieu Poirier wrote: > >> What version of the Kryo CPU? > > There is no Kryo version for MSM8996 (its only given as Kryo), MSM8998 > onwards we have Kryo versions like Kryo 280 and so on. Hence I skipped > for this one and

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-24 Thread Suzuki K Poulose
Hi Sai, On 23/01/2019 12:11, Sai Prakash Ranjan wrote: Hi Suzuki, On 1/23/2019 1:42 AM, Suzuki K Poulose wrote: Hi Sai, On 01/22/2019 04:48 PM, Sai Prakash Ranjan wrote: Hi Suzuki, [..] SDM845 has 4 Kryo 385 Gold (ARM A75) + 4 Kryo 385 Silver (ARM A55), so the PID values should be same

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-23 Thread Sai Prakash Ranjan
Hi Mathieu, On 1/24/2019 12:44 AM, Mathieu Poirier wrote: On Wed, 23 Jan 2019 at 05:12, Sai Prakash Ranjan wrote: That depends on whether the ETMs have been modified at all, something Suzuki has asked to be clarified. If ETMs have been modified then we need to understand how they differ from

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-23 Thread Mathieu Poirier
On Wed, 23 Jan 2019 at 05:12, Sai Prakash Ranjan wrote: > > Hi Suzuki, > > On 1/23/2019 1:42 AM, Suzuki K Poulose wrote: > > Hi Sai, > > > > On 01/22/2019 04:48 PM, Sai Prakash Ranjan wrote: > >> Hi Suzuki, > >> > [..] > >> > >> SDM845 has 4 Kryo 385 Gold (ARM A75) + 4 Kryo 385 Silver (ARM A55),

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-23 Thread Sai Prakash Ranjan
Hi Suzuki, On 1/23/2019 1:42 AM, Suzuki K Poulose wrote: Hi Sai, On 01/22/2019 04:48 PM, Sai Prakash Ranjan wrote: Hi Suzuki, [..] SDM845 has 4 Kryo 385 Gold (ARM A75) + 4 Kryo 385 Silver (ARM A55), so the PID values should be same for 4 ETMs atleast. But here one pid value(001bb803) is

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-22 Thread Suzuki K Poulose
Hi Sai, On 01/22/2019 04:48 PM, Sai Prakash Ranjan wrote: Hi Suzuki, On 1/22/2019 9:38 PM, Suzuki K Poulose wrote: By inconsistent, I meant the registers provides values which are not the same on two different CPUs of the *same type*. And it is expected that two different CPU/ETM

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-22 Thread Sai Prakash Ranjan
Hi Suzuki, On 1/22/2019 9:38 PM, Suzuki K Poulose wrote: By inconsistent, I meant the registers provides values which are not the same on two different CPUs of the *same type*. And it is expected that two different CPU/ETM implementations will have different PIDs. SDM845 has 4 Kryo 385 Gold

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-22 Thread Suzuki K Poulose
Hi Sai, On 01/22/2019 03:02 PM, Sai Prakash Ranjan wrote: Hi Suzuki, Thanks for looking into this. Please find my response inline. On 1/22/2019 7:30 PM, Suzuki K Poulose wrote: Hi Sai, On 01/22/2019 01:37 PM, Sai Prakash Ranjan wrote: Add coresight components found on Qualcomm SDM845 SoC.

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-22 Thread Sai Prakash Ranjan
Hi Suzuki, Thanks for looking into this. Please find my response inline. On 1/22/2019 7:30 PM, Suzuki K Poulose wrote: Hi Sai, On 01/22/2019 01:37 PM, Sai Prakash Ranjan wrote: Add coresight components found on Qualcomm SDM845 SoC. Signed-off-by: Sai Prakash Ranjan Sorry, but I hadn't

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-22 Thread Suzuki K Poulose
Hi Sai, On 01/22/2019 01:37 PM, Sai Prakash Ranjan wrote: Add coresight components found on Qualcomm SDM845 SoC. Signed-off-by: Sai Prakash Ranjan Sorry, but I hadn't noticed the PID override strings below. Please find the question. --- Depends on AOSS QMP side channel patches and AMBA

[PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-22 Thread Sai Prakash Ranjan
Add coresight components found on Qualcomm SDM845 SoC. Signed-off-by: Sai Prakash Ranjan --- Depends on AOSS QMP side channel patches and AMBA bus pclk change by Bjorn Andersson [1][2]. Also depends on patch ("arm64: dts: qcom: sdm845: Increase address and size cells for soc") [3]. [1]