Re: [PATCHv4 10/10] arm64: Add support for CONFIG_DEBUG_VIRTUAL

2016-12-06 Thread Mark Rutland
On Tue, Nov 29, 2016 at 10:55:29AM -0800, Laura Abbott wrote: > > + WARN(!__is_lm_address(x), > + "virt_to_phys used for non-linear address :%pK\n", (void *)x); Nit: s/ :/: / It might be worth adding %pS too; i.e. WARN(!__is_lm_address(x), "virt_to_phys used

Re: [PATCHv4 10/10] arm64: Add support for CONFIG_DEBUG_VIRTUAL

2016-12-06 Thread Mark Rutland
On Tue, Nov 29, 2016 at 10:55:29AM -0800, Laura Abbott wrote: > > + WARN(!__is_lm_address(x), > + "virt_to_phys used for non-linear address :%pK\n", (void *)x); Nit: s/ :/: / It might be worth adding %pS too; i.e. WARN(!__is_lm_address(x), "virt_to_phys used

[PATCHv4 10/10] arm64: Add support for CONFIG_DEBUG_VIRTUAL

2016-11-29 Thread Laura Abbott
x86 has an option CONFIG_DEBUG_VIRTUAL to do additional checks on virt_to_phys calls. The goal is to catch users who are calling virt_to_phys on non-linear addresses immediately. This inclues callers using virt_to_phys on image addresses instead of __pa_symbol. As features such as

[PATCHv4 10/10] arm64: Add support for CONFIG_DEBUG_VIRTUAL

2016-11-29 Thread Laura Abbott
x86 has an option CONFIG_DEBUG_VIRTUAL to do additional checks on virt_to_phys calls. The goal is to catch users who are calling virt_to_phys on non-linear addresses immediately. This inclues callers using virt_to_phys on image addresses instead of __pa_symbol. As features such as