RE: [PATCHv5] procfs: show hierarchy of pid namespace

teusz Guzik; David > Howells; > Eric W. Biederman > Subject: Re: [PATCHv5] procfs: show hierarchy of pid namespace > > If pidns_list_add fails, the get_pid taken in the caller leaks. > Will fix in the next patch. > It's not clear to me that the loop in 'if curns

Re: [PATCHv5] procfs: show hierarchy of pid namespace

If pidns_list_add fails, the get_pid taken in the caller leaks. It's not clear to me that the loop in 'if curns' will always end in a list_add_tail, and if not the get_pid leaks. It does look like it should, but something to catch the unexpected failure (especially after someone modifies that

RE: [PATCHv5] procfs: show hierarchy of pid namespace

er.kernel.org > Cc: Richard Weinberger; Serge Hallyn; Oleg Nesterov; Mateusz Guzik; David > Howells; > Eric W. Biederman > Subject: [PATCHv5] procfs: show hierarchy of pid namespace > > We lack of pid hierarchy information, and this will lead to: > a) we don't know pids' re

[PATCHv5] procfs: show hierarchy of pid namespace

We lack of pid hierarchy information, and this will lead to: a) we don't know pids' relationship, who is whose child: /proc/PID/ns/pid only tell us whether two pids live in same ns; b) bring trouble to nested lxc container check/restore/migration c) bring trouble to pid translation between conta