Re: [PATCHv5 07/19] x86/mm: Mask out KeyID bits from page table entry pfn

2018-07-20 Thread Kirill A. Shutemov
On Thu, Jul 19, 2018 at 07:19:01AM -0700, Dave Hansen wrote: > On 07/19/2018 02:54 AM, Kirill A. Shutemov wrote: > > On Wed, Jul 18, 2018 at 04:13:20PM -0700, Dave Hansen wrote: > >> On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > >>> + } else { > >>> + /* > >>> + * Reset __PHY

Re: [PATCHv5 07/19] x86/mm: Mask out KeyID bits from page table entry pfn

2018-07-19 Thread Dave Hansen
On 07/19/2018 02:54 AM, Kirill A. Shutemov wrote: > On Wed, Jul 18, 2018 at 04:13:20PM -0700, Dave Hansen wrote: >> On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: >>> + } else { >>> + /* >>> +* Reset __PHYSICAL_MASK. >>> +* Maybe needed if there's inconsistent

Re: [PATCHv5 07/19] x86/mm: Mask out KeyID bits from page table entry pfn

2018-07-19 Thread Kirill A. Shutemov
On Wed, Jul 18, 2018 at 04:13:20PM -0700, Dave Hansen wrote: > On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > > + } else { > > + /* > > +* Reset __PHYSICAL_MASK. > > +* Maybe needed if there's inconsistent configuation > > +* between CPUs. > > +

Re: [PATCHv5 07/19] x86/mm: Mask out KeyID bits from page table entry pfn

2018-07-18 Thread Dave Hansen
On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > + } else { > + /* > + * Reset __PHYSICAL_MASK. > + * Maybe needed if there's inconsistent configuation > + * between CPUs. > + */ > + physical_mask = (1ULL << __PHYSIC

[PATCHv5 07/19] x86/mm: Mask out KeyID bits from page table entry pfn

2018-07-17 Thread Kirill A. Shutemov
MKTME claims several upper bits of the physical address in a page table entry to encode KeyID. It effectively shrinks number of bits for physical address. We should exclude KeyID bits from physical addresses. For instance, if CPU enumerates 52 physical address bits and number of bits claimed for K