Re: [PATCHv5 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-25 Thread Grant Likely
On Thu, 24 Oct 2013 00:49:42 +0200, Sebastian Reichel wrote: > On Wed, Oct 23, 2013 at 05:24:14PM -0500, Rob Herring wrote: > > So a twl4030 device is only a power button? DT should describe the h/w > > not a node for a sub-function of a device. > > No. TWL4030 is a companion chip for the OMAP3 p

Re: [PATCHv5 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-23 Thread Sebastian Reichel
On Wed, Oct 23, 2013 at 05:24:14PM -0500, Rob Herring wrote: > So a twl4030 device is only a power button? DT should describe the h/w > not a node for a sub-function of a device. No. TWL4030 is a companion chip for the OMAP3 processor. It provides miscellaneous functionality, e.g.: * RTC * Watc

Re: [PATCHv5 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-23 Thread Rob Herring
On 10/23/2013 03:26 PM, Sebastian Reichel wrote: > Add device tree support for twl4030 power button driver. > > Signed-off-by: Sebastian Reichel > --- > .../devicetree/bindings/input/twl4030-pwrbutton.txt | 13 + > drivers/input/misc/twl4030-pwrbutton.c | 16 >

[PATCHv5 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-23 Thread Sebastian Reichel
Add device tree support for twl4030 power button driver. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/input/twl4030-pwrbutton.txt | 13 + drivers/input/misc/twl4030-pwrbutton.c | 16 2 files changed, 25 insertions(+), 4 deletion