Re: [PATCHv5 17/19] x86/mm: Implement sync_direct_mapping()

2018-07-23 Thread Dave Hansen
On 07/23/2018 03:04 AM, Kirill A. Shutemov wrote: > On Wed, Jul 18, 2018 at 05:01:37PM -0700, Dave Hansen wrote:>> Please make an > effort to refactor this to reuse the code that we already >> have to manage the direct mapping. We can't afford 455 new lines of >> page table manipulation that nobo

Re: [PATCHv5 17/19] x86/mm: Implement sync_direct_mapping()

2018-07-23 Thread Kirill A. Shutemov
On Wed, Jul 18, 2018 at 05:01:37PM -0700, Dave Hansen wrote: > On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > > arch/x86/include/asm/mktme.h | 8 + > > arch/x86/mm/init_64.c| 10 + > > arch/x86/mm/mktme.c | 437 +++ > > 3 files changed, 455

Re: [PATCHv5 17/19] x86/mm: Implement sync_direct_mapping()

2018-07-18 Thread Dave Hansen
On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote: > arch/x86/include/asm/mktme.h | 8 + > arch/x86/mm/init_64.c| 10 + > arch/x86/mm/mktme.c | 437 +++ > 3 files changed, 455 insertions(+) I'm not the maintainer. But, NAK from me on this on the

[PATCHv5 17/19] x86/mm: Implement sync_direct_mapping()

2018-07-17 Thread Kirill A. Shutemov
For MKTME we use per-KeyID direct mappings. This allows kernel to have access to encrypted memory. sync_direct_mapping() sync per-KeyID direct mappings with a canonical one -- KeyID-0. The function tracks changes in the canonical mapping: - creating or removing chunks of the translation tree; -