Re: [PATCHv5 2/3] kernel: add support for live patching

2014-12-09 Thread Petr Mladek
On Thu 2014-12-04 09:53:30, Seth Jennings wrote: Hi, it is great progress. I think that we are getting close to finalize this initial patch set. I have few comments and will send few patches that will handle most of them. On Thu 2014-12-04 09:53:30, Seth Jennings wrote: > This commit introduces

Re: [PATCHv5 2/3] kernel: add support for live patching

2014-12-09 Thread Petr Mladek
On Thu 2014-12-04 09:53:30, Seth Jennings wrote: Hi, it is great progress. I think that we are getting close to finalize this initial patch set. I have few comments and will send few patches that will handle most of them. On Thu 2014-12-04 09:53:30, Seth Jennings wrote: This commit introduces

Re: [PATCHv5 2/3] kernel: add support for live patching

2014-12-05 Thread Josh Poimboeuf
On Fri, Dec 05, 2014 at 06:55:04PM +0100, Jiri Slaby wrote: > On 12/04/2014, 04:53 PM, Seth Jennings wrote: > ... > > --- /dev/null > > +++ b/kernel/livepatch/core.c > > @@ -0,0 +1,902 @@ > ... > > +static struct kobj_type klp_ktype_patch = { > > + .sysfs_ops = _sysfs_ops, > > + .default_attrs

Re: [PATCHv5 2/3] kernel: add support for live patching

2014-12-05 Thread Jiri Slaby
On 12/04/2014, 04:53 PM, Seth Jennings wrote: ... > --- /dev/null > +++ b/kernel/livepatch/core.c > @@ -0,0 +1,902 @@ ... > +static struct kobj_type klp_ktype_patch = { > + .sysfs_ops = _sysfs_ops, > + .default_attrs = klp_patch_attrs > +}; Hi, I seem to have only a single comment here.

Re: [PATCHv5 2/3] kernel: add support for live patching

2014-12-05 Thread Jiri Slaby
On 12/04/2014, 04:53 PM, Seth Jennings wrote: ... --- /dev/null +++ b/kernel/livepatch/core.c @@ -0,0 +1,902 @@ ... +static struct kobj_type klp_ktype_patch = { + .sysfs_ops = kobj_sysfs_ops, + .default_attrs = klp_patch_attrs +}; Hi, I seem to have only a single comment here. If I

Re: [PATCHv5 2/3] kernel: add support for live patching

2014-12-05 Thread Josh Poimboeuf
On Fri, Dec 05, 2014 at 06:55:04PM +0100, Jiri Slaby wrote: On 12/04/2014, 04:53 PM, Seth Jennings wrote: ... --- /dev/null +++ b/kernel/livepatch/core.c @@ -0,0 +1,902 @@ ... +static struct kobj_type klp_ktype_patch = { + .sysfs_ops = kobj_sysfs_ops, + .default_attrs =

[PATCHv5 2/3] kernel: add support for live patching

2014-12-04 Thread Seth Jennings
This commit introduces code for the live patching core. It implements an ftrace-based mechanism and kernel interface for doing live patching of kernel and kernel module functions. It represents the greatest common functionality set between kpatch and kgraft and can accept patches built using

[PATCHv5 2/3] kernel: add support for live patching

2014-12-04 Thread Seth Jennings
This commit introduces code for the live patching core. It implements an ftrace-based mechanism and kernel interface for doing live patching of kernel and kernel module functions. It represents the greatest common functionality set between kpatch and kgraft and can accept patches built using