Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-27 Thread Kumar Gala
On Oct 26, 2013, at 6:31 AM, Sebastian Reichel wrote: > On Sat, Oct 26, 2013 at 01:37:57AM -0500, Kumar Gala wrote: >> >> On Oct 25, 2013, at 5:18 PM, Sebastian Reichel wrote: >> >>> On Fri, Oct 25, 2013 at 04:41:20PM -0500, Kumar Gala wrote: On Oct 24, 2013, at 9:48 AM, Sebastian Reichel

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-27 Thread Grant Likely
On Sat, 26 Oct 2013 01:40:31 +0200, Sebastian Reichel wrote: > On Fri, Oct 25, 2013 at 08:09:04PM +0100, Grant Likely wrote: > > On Thu, 24 Oct 2013 16:48:44 +0200, Sebastian Reichel > > wrote: > > > Add device tree support for twl4030 power button driver. > > > > The above commit text is insuf

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-26 Thread Sebastian Reichel
On Sat, Oct 26, 2013 at 01:37:57AM -0500, Kumar Gala wrote: > > On Oct 25, 2013, at 5:18 PM, Sebastian Reichel wrote: > > > On Fri, Oct 25, 2013 at 04:41:20PM -0500, Kumar Gala wrote: > >> On Oct 24, 2013, at 9:48 AM, Sebastian Reichel wrote: > >>> +- interrupt: should be one of the following > >

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-25 Thread Kumar Gala
On Oct 25, 2013, at 5:18 PM, Sebastian Reichel wrote: > On Fri, Oct 25, 2013 at 04:41:20PM -0500, Kumar Gala wrote: >> On Oct 24, 2013, at 9:48 AM, Sebastian Reichel wrote: >>> +- interrupt: should be one of the following >>> + - <8>: For controllers compatible with twl4030 >> >> Just checking

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-25 Thread Sebastian Reichel
On Fri, Oct 25, 2013 at 08:09:04PM +0100, Grant Likely wrote: > On Thu, 24 Oct 2013 16:48:44 +0200, Sebastian Reichel wrote: > > Add device tree support for twl4030 power button driver. > > The above commit text is insufficient. There are changes in the patch > that aren't described here and have

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-25 Thread Grant Likely
On Thu, 24 Oct 2013 16:48:44 +0200, Sebastian Reichel wrote: > Add device tree support for twl4030 power button driver. The above commit text is insufficient. There are changes in the patch that aren't described here and have nothing to do with device tree bindings. > > Signed-off-by: Sebastian

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-25 Thread Sebastian Reichel
On Fri, Oct 25, 2013 at 04:41:20PM -0500, Kumar Gala wrote: > On Oct 24, 2013, at 9:48 AM, Sebastian Reichel wrote: > > +- interrupt: should be one of the following > > + - <8>: For controllers compatible with twl4030 > > Just checking, but the interrupt is always 8 for this device? Yes. It's c

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-25 Thread Kumar Gala
On Oct 24, 2013, at 9:48 AM, Sebastian Reichel wrote: > Add device tree support for twl4030 power button driver. > > Signed-off-by: Sebastian Reichel > --- > .../devicetree/bindings/input/twl4030-pwrbutton.txt | 21 + > drivers/input/misc/twl4030-pwrbutton.c | 16

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-25 Thread Sebastian Reichel
Hi Péter, On Fri, Oct 25, 2013 at 03:46:02PM +0300, Peter Ujfalusi wrote: > > [...] > > +#if IS_ENABLED(CONFIG_OF) > > You don't need to do this. It's done like this in all the other drivers. > > +static const struct of_device_id twl4030_pwrbutton_dt_match_table[] = { > > + { .compatible

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-25 Thread Peter Ujfalusi
On 10/24/2013 05:48 PM, Sebastian Reichel wrote: > Add device tree support for twl4030 power button driver. > > Signed-off-by: Sebastian Reichel > --- > .../devicetree/bindings/input/twl4030-pwrbutton.txt | 21 > + > drivers/input/misc/twl4030-pwrbutton.c | 16 +

Re: [PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-25 Thread Florian Vaussard
Hello, On 10/24/2013 04:48 PM, Sebastian Reichel wrote: > Add device tree support for twl4030 power button driver. > > Signed-off-by: Sebastian Reichel I tested on my OMAP3 board, the button event works as expected. So for the DT boot, feel free to add my: Tested-by: Florian Vaussard Best re

[PATCHv6 1/3] Input: twl4030-pwrbutton - add device tree support

2013-10-24 Thread Sebastian Reichel
Add device tree support for twl4030 power button driver. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/input/twl4030-pwrbutton.txt | 21 + drivers/input/misc/twl4030-pwrbutton.c | 16 2 files changed, 33 insertions(+), 4 deletions(