Re: [PATCHv6 1/3] usb: USB Type-C connector class

On 08/31/2016 04:09 AM, Heikki Krogerus wrote: Hi guys, On Tue, Aug 30, 2016 at 06:47:41AM -0700, Guenter Roeck wrote: On 08/30/2016 06:11 AM, Heikki Krogerus wrote: Hi, On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On 08/31/2016 04:09 AM, Heikki Krogerus wrote: Hi guys, On Tue, Aug 30, 2016 at 06:47:41AM -0700, Guenter Roeck wrote: On 08/30/2016 06:11 AM, Heikki Krogerus wrote: Hi, On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi guys, On Tue, Aug 30, 2016 at 06:47:41AM -0700, Guenter Roeck wrote: > On 08/30/2016 06:11 AM, Heikki Krogerus wrote: > > Hi, > > > > On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: > > > On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: > > > > Error reporting

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi guys, On Tue, Aug 30, 2016 at 06:47:41AM -0700, Guenter Roeck wrote: > On 08/30/2016 06:11 AM, Heikki Krogerus wrote: > > Hi, > > > > On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: > > > On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: > > > > Error reporting

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Heikki, On Tue, Aug 30, 2016 at 11:22:27AM +0300, Heikki Krogerus wrote: > > How about if I add the "supports_usb_power_delivery" attribute for the > partners instead to give some details about them. Any objections? > After looking into the code again, I assume the idea is to have the existing

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Heikki, On Tue, Aug 30, 2016 at 11:22:27AM +0300, Heikki Krogerus wrote: > > How about if I add the "supports_usb_power_delivery" attribute for the > partners instead to give some details about them. Any objections? > After looking into the code again, I assume the idea is to have the existing

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Heikki, On Tue, Aug 30, 2016 at 01:04:37PM +0300, Heikki Krogerus wrote: > Hi Oliver, > > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//current_data_role > > > +Date:

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Heikki, On Tue, Aug 30, 2016 at 01:04:37PM +0300, Heikki Krogerus wrote: > Hi Oliver, > > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//current_data_role > > > +Date:

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hello Heikki, On Tue, Aug 30, 2016 at 11:22:27AM +0300, Heikki Krogerus wrote: > > > > If you are only interested in accessory mode support, maybe we don't need > > the 'type' attribute at all. We could make the 'accessory' attribute always > > visible and display one of "none", "Audio",

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hello Heikki, On Tue, Aug 30, 2016 at 11:22:27AM +0300, Heikki Krogerus wrote: > > > > If you are only interested in accessory mode support, maybe we don't need > > the 'type' attribute at all. We could make the 'accessory' attribute always > > visible and display one of "none", "Audio",

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Tue, Aug 30, 2016 at 06:46:24AM -0700, Guenter Roeck wrote: > On 08/30/2016 03:04 AM, Heikki Krogerus wrote: > > Hi Oliver, > > > > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > > +What:

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Tue, Aug 30, 2016 at 06:46:24AM -0700, Guenter Roeck wrote: > On 08/30/2016 03:04 AM, Heikki Krogerus wrote: > > Hi Oliver, > > > > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > > +What:

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On 08/30/2016 06:11 AM, Heikki Krogerus wrote: Hi, On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: Error reporting does not require a synchronous operation. Reporting it in the next read() or write() and making it

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On 08/30/2016 06:11 AM, Heikki Krogerus wrote: Hi, On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: Error reporting does not require a synchronous operation. Reporting it in the next read() or write() and making it

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On 08/30/2016 03:04 AM, Heikki Krogerus wrote: Hi Oliver, On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: +What: /sys/class/typec//current_data_role +Date: June 2016 +Contact: Heikki Krogerus

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On 08/30/2016 03:04 AM, Heikki Krogerus wrote: Hi Oliver, On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: +What: /sys/class/typec//current_data_role +Date: June 2016 +Contact: Heikki Krogerus

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi, On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: > On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: > > Error reporting does not require a synchronous operation. Reporting > > it in the next read() or write() and making it pollable is perfectly > > viable. It

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi, On Tue, Aug 30, 2016 at 02:49:50PM +0300, Heikki Krogerus wrote: > On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: > > Error reporting does not require a synchronous operation. Reporting > > it in the next read() or write() and making it pollable is perfectly > > viable. It

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: > On Tue, 2016-08-30 at 13:04 +0300, Heikki Krogerus wrote: > > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > > Hi, > > > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > > +What:

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Tue, Aug 30, 2016 at 01:16:46PM +0200, Oliver Neukum wrote: > On Tue, 2016-08-30 at 13:04 +0300, Heikki Krogerus wrote: > > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > > Hi, > > > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > > +What:

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Tue, 2016-08-30 at 13:04 +0300, Heikki Krogerus wrote: > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: Hi, > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//current_data_role > > > +Date: June 2016 > > > +Contact:

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Tue, 2016-08-30 at 13:04 +0300, Heikki Krogerus wrote: > On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: Hi, > > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//current_data_role > > > +Date: June 2016 > > > +Contact:

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi Oliver, On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > +What: /sys/class/typec//current_data_role > > +Date: June 2016 > > +Contact: Heikki Krogerus > >

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi Oliver, On Tue, Aug 30, 2016 at 11:32:01AM +0200, Oliver Neukum wrote: > On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > > +What: /sys/class/typec//current_data_role > > +Date: June 2016 > > +Contact: Heikki Krogerus > > +Description: > > +

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > +What: /sys/class/typec//current_data_role > +Date: June 2016 > +Contact: Heikki Krogerus > +Description: > + The current USB data role the port is operating in. >

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Mon, 2016-08-29 at 15:36 +0300, Heikki Krogerus wrote: > +What: /sys/class/typec//current_data_role > +Date: June 2016 > +Contact: Heikki Krogerus > +Description: > + The current USB data role the port is operating in. > This > + attribute

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi Guenter, On Mon, Aug 29, 2016 at 11:50:49AM -0700, Guenter Roeck wrote: > Hello Heikki, > > On Mon, Aug 29, 2016 at 05:07:39PM +0300, Heikki Krogerus wrote: > > Hi Guenter, > > > > > > Overall this is quite vague and, especially for chargers, most of the > > > > time > > > > misses the

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi Guenter, On Mon, Aug 29, 2016 at 11:50:49AM -0700, Guenter Roeck wrote: > Hello Heikki, > > On Mon, Aug 29, 2016 at 05:07:39PM +0300, Heikki Krogerus wrote: > > Hi Guenter, > > > > > > Overall this is quite vague and, especially for chargers, most of the > > > > time > > > > misses the

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hello Heikki, On Mon, Aug 29, 2016 at 05:07:39PM +0300, Heikki Krogerus wrote: > Hi Guenter, > > > > Overall this is quite vague and, especially for chargers, most of the time > > > misses the point. > > > > > > I would really prefer if we could stay closer to the specification in this > > >

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hello Heikki, On Mon, Aug 29, 2016 at 05:07:39PM +0300, Heikki Krogerus wrote: > Hi Guenter, > > > > Overall this is quite vague and, especially for chargers, most of the time > > > misses the point. > > > > > > I would really prefer if we could stay closer to the specification in this > > >

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi Guenter, > > Overall this is quite vague and, especially for chargers, most of the time > > misses the point. > > > > I would really prefer if we could stay closer to the specification in this > > case, and not try to merge multiple orthogonal attributes into one. > > OK. So what would you

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi Guenter, > > Overall this is quite vague and, especially for chargers, most of the time > > misses the point. > > > > I would really prefer if we could stay closer to the specification in this > > case, and not try to merge multiple orthogonal attributes into one. > > OK. So what would you

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Mon, Aug 29, 2016 at 06:04:52AM -0700, Guenter Roeck wrote: > Heikki, > > On 08/26/2016 07:07 AM, Heikki Krogerus wrote: > > > > > > > > +What: /sys/class/typec/-partner/type > > > > > > +Date: June 2016 > > > > > > +Contact: Heikki Krogerus

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Mon, Aug 29, 2016 at 06:04:52AM -0700, Guenter Roeck wrote: > Heikki, > > On 08/26/2016 07:07 AM, Heikki Krogerus wrote: > > > > > > > > +What: /sys/class/typec/-partner/type > > > > > > +Date: June 2016 > > > > > > +Contact: Heikki Krogerus > > > > > > +Description:

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Mon, Aug 29, 2016 at 2:36 PM, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Mon, Aug 29, 2016 at 2:36 PM, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port supports

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Heikki, On 08/26/2016 07:07 AM, Heikki Krogerus wrote: +What: /sys/class/typec/-partner/type +Date: June 2016 +Contact: Heikki Krogerus +Description: + Shows the type of the partner. Can be one of the following: +

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Heikki, On 08/26/2016 07:07 AM, Heikki Krogerus wrote: +What: /sys/class/typec/-partner/type +Date: June 2016 +Contact: Heikki Krogerus +Description: + Shows the type of the partner. Can be one of the following: + - USB - When the partner

[PATCHv6 1/3] usb: USB Type-C connector class

The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and

[PATCHv6 1/3] usb: USB Type-C connector class

The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi Vincent, On Fri, Aug 26, 2016 at 03:16:16PM +0200, Vincent Palatin wrote: > >> > +What: /sys/class/typec//current_vconn_role > >> > +Date: June 2016 > >> > +Contact: Heikki Krogerus > >> > +Description: > >> > + Shows the

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi Vincent, On Fri, Aug 26, 2016 at 03:16:16PM +0200, Vincent Palatin wrote: > >> > +What: /sys/class/typec//current_vconn_role > >> > +Date: June 2016 > >> > +Contact: Heikki Krogerus > >> > +Description: > >> > + Shows the current VCONN role of the port.

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Thu, Aug 25, 2016 at 1:59 PM, Heikki Krogerus wrote: > Hi, > > On Wed, Aug 24, 2016 at 04:08:23PM +0200, Vincent Palatin wrote: >> Sorry if I'm making redundant comments with previous discussions, I >> might have missed a few threads. >> >> >> On Mon, Aug 22,

Re: [PATCHv6 1/3] usb: USB Type-C connector class

On Thu, Aug 25, 2016 at 1:59 PM, Heikki Krogerus wrote: > Hi, > > On Wed, Aug 24, 2016 at 04:08:23PM +0200, Vincent Palatin wrote: >> Sorry if I'm making redundant comments with previous discussions, I >> might have missed a few threads. >> >> >> On Mon, Aug 22, 2016 at 2:05 PM, Heikki Krogerus

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi, On Wed, Aug 24, 2016 at 04:08:23PM +0200, Vincent Palatin wrote: > Sorry if I'm making redundant comments with previous discussions, I > might have missed a few threads. > > > On Mon, Aug 22, 2016 at 2:05 PM, Heikki Krogerus > wrote: > > The purpose of USB

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Hi, On Wed, Aug 24, 2016 at 04:08:23PM +0200, Vincent Palatin wrote: > Sorry if I'm making redundant comments with previous discussions, I > might have missed a few threads. > > > On Mon, Aug 22, 2016 at 2:05 PM, Heikki Krogerus > wrote: > > The purpose of USB Type-C connector class is to

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Sorry if I'm making redundant comments with previous discussions, I might have missed a few threads. On Mon, Aug 22, 2016 at 2:05 PM, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get

Re: [PATCHv6 1/3] usb: USB Type-C connector class

Sorry if I'm making redundant comments with previous discussions, I might have missed a few threads. On Mon, Aug 22, 2016 at 2:05 PM, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information

[PATCHv6 1/3] usb: USB Type-C connector class

The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and

[PATCHv6 1/3] usb: USB Type-C connector class

The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and