Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-03 Thread Daniel Thompson
On Thu, Oct 03, 2019 at 11:52:36AM +0100, Suzuki K Poulose wrote: > On 10/03/2019 11:20 AM, Daniel Thompson wrote: > > On Wed, Oct 02, 2019 at 09:03:59AM -0600, Mathieu Poirier wrote: > > > On Tue, 1 Oct 2019 at 12:05, Sai Prakash Ranjan > > > wrote: > > > > > > > > On 2019-10-01 11:01, Jeffrey

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-03 Thread Suzuki K Poulose
On 10/03/2019 11:20 AM, Daniel Thompson wrote: On Wed, Oct 02, 2019 at 09:03:59AM -0600, Mathieu Poirier wrote: On Tue, 1 Oct 2019 at 12:05, Sai Prakash Ranjan wrote: On 2019-10-01 11:01, Jeffrey Hugo wrote: On Tue, Oct 1, 2019 at 11:52 AM Sai Prakash Ranjan wrote: Haan then likely it's

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-03 Thread Daniel Thompson
On Wed, Oct 02, 2019 at 09:03:59AM -0600, Mathieu Poirier wrote: > On Tue, 1 Oct 2019 at 12:05, Sai Prakash Ranjan > wrote: > > > > On 2019-10-01 11:01, Jeffrey Hugo wrote: > > > On Tue, Oct 1, 2019 at 11:52 AM Sai Prakash Ranjan > > > wrote: > > >> > > >> > > >> Haan then likely it's the

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-02 Thread Mathieu Poirier
On Tue, 1 Oct 2019 at 12:05, Sai Prakash Ranjan wrote: > > On 2019-10-01 11:01, Jeffrey Hugo wrote: > > On Tue, Oct 1, 2019 at 11:52 AM Sai Prakash Ranjan > > wrote: > >> > >> > >> Haan then likely it's the firmware issue. > >> We should probably disable coresight in soc dtsi and enable only for

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-01 Thread Sai Prakash Ranjan
On 2019-10-01 11:01, Jeffrey Hugo wrote: On Tue, Oct 1, 2019 at 11:52 AM Sai Prakash Ranjan wrote: Haan then likely it's the firmware issue. We should probably disable coresight in soc dtsi and enable only for MTP. For now you can add a status=disabled for all coresight nodes in msm8998.dtsi

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-01 Thread Jeffrey Hugo
On Tue, Oct 1, 2019 at 11:52 AM Sai Prakash Ranjan wrote: > > On 2019-10-01 10:14, Jeffrey Hugo wrote: > > On Tue, Oct 1, 2019 at 11:04 AM Sai Prakash Ranjan > > wrote: > >> > >> On 2019-10-01 09:13, Jeffrey Hugo wrote: > >> > Sai, > >> > > >> > This patch breaks boot on the 835 laptops.

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-01 Thread Sai Prakash Ranjan
On 2019-10-01 10:14, Jeffrey Hugo wrote: On Tue, Oct 1, 2019 at 11:04 AM Sai Prakash Ranjan wrote: On 2019-10-01 09:13, Jeffrey Hugo wrote: > Sai, > > This patch breaks boot on the 835 laptops. However, I haven't seen > the same issue on the MTP. I wonder, is coresight expected to work >

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-01 Thread Suzuki K Poulose
On 01/10/2019 18:14, Jeffrey Hugo wrote: On Tue, Oct 1, 2019 at 11:04 AM Sai Prakash Ranjan wrote: On 2019-10-01 09:13, Jeffrey Hugo wrote: Sai, This patch breaks boot on the 835 laptops. However, I haven't seen the same issue on the MTP. I wonder, is coresight expected to work with

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-01 Thread Jeffrey Hugo
On Tue, Oct 1, 2019 at 11:04 AM Sai Prakash Ranjan wrote: > > On 2019-10-01 09:13, Jeffrey Hugo wrote: > > Sai, > > > > This patch breaks boot on the 835 laptops. However, I haven't seen > > the same issue on the MTP. I wonder, is coresight expected to work > > with production fused devices? I

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-01 Thread Sai Prakash Ranjan
On 2019-10-01 09:13, Jeffrey Hugo wrote: Sai, This patch breaks boot on the 835 laptops. However, I haven't seen the same issue on the MTP. I wonder, is coresight expected to work with production fused devices? I wonder if thats the difference between the laptop and MTP that is causing the

Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-10-01 Thread Jeffrey Hugo
Sai, This patch breaks boot on the 835 laptops. However, I haven't seen the same issue on the MTP. I wonder, is coresight expected to work with production fused devices? I wonder if thats the difference between the laptop and MTP that is causing the issue. Let me know what I can do to help

[PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support

2019-07-30 Thread Sai Prakash Ranjan
Enable coresight support by adding device nodes for the available source, sinks and channel blocks on MSM8998. Signed-off-by: Sai Prakash Ranjan Reviewed-by: Mathieu Poirier Acked-by: Suzuki K Poulose --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 435 ++ 1 file changed,