Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-24 Thread Tejun Heo
Hello, Tang. On Mon, Jun 24, 2013 at 03:26:27PM +0800, Tang Chen wrote: > >My box is x86_64, and the memory layout is: > >[ 0.00] SRAT: Node 0 PXM 0 [mem 0x-0x7fff] > >[ 0.00] SRAT: Node 0 PXM 0 [mem 0x1-0x307ff] > >[ 0.00] SRAT: Node 1 PXM 2 [mem 0x30800-0x

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-24 Thread Gu Zheng
On 06/19/2013 01:10 AM, Vasilis Liaskovitis wrote: > Hi, > > On Thu, Jun 13, 2013 at 09:02:47PM +0800, Tang Chen wrote: >> From: Yinghai Lu >> >> No offence, just rebase and resend the patches from Yinghai to help >> to push this functionality faster. >> Also improve the comments in the patches'

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-24 Thread Tang Chen
On 06/24/2013 11:51 AM, Tang Chen wrote: On 06/22/2013 02:25 AM, Tejun Heo wrote: Hey, On Fri, Jun 21, 2013 at 05:19:48PM +0800, Tang Chen wrote: * As memblock allocator can relocate itself. There's no point in avoiding setting NUMA node while parsing and registering NUMA topology. Just parse

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-23 Thread Tang Chen
On 06/22/2013 02:25 AM, Tejun Heo wrote: Hey, On Fri, Jun 21, 2013 at 05:19:48PM +0800, Tang Chen wrote: * As memblock allocator can relocate itself. There's no point in avoiding setting NUMA node while parsing and registering NUMA topology. Just parse and register NUMA info and later t

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-21 Thread Yinghai Lu
On Thu, Jun 20, 2013 at 10:19 PM, H. Peter Anvin wrote: > On 06/13/2013 06:02 AM, Tang Chen wrote: >> From: Yinghai Lu >> >> No offence, just rebase and resend the patches from Yinghai to help >> to push this functionality faster. >> Also improve the comments in the patches' log. >> > > So we nee

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-21 Thread Tejun Heo
Hey, On Fri, Jun 21, 2013 at 05:19:48PM +0800, Tang Chen wrote: > >* As memblock allocator can relocate itself. There's no point in > > avoiding setting NUMA node while parsing and registering NUMA > > topology. Just parse and register NUMA info and later tell it to > > relocate itself out

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-21 Thread Tang Chen
Hi tj, On 06/20/2013 02:17 PM, Tejun Heo wrote: .. I was suggesting two separate things. * As memblock allocator can relocate itself. There's no point in avoiding setting NUMA node while parsing and registering NUMA topology. Just parse and register NUMA info and later tell it to

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-20 Thread Tejun Heo
Hello, guys. On Fri, Jun 21, 2013 at 02:20:28PM +0800, Tang Chen wrote: > >What about Tejun's feedback? > > tj's comments were after the latest version. So we need to > restructure the patch-set. Given that it's unlikely to reach actual functionality in this cycle, it's probably a better idea to

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-20 Thread Tang Chen
On 06/21/2013 02:10 PM, H. Peter Anvin wrote: On 06/20/2013 11:06 PM, Tang Chen wrote: Hi hpa, The build problem has been fixed by Yinghai. Where? I don't see anything that is obviously a fix in my inbox. Yinghai resent a new version to fix the problem. https://lkml.org/lkml/2013/6/14/5

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-20 Thread H. Peter Anvin
On 06/20/2013 11:06 PM, Tang Chen wrote: > > Hi hpa, > > The build problem has been fixed by Yinghai. > Where? I don't see anything that is obviously a fix in my inbox. What about Tejun's feedback? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-20 Thread Tang Chen
On 06/21/2013 01:19 PM, H. Peter Anvin wrote: On 06/13/2013 06:02 AM, Tang Chen wrote: From: Yinghai Lu No offence, just rebase and resend the patches from Yinghai to help to push this functionality faster. Also improve the comments in the patches' log. So we need a new version of this which

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-20 Thread H. Peter Anvin
On 06/13/2013 06:02 AM, Tang Chen wrote: > From: Yinghai Lu > > No offence, just rebase and resend the patches from Yinghai to help > to push this functionality faster. > Also improve the comments in the patches' log. > So we need a new version of this which addresses the build problems and the

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-20 Thread Yinghai Lu
On Wed, Jun 19, 2013 at 3:05 AM, Vasilis Liaskovitis wrote: > On Tue, Jun 18, 2013 at 01:19:12PM -0700, Yinghai Lu wrote: >> On Tue, Jun 18, 2013 at 10:10 AM, Vasilis Liaskovitis >> wrote: >> >> could be found at: >> >> >> >> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yi

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-19 Thread Tejun Heo
Hello, Tang. On Thu, Jun 20, 2013 at 01:52:50PM +0800, Tang Chen wrote: > 1. It is difficult to tell which memory allocation is temporary and >which one is permanent when memblock is allocating memory. So, we >can only wait till boot is complete, and see which remains. >But, we have th

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-19 Thread Tang Chen
Hi tj, Yinghai, On 06/19/2013 01:21 AM, Tejun Heo wrote: Hey, Tang. On Tue, Jun 18, 2013 at 01:47:16PM +0800, Tang Chen wrote: [approach] Parse SRAT earlier before memblock starts to work, because there is a bit in SRAT specifying which memory is hotpluggable. I'm not saying this is the best

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-19 Thread Vasilis Liaskovitis
On Tue, Jun 18, 2013 at 01:19:12PM -0700, Yinghai Lu wrote: > On Tue, Jun 18, 2013 at 10:10 AM, Vasilis Liaskovitis > wrote: > >> could be found at: > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git > >> for-x86-mm > >> > >> and it is based on today's Linu

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-18 Thread Yinghai Lu
On Tue, Jun 18, 2013 at 10:10 AM, Vasilis Liaskovitis wrote: >> could be found at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git >> for-x86-mm >> >> and it is based on today's Linus tree. >> > > Has this patchset been tested on various numa configs? > I am

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-18 Thread Tejun Heo
Hey, Tang. On Tue, Jun 18, 2013 at 01:47:16PM +0800, Tang Chen wrote: > [approach] > Parse SRAT earlier before memblock starts to work, because there is a > bit in SRAT specifying which memory is hotpluggable. > > I'm not saying this is the best approach. I can also see that this > patch-set touc

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-18 Thread Vasilis Liaskovitis
Hi, On Thu, Jun 13, 2013 at 09:02:47PM +0800, Tang Chen wrote: > From: Yinghai Lu > > No offence, just rebase and resend the patches from Yinghai to help > to push this functionality faster. > Also improve the comments in the patches' log. > > > One commit that tried to parse SRAT early get re

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-17 Thread Tang Chen
Hi tj, On 06/18/2013 10:03 AM, Tejun Heo wrote: .. So, can you please explain why you're doing the above? What are you trying to achieve in the end and why is this the best approach? This is all for memory hotplug, right? Yes, this is all for memory hotplug. [why] At early boot time (b

Re: [Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-17 Thread Tejun Heo
Hello, On Thu, Jun 13, 2013 at 09:02:47PM +0800, Tang Chen wrote: > One commit that tried to parse SRAT early get reverted before v3.9-rc1. > > | commit e8d1955258091e4c92d5a975ebd7fd8a98f5d30f > | Author: Tang Chen > | Date: Fri Feb 22 16:33:44 2013 -0800 > | > |acpi, memory-hotplug: pars

[Part1 PATCH v5 00/22] x86, ACPI, numa: Parse numa info earlier

2013-06-13 Thread Tang Chen
From: Yinghai Lu No offence, just rebase and resend the patches from Yinghai to help to push this functionality faster. Also improve the comments in the patches' log. One commit that tried to parse SRAT early get reverted before v3.9-rc1. | commit e8d1955258091e4c92d5a975ebd7fd8a98f5d30f | Aut