Re: [Patch] Elf loader crash while zero-filling .bss

2008-02-11 Thread Andreas Schwab
Jiri Kosina <[EMAIL PROTECTED]> writes: > On Mon, 11 Feb 2008, H. Peter Anvin wrote: > > >> > Now, the question is whether it is valid for ELF binary to not have the end >> > of .bss section (if present at all) not page-aligned. >> Why wouldn't it be? It would, however, be valid to the kernel to

Re: [Patch] Elf loader crash while zero-filling .bss

2008-02-11 Thread Jiri Kosina
On Mon, 11 Feb 2008, H. Peter Anvin wrote: > > Now, the question is whether it is valid for ELF binary to not have the end > > of .bss section (if present at all) not page-aligned. > Why wouldn't it be? It would, however, be valid to the kernel to round it up > to the next boundary. I wasn't im

Re: [Patch] Elf loader crash while zero-filling .bss

2008-02-11 Thread H. Peter Anvin
Jiri Kosina wrote: On Mon, 11 Feb 2008, Abel Bernabeu wrote: In such a way that set_brk(0x0, 0x100) does not alloc any space at all. There are just more ways to get no memory allocation than set_brk(elf_bss, elf_bss) (the equalness condition i've changed). Sorry, the correct description for t

Re: [Patch] Elf loader crash while zero-filling .bss

2008-02-11 Thread Jiri Kosina
On Mon, 11 Feb 2008, Abel Bernabeu wrote: > In such a way that set_brk(0x0, 0x100) does not alloc any space at all. > There are just more ways to get no memory allocation than > set_brk(elf_bss, elf_bss) (the equalness condition i've changed). > Sorry, the correct description for the patch may b

Re: [Patch] Elf loader crash while zero-filling .bss

2008-02-11 Thread Sam Ravnborg
On Mon, Feb 11, 2008 at 07:27:35PM +0100, Abel Bernabeu wrote: > I've finally found a solution for the crash in load_binary_elf I > reported last week: > > http://lkml.org/lkml/2008/1/30/171 > > The attached patch solves my problem, but please test it yourself... > > set_brk(start, end) allocs j

Re: [Patch] Elf loader crash while zero-filling .bss

2008-02-11 Thread Jiri Kosina
On Mon, 11 Feb 2008, Abel Bernabeu wrote: > > set_brk(start, end) allocs just page aligned regions (by "colapsing" > > both extremes to the start of the page in which they lay)... That > > means than even if both pointers are not equal there are still some > > chances that set_brk has allocated no

Re: [Patch] Elf loader crash while zero-filling .bss

2008-02-11 Thread Abel Bernabeu
2008/2/11, Abel Bernabeu <[EMAIL PROTECTED]>: > I've finally found a solution for the crash in load_binary_elf I > reported last week: > > http://lkml.org/lkml/2008/1/30/171 > > The attached patch solves my problem, but please test it yourself... > > set_brk(start, end) allocs just page aligned reg

[Patch] Elf loader crash while zero-filling .bss

2008-02-11 Thread Abel Bernabeu
I've finally found a solution for the crash in load_binary_elf I reported last week: http://lkml.org/lkml/2008/1/30/171 The attached patch solves my problem, but please test it yourself... set_brk(start, end) allocs just page aligned regions (by "colapsing" both extremes to the start of the page