Re: [Patch] perf stat: always separate stalled cycles per insn

2019-07-17 Thread Andi Kleen
On Tue, Jul 16, 2019 at 05:43:24PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 16, 2019 at 12:24:41PM -0700, Cong Wang escreveu: > > Hi, Arnaldo > > > > On Tue, May 28, 2019 at 12:11 PM Arnaldo Carvalho de Melo > > wrote: > > > > > > Em Tue, May 28, 2019 at 11:21:38AM -0700, Cong Wang es

Re: [Patch] perf stat: always separate stalled cycles per insn

2019-07-16 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 16, 2019 at 12:24:41PM -0700, Cong Wang escreveu: > Hi, Arnaldo > > On Tue, May 28, 2019 at 12:11 PM Arnaldo Carvalho de Melo > wrote: > > > > Em Tue, May 28, 2019 at 11:21:38AM -0700, Cong Wang escreveu: > > > Thanks for reviewing it. Is there anyone takes this patch? > > > > Enough

Re: [Patch] perf stat: always separate stalled cycles per insn

2019-07-16 Thread Cong Wang
Hi, Arnaldo On Tue, May 28, 2019 at 12:11 PM Arnaldo Carvalho de Melo wrote: > > Em Tue, May 28, 2019 at 11:21:38AM -0700, Cong Wang escreveu: > > Thanks for reviewing it. Is there anyone takes this patch? > > Enough time, acked already, picking it. Where is this patch landed? I don't see it in

Re: [Patch] perf stat: always separate stalled cycles per insn

2019-05-28 Thread Arnaldo Carvalho de Melo
Em Tue, May 28, 2019 at 11:21:38AM -0700, Cong Wang escreveu: > On Sun, May 19, 2019 at 11:59 PM Jiri Olsa wrote: > > > > On Fri, May 17, 2019 at 03:10:39PM -0700, Cong Wang wrote: > > > The "stalled cycles per insn" is appended to "instructions" when > > > the CPU has this hardware counter direct

Re: [Patch] perf stat: always separate stalled cycles per insn

2019-05-28 Thread Cong Wang
On Sun, May 19, 2019 at 11:59 PM Jiri Olsa wrote: > > On Fri, May 17, 2019 at 03:10:39PM -0700, Cong Wang wrote: > > The "stalled cycles per insn" is appended to "instructions" when > > the CPU has this hardware counter directly. We should always make it > > a separate line, which also aligns to t

Re: [Patch] perf stat: always separate stalled cycles per insn

2019-05-19 Thread Jiri Olsa
On Fri, May 17, 2019 at 03:10:39PM -0700, Cong Wang wrote: > The "stalled cycles per insn" is appended to "instructions" when > the CPU has this hardware counter directly. We should always make it > a separate line, which also aligns to the output when we hit the > "if (total && avg)" branch. > >

[Patch] perf stat: always separate stalled cycles per insn

2019-05-17 Thread Cong Wang
The "stalled cycles per insn" is appended to "instructions" when the CPU has this hardware counter directly. We should always make it a separate line, which also aligns to the output when we hit the "if (total && avg)" branch. Before: $ sudo perf stat --all-cpus --field-separator , --log-fd 1 -ei