Re: [Patch -v3 3/4] checkpatch.pl the new kernel/reboot.c file.

2013-04-16 Thread Joe Perches
(trimmed cc's) On Tue, 2013-04-16 at 04:41 -0500, Robin Holt wrote: > On Mon, Apr 15, 2013 at 10:45:38AM -0700, Joe Perches wrote: > > trivia: > > I'd make these changes on top of your patch: > > o Additional OOM messages aren't necessary as a dump_stack is done > I am not sure what I should be do

Re: [Patch -v3 3/4] checkpatch.pl the new kernel/reboot.c file.

2013-04-16 Thread Robin Holt
On Mon, Apr 15, 2013 at 10:45:38AM -0700, Joe Perches wrote: > On Mon, 2013-04-15 at 12:16 -0500, Robin Holt wrote: > > I did allow the remaining 81 character line behind. It did not seem > > like it was worth changing. Otherwise, it now passes checkpatch.pl. > > trivia: > > I'd make these chan

Re: [Patch -v3 3/4] checkpatch.pl the new kernel/reboot.c file.

2013-04-15 Thread Robin Holt
On Mon, Apr 15, 2013 at 10:45:38AM -0700, Joe Perches wrote: > On Mon, 2013-04-15 at 12:16 -0500, Robin Holt wrote: > > I did allow the remaining 81 character line behind. It did not seem > > like it was worth changing. Otherwise, it now passes checkpatch.pl. > > trivia: > > I'd make these chan

Re: [Patch -v3 3/4] checkpatch.pl the new kernel/reboot.c file.

2013-04-15 Thread Joe Perches
On Mon, 2013-04-15 at 12:16 -0500, Robin Holt wrote: > I did allow the remaining 81 character line behind. It did not seem > like it was worth changing. Otherwise, it now passes checkpatch.pl. trivia: I'd make these changes on top of your patch: o Additional OOM messages aren't necessary as a

[Patch -v3 3/4] checkpatch.pl the new kernel/reboot.c file.

2013-04-15 Thread Robin Holt
I did allow the remaining 81 character line behind. It did not seem like it was worth changing. Otherwise, it now passes checkpatch.pl. Signed-off-by: Robin Holt To: Ingo Molnar To: Russ Anderson Cc: Shawn Guo Cc: Oleg Nesterov Cc: Andrew Morton Cc: "H. Peter Anvin" Cc: Lai Jiangshan Cc