Re: [Patch 10/18] fs/logfs/inode.c

2007-06-11 Thread Jörn Engel
On Tue, 12 June 2007 01:51:34 +0200, Arnd Bergmann wrote: > On Tuesday 12 June 2007, Jörn Engel wrote: > > The initial storm of review comments has calmed down.  I get the > > impression that people either lose interest or run out of simple things > > to point out.  Maybe I should wait a bit

Re: [Patch 10/18] fs/logfs/inode.c

2007-06-11 Thread Arnd Bergmann
On Tuesday 12 June 2007, Jörn Engel wrote: > The initial storm of review comments has calmed down.  I get the > impression that people either lose interest or run out of simple things > to point out.  Maybe I should wait a bit before resending? Your last series had a todo list of 11 items, plus

Re: [Patch 10/18] fs/logfs/inode.c

2007-06-11 Thread Jörn Engel
On Sun, 10 June 2007 19:24:28 +0200, Arnd Bergmann wrote: > > I think this is missing code that sets the initial i_uid/i_gid, > but there may be more missing. Changing the uid value works, > but creating files as non-root user doesn't. Fixed in patch 557, see http://logfs.org/logfs/patches The

Re: [Patch 10/18] fs/logfs/inode.c

2007-06-11 Thread Jörn Engel
On Sun, 10 June 2007 19:24:28 +0200, Arnd Bergmann wrote: I think this is missing code that sets the initial i_uid/i_gid, but there may be more missing. Changing the uid value works, but creating files as non-root user doesn't. Fixed in patch 557, see http://logfs.org/logfs/patches The

Re: [Patch 10/18] fs/logfs/inode.c

2007-06-11 Thread Arnd Bergmann
On Tuesday 12 June 2007, Jörn Engel wrote: The initial storm of review comments has calmed down.  I get the impression that people either lose interest or run out of simple things to point out.  Maybe I should wait a bit before resending? Your last series had a todo list of 11 items, plus more

Re: [Patch 10/18] fs/logfs/inode.c

2007-06-11 Thread Jörn Engel
On Tue, 12 June 2007 01:51:34 +0200, Arnd Bergmann wrote: On Tuesday 12 June 2007, Jörn Engel wrote: The initial storm of review comments has calmed down.  I get the impression that people either lose interest or run out of simple things to point out.  Maybe I should wait a bit before

Re: [Patch 10/18] fs/logfs/inode.c

2007-06-10 Thread Jörn Engel
On Sun, 10 June 2007 19:24:28 +0200, Arnd Bergmann wrote: > On Sunday 03 June 2007, Jörn Engel wrote: > > +struct inode *logfs_new_inode(struct inode *dir, int mode) > > +{ > > +   struct super_block *sb = dir->i_sb; > > +   struct inode *inode; > > + > > +   inode = new_inode(sb); > >

Re: [Patch 10/18] fs/logfs/inode.c

2007-06-10 Thread Jörn Engel
On Sun, 10 June 2007 19:24:28 +0200, Arnd Bergmann wrote: On Sunday 03 June 2007, Jörn Engel wrote: +struct inode *logfs_new_inode(struct inode *dir, int mode) +{ +   struct super_block *sb = dir-i_sb; +   struct inode *inode; + +   inode = new_inode(sb); +   if

[Patch 10/18] fs/logfs/inode.c

2007-06-03 Thread Jörn Engel
--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/inode.c 2007-06-03 20:06:15.0 +0200 @@ -0,0 +1,512 @@ +/* + * fs/logfs/inode.c- inode handling code + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c) 2005-2007

[Patch 10/18] fs/logfs/inode.c

2007-06-03 Thread Jörn Engel
--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/inode.c 2007-06-03 20:06:15.0 +0200 @@ -0,0 +1,512 @@ +/* + * fs/logfs/inode.c- inode handling code + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c) 2005-2007