Re: [Patch 15/18] fs/logfs/super.c

2007-06-10 Thread Willy Tarreau
On Sun, Jun 10, 2007 at 09:10:15PM +0200, Jörn Engel wrote: > I don't think logfs on block devices makes too much sense yet, so my > personal priority for this is low. Still, an obvious improvement. I see it as a good candidate to replace JFFS2 on CompactFlash. That one is becoming painfully sl

Re: [Patch 15/18] fs/logfs/super.c

2007-06-10 Thread Jörn Engel
On Sun, 10 June 2007 20:33:05 +0200, Arnd Bergmann wrote: > > Then maybe the submit_bio logic should only be done for the ->write > path, not for ->read. The data that gets written out should already > be present in the page cache for the files, so there is not much point > having again, while you

Re: [Patch 15/18] fs/logfs/super.c

2007-06-10 Thread Arnd Bergmann
On Sunday 10 June 2007, Jörn Engel wrote: > On Sun, 10 June 2007 18:27:49 +0200, Arnd Bergmann wrote: > > On Sunday 03 June 2007, Jörn Engel wrote: > > How about using submit_bio here instead of going to the page cache? > > That would avoid doubling all the memory consumption here. > > That may m

Re: [Patch 15/18] fs/logfs/super.c

2007-06-10 Thread Jörn Engel
On Sun, 10 June 2007 18:27:49 +0200, Arnd Bergmann wrote: > On Sunday 03 June 2007, Jörn Engel wrote: > > +static int mtdwrite(struct super_block *sb, loff_t ofs, size_t len, void > > *buf) > > +{ > > + struct logfs_super *super = logfs_super(sb); > > + struct mtd_info *mtd = super->s_mtd; > >

Re: [Patch 15/18] fs/logfs/super.c

2007-06-10 Thread Arnd Bergmann
On Sunday 03 June 2007, Jörn Engel wrote: > +static int mtdread(struct super_block *sb, loff_t ofs, size_t len, void *buf) > +{ > + struct mtd_info *mtd = logfs_super(sb)->s_mtd; > + size_t retlen; > + int ret; > + > + ret = mtd->read(mtd, ofs, len, &retlen, buf); > + BUG_ON(ret

[Patch 15/18] fs/logfs/super.c

2007-06-03 Thread Jörn Engel
--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/super.c 2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,521 @@ +/* + * fs/logfs/super.c + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c) 2005-2007 Joern Engel + * + * General