Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Greg KH
On Thu, Feb 22, 2007 at 03:56:11PM -0600, Mike Miller (OS Dev) wrote: > On Thu, Feb 22, 2007 at 09:45:02PM +, Christoph Hellwig wrote: > > On Thu, Feb 22, 2007 at 03:38:45PM -0600, Mike Miller (OS Dev) wrote: > > > Patch 2/2 > > > > > > This adds support for struct pci_driver shutdown and nega

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 09:55:01PM +, Christoph Hellwig wrote: > On Thu, Feb 22, 2007 at 03:49:38PM -0600, James Bottomley wrote: > > On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote: > > > .remove = __devexit_p(cciss_remove_one), > > > .id_table = cciss_pci_device_

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread scott . ashcroft
Mike Miller (OS Dev) wrote: + if (return_code = IO_OK) { Shouldn't that be == + printk(KERN_WARNING "Completed cache flush on controller %d\n", i); + } else { + printk(KERN_WARNING "Error Flushing cache on controller %d\n", i); } free_

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 09:45:02PM +, Christoph Hellwig wrote: > On Thu, Feb 22, 2007 at 03:38:45PM -0600, Mike Miller (OS Dev) wrote: > > Patch 2/2 > > > > This adds support for struct pci_driver shutdown and negates the previous > > NAK'ed > > reboot_notifier patch. It's much easier, wish I

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Christoph Hellwig
On Thu, Feb 22, 2007 at 03:49:38PM -0600, James Bottomley wrote: > On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote: > > .remove = __devexit_p(cciss_remove_one), > > .id_table = cciss_pci_device_id,/* id_table */ > > + .shutdown = cciss_remove_one, > > Yo

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread James Bottomley
On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote: > .remove = __devexit_p(cciss_remove_one), > .id_table = cciss_pci_device_id,/* id_table */ > + .shutdown = cciss_remove_one, You need a __devexit_p() wrapper for this one too. James - To unsubscribe fr

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Christoph Hellwig
On Thu, Feb 22, 2007 at 03:38:45PM -0600, Mike Miller (OS Dev) wrote: > Patch 2/2 > > This adds support for struct pci_driver shutdown and negates the previous > NAK'ed > reboot_notifier patch. It's much easier, wish I had know about this before. > Thanks to > Christoph for pointing this out. J

[Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Mike Miller (OS Dev)
Patch 2/2 This adds support for struct pci_driver shutdown and negates the previous NAK'ed reboot_notifier patch. It's much easier, wish I had know about this before. Thanks to Christoph for pointing this out. Signed-off-by: Mike Miller <[EMAIL PROTECTED]> ---