Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Mon, Apr 10, 2017 at 02:43:20PM +0200, Borislav Petkov wrote: >On Sun, Apr 09, 2017 at 11:12:14AM +0800, Wei Yang wrote: >> Oops, sorry to bring in the regression with my cleanup. >> I haven't noticed there is a kernel command line "numa=fake", which >> is the cause of the crash I think. > >Of

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Mon, Apr 10, 2017 at 02:43:20PM +0200, Borislav Petkov wrote: >On Sun, Apr 09, 2017 at 11:12:14AM +0800, Wei Yang wrote: >> Oops, sorry to bring in the regression with my cleanup. >> I haven't noticed there is a kernel command line "numa=fake", which >> is the cause of the crash I think. > >Of

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Sun, Apr 09, 2017 at 11:12:14AM +0800, Wei Yang wrote: > Oops, sorry to bring in the regression with my cleanup. > I haven't noticed there is a kernel command line "numa=fake", which > is the cause of the crash I think. Of course it is, didn't you see my debugging upthread? > So from my

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Sun, Apr 09, 2017 at 11:12:14AM +0800, Wei Yang wrote: > Oops, sorry to bring in the regression with my cleanup. > I haven't noticed there is a kernel command line "numa=fake", which > is the cause of the crash I think. Of course it is, didn't you see my debugging upthread? > So from my

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Fri, Apr 7, 2017 at 2:48 AM, Borislav Petkov wrote: > On Thu, Apr 06, 2017 at 09:21:47PM +0300, Kirill A. Shutemov wrote: >> > Long story short, something as trivial as this helps here: >> >> Yep. Works for me. >> >> Reported-and-tested-by: Kirill A. Shutemov

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Fri, Apr 7, 2017 at 2:48 AM, Borislav Petkov wrote: > On Thu, Apr 06, 2017 at 09:21:47PM +0300, Kirill A. Shutemov wrote: >> > Long story short, something as trivial as this helps here: >> >> Yep. Works for me. >> >> Reported-and-tested-by: Kirill A. Shutemov > > Thanks. > > Now, I'd really

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 09:21:47PM +0300, Kirill A. Shutemov wrote: > > Long story short, something as trivial as this helps here: > > Yep. Works for me. > > Reported-and-tested-by: Kirill A. Shutemov Thanks. Now, I'd really like to have more test coverage and

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 09:21:47PM +0300, Kirill A. Shutemov wrote: > > Long story short, something as trivial as this helps here: > > Yep. Works for me. > > Reported-and-tested-by: Kirill A. Shutemov Thanks. Now, I'd really like to have more test coverage and be sure this "cleanup" doesn't

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 08:01:13PM +0200, Borislav Petkov wrote: > On Thu, Apr 06, 2017 at 06:42:16PM +0300, Kirill A. Shutemov wrote: > > Config is attached. > > Thanks! > > > Looks like fake numa is the key. > > ... > > > NUMA: Warning: node ids are out of bound, from=0 to=1 distance=20

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 08:01:13PM +0200, Borislav Petkov wrote: > On Thu, Apr 06, 2017 at 06:42:16PM +0300, Kirill A. Shutemov wrote: > > Config is attached. > > Thanks! > > > Looks like fake numa is the key. > > ... > > > NUMA: Warning: node ids are out of bound, from=0 to=1 distance=20

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 06:42:16PM +0300, Kirill A. Shutemov wrote: > Config is attached. Thanks! > Looks like fake numa is the key. ... > NUMA: Warning: node ids are out of bound, from=0 to=1 distance=20 >

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 06:42:16PM +0300, Kirill A. Shutemov wrote: > Config is attached. Thanks! > Looks like fake numa is the key. ... > NUMA: Warning: node ids are out of bound, from=0 to=1 distance=20 >

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 04:59:37PM +0200, Borislav Petkov wrote: > On Thu, Apr 06, 2017 at 03:44:59PM +0300, Kirill A. Shutemov wrote: > > I've got the crash below on master/tip. Reveting the patch helps. > > > > > >

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 04:59:37PM +0200, Borislav Petkov wrote: > On Thu, Apr 06, 2017 at 03:44:59PM +0300, Kirill A. Shutemov wrote: > > I've got the crash below on master/tip. Reveting the patch helps. > > > > > >

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 03:44:59PM +0300, Kirill A. Shutemov wrote: > I've got the crash below on master/tip. Reveting the patch helps. > > > UBSAN: Undefined behaviour in /home/kas/linux/la57/mm/sparse.c:336:9 >

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Thu, Apr 06, 2017 at 03:44:59PM +0300, Kirill A. Shutemov wrote: > I've got the crash below on master/tip. Reveting the patch helps. > > > UBSAN: Undefined behaviour in /home/kas/linux/la57/mm/sparse.c:336:9 >

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Tue, Mar 14, 2017 at 11:08:01AM +0800, Wei Yang wrote: > numa_nodemask_from_meminfo() is called to set bit according to > numa_meminfo. While the only two places for this call is used to set proper > bit to a copy of numa_nodes_parsed from numa_meminfo. With current code > path, those numa node

Re: [Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

On Tue, Mar 14, 2017 at 11:08:01AM +0800, Wei Yang wrote: > numa_nodemask_from_meminfo() is called to set bit according to > numa_meminfo. While the only two places for this call is used to set proper > bit to a copy of numa_nodes_parsed from numa_meminfo. With current code > path, those numa node

[Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

numa_nodemask_from_meminfo() is called to set bit according to numa_meminfo. While the only two places for this call is used to set proper bit to a copy of numa_nodes_parsed from numa_meminfo. With current code path, those numa node information in numa_meminfo is a subset of numa_nodes_parsed. So

[Patch V2 2/2] x86/mm/numa: remove the numa_nodemask_from_meminfo()

numa_nodemask_from_meminfo() is called to set bit according to numa_meminfo. While the only two places for this call is used to set proper bit to a copy of numa_nodes_parsed from numa_meminfo. With current code path, those numa node information in numa_meminfo is a subset of numa_nodes_parsed. So