Re: [Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

2016-11-15 Thread Michal Simek
On 9.11.2016 16:53, Marc Zyngier wrote: > On 01/11/16 11:05, Zubair Lutfullah Kakakhel wrote: >> Hi, >> >> Thanks for the review. >> >> On 10/31/2016 07:51 PM, Thomas Gleixner wrote: >>> On Mon, 31 Oct 2016, Zubair Lutfullah Kakakhel wrote: The drivers read/write function handling is a bit qui

Re: [Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

2016-11-09 Thread Marc Zyngier
On 01/11/16 11:05, Zubair Lutfullah Kakakhel wrote: > Hi, > > Thanks for the review. > > On 10/31/2016 07:51 PM, Thomas Gleixner wrote: >> On Mon, 31 Oct 2016, Zubair Lutfullah Kakakhel wrote: >>> The drivers read/write function handling is a bit quirky. >> >> Can you please explain in more detai

Re: [Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

2016-11-07 Thread Zubair Lutfullah Kakakhel
Hi, On 11/01/2016 11:05 AM, Zubair Lutfullah Kakakhel wrote: Hi, Thanks for the review. On 10/31/2016 07:51 PM, Thomas Gleixner wrote: On Mon, 31 Oct 2016, Zubair Lutfullah Kakakhel wrote: The drivers read/write function handling is a bit quirky. Can you please explain in more detail what'

Re: [Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

2016-11-01 Thread Zubair Lutfullah Kakakhel
Hi, Thanks for the review. On 10/31/2016 07:51 PM, Thomas Gleixner wrote: On Mon, 31 Oct 2016, Zubair Lutfullah Kakakhel wrote: The drivers read/write function handling is a bit quirky. Can you please explain in more detail what's quirky and why it should be done differently, And the irqma

Re: [Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

2016-10-31 Thread Thomas Gleixner
On Mon, 31 Oct 2016, Zubair Lutfullah Kakakhel wrote: > The drivers read/write function handling is a bit quirky. Can you please explain in more detail what's quirky and why it should be done differently, > And the irqmask is passed directly to the handler. I can't make any sense out of that se

[Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

2016-10-31 Thread Zubair Lutfullah Kakakhel
The drivers read/write function handling is a bit quirky. And the irqmask is passed directly to the handler. Add a new irqchip struct to pass to the handler and cleanup read/write handling. Signed-off-by: Zubair Lutfullah Kakakhel --- V5 -> V6 Removed __func__ from printk Rebase to v4.9-rc3 V4