Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Josh Coombs
With the _malloc() adjusted as suggested, I'm still not seeing scheduler bugs tracing back to the rtl8172 driver. I am however seeing allocation errors occasionally now in cryptodev on my test system, so all is still not right. This behavior was not present in 3.6.4, I haven't seen it in the 3.7

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Larry Finger
On 11/18/2012 02:55 PM, Andrew Lunn wrote: This is not sufficient. In fact it makes no difference at all. The problem is not with the structure, but with the allocation of memory used to contain the structure. pstapriv->pallocated_stainfo_buf = _malloc(sizeof(struct sta_info) *

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Andrew Lunn
On Sun, Nov 18, 2012 at 02:18:37PM -0600, Larry Finger wrote: > On 11/18/2012 12:11 PM, Andrew Lunn wrote: > > > >Just to clarify the issue here: > > > >union pn48 { > > u64 val; > >#if defined(__BIG_ENDIAN) > > struct { > > u8 TSC7; > > u8 TSC6; > >

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Larry Finger
On 11/18/2012 12:11 PM, Andrew Lunn wrote: Just to clarify the issue here: union pn48 { u64 val; #if defined(__BIG_ENDIAN) struct { u8 TSC7; u8 TSC6; Any instance of pn48 needs to be 64 bit aligned when the val member of the union is used. Th

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Josh Coombs
Testing now, will re-submit in the correct format once I confirm it works as intended. On Sun, Nov 18, 2012 at 1:20 PM, Andrew Lunn wrote: >> >> diff -ruN a/drivers/staging/rtl8712/rtl871x_sta_mgt.c >> >> b/drivers/staging/rtl8712/rtl871x_sta_mgt.c >> >> --- a/drivers/staging/rtl8712/rtl871x_sta_

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Andrew Lunn
> >> diff -ruN a/drivers/staging/rtl8712/rtl871x_sta_mgt.c > >> b/drivers/staging/rtl8712/rtl871x_sta_mgt.c > >> --- a/drivers/staging/rtl8712/rtl871x_sta_mgt.c 2012-11-05 > >> 03:57:06.0 -0500 > >> +++ b/drivers/staging/rtl8712/rtl871x_sta_mgt.c 2012-11-13 > >> 12:54:28.0 -0500 > >

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Andrew Lunn
On Sun, Nov 18, 2012 at 12:06:40PM -0500, Josh Coombs wrote: > Starting with 3.6.5 on a Marvell Kirkwood based GoFlex Net I began > observing scheduler bugs when using a USB based RTL8712 WiFi NIC. > These would eventually overwhelm systemd's logger under moderate > network activity and crash the b

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Josh Coombs
On Sun, Nov 18, 2012 at 12:47 PM, Russell King - ARM Linux wrote: > On Sun, Nov 18, 2012 at 12:06:40PM -0500, Josh Coombs wrote: >> Starting with 3.6.5 on a Marvell Kirkwood based GoFlex Net I began >> observing scheduler bugs when using a USB based RTL8712 WiFi NIC. >> These would eventually over

Re: [Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Russell King - ARM Linux
On Sun, Nov 18, 2012 at 12:06:40PM -0500, Josh Coombs wrote: > Starting with 3.6.5 on a Marvell Kirkwood based GoFlex Net I began > observing scheduler bugs when using a USB based RTL8712 WiFi NIC. > These would eventually overwhelm systemd's logger under moderate > network activity and crash the b

[Patch v1 1/1] RTL8712 alignment bug in 3.6.5 on ARM

2012-11-18 Thread Josh Coombs
Starting with 3.6.5 on a Marvell Kirkwood based GoFlex Net I began observing scheduler bugs when using a USB based RTL8712 WiFi NIC. These would eventually overwhelm systemd's logger under moderate network activity and crash the box. [ 64.312377] BUG: scheduling while atomic: crond/151/0x430