Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver

2020-07-27 Thread Vinod Koul
On 20-07-20, 12:04, Rajesh Gumasta wrote: > v4 changes: Removed pending dma desc list and other unused > data structures > > v3 changes: Removed free list for dma_desc and sg This is v1 patch and we have v3/v4 stuff! Anyway this can go after the marker succeeding sob line or cover! > > Adding G

Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver

2020-07-20 Thread Randy Dunlap
On 7/19/20 11:34 PM, Rajesh Gumasta wrote: > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index e9ed916..be4c395 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -639,6 +639,18 @@ config TEGRA210_ADMA > peripheral and vice versa. It does not support memory to

Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver

2020-07-20 Thread Dmitry Osipenko
Hello, Rajesh! 20.07.2020 09:34, Rajesh Gumasta пишет: > v4 changes: Removed pending dma desc list and other unused > data structures > > v3 changes: Removed free list for dma_desc and sg What is this? Isn't it a v1 patch? You shouldn't include any changelogs into commit message. In general yo

Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver

2020-07-20 Thread kernel test robot
Hi Rajesh, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on arm64/for-next/core tegra/for-next linus/master v5.8-rc6 next-20200717] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submit

Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver

2020-07-20 Thread Philipp Zabel
Hi Rajesh, On Mon, 2020-07-20 at 12:04 +0530, Rajesh Gumasta wrote: > + > + tdma->rst = devm_reset_control_get(&pdev->dev, "gpcdma"); Please use devm_reset_control_get_exclusive() directly. > + if (IS_ERR(tdma->rst)) { > + dev_err(&pdev->dev, "Missing controller reset\n

[Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver

2020-07-19 Thread Rajesh Gumasta
v4 changes: Removed pending dma desc list and other unused data structures v3 changes: Removed free list for dma_desc and sg Adding GPC DMA controller driver for Tegra186 and Tegra194. The driver supports dma transfers between memory to memory, IO to memory and memory to IO. Signed-off-by: Pavan