Re: [Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-24 Thread Pekka Enberg
On Tue, Apr 23, 2013 at 5:31 PM, Aaron Tomlin wrote: > This patch is in response to BZ#42967 [1]. > Using VM_BUG_ON so it's used only when CONFIG_DEBUG_VM is set, > given that cache_alloc_node() is a hot code path. The patch is pretty badly mangled and does not apply with 'git am'. Please

Re: [Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-24 Thread Pekka Enberg
On Tue, Apr 23, 2013 at 5:31 PM, Aaron Tomlin atom...@redhat.com wrote: This patch is in response to BZ#42967 [1]. Using VM_BUG_ON so it's used only when CONFIG_DEBUG_VM is set, given that cache_alloc_node() is a hot code path. The patch is pretty badly mangled and does not apply with 'git

Re: [Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-23 Thread David Rientjes
On Tue, 23 Apr 2013, Aaron Tomlin wrote: > mm: slab: Verify the nodeid passed to cache_alloc_node > > If the nodeid is > num_online_nodes() this can cause an > Oops and a panic(). The purpose of this patch is to assert > if this condition is true to aid debugging efforts rather > than

Re: [Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-23 Thread Rafael Aquini
On Tue, Apr 23, 2013 at 10:31:36AM -0400, Aaron Tomlin wrote: > Hi, > > This patch is in response to BZ#42967 [1]. > Using VM_BUG_ON so it's used only when CONFIG_DEBUG_VM is set, > given that cache_alloc_node() is a hot code path. > This seems to be a valid condition to BUG_ON, though. >

Re: [Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-23 Thread Christoph Lameter
On Tue, 23 Apr 2013, Aaron Tomlin wrote: > This patch is in response to BZ#42967 [1]. > Using VM_BUG_ON so it's used only when CONFIG_DEBUG_VM is set, > given that cache_alloc_node() is a hot code path. Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe

[Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-23 Thread Aaron Tomlin
Hi, This patch is in response to BZ#42967 [1]. Using VM_BUG_ON so it's used only when CONFIG_DEBUG_VM is set, given that cache_alloc_node() is a hot code path. Cheers, Aaron [1]: https://bugzilla.kernel.org/show_bug.cgi?id=42967 ---8<--- mm: slab: Verify the nodeid passed to

[Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-23 Thread Aaron Tomlin
Hi, This patch is in response to BZ#42967 [1]. Using VM_BUG_ON so it's used only when CONFIG_DEBUG_VM is set, given that cache_alloc_node() is a hot code path. Cheers, Aaron [1]: https://bugzilla.kernel.org/show_bug.cgi?id=42967 ---8--- mm: slab: Verify the nodeid passed to

Re: [Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-23 Thread Christoph Lameter
On Tue, 23 Apr 2013, Aaron Tomlin wrote: This patch is in response to BZ#42967 [1]. Using VM_BUG_ON so it's used only when CONFIG_DEBUG_VM is set, given that cache_alloc_node() is a hot code path. Acked-by: Christoph Lameter c...@linux.com -- To unsubscribe from this list: send the line

Re: [Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-23 Thread Rafael Aquini
On Tue, Apr 23, 2013 at 10:31:36AM -0400, Aaron Tomlin wrote: Hi, This patch is in response to BZ#42967 [1]. Using VM_BUG_ON so it's used only when CONFIG_DEBUG_VM is set, given that cache_alloc_node() is a hot code path. This seems to be a valid condition to BUG_ON, though. Cheers,

Re: [Patch v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-04-23 Thread David Rientjes
On Tue, 23 Apr 2013, Aaron Tomlin wrote: mm: slab: Verify the nodeid passed to cache_alloc_node If the nodeid is num_online_nodes() this can cause an Oops and a panic(). The purpose of this patch is to assert if this condition is true to aid debugging efforts rather than some

Re: [PATCH v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-02-25 Thread Christoph Lameter
On Mon, 25 Feb 2013, Rik van Riel wrote: > On 02/25/2013 12:18 PM, Aaron Tomlin wrote: > > > mm: slab: Verify the nodeid passed to cache_alloc_node > > > > If the nodeid is > num_online_nodes() this can cause an > > Oops and a panic(). The purpose of this patch is to assert > > if this

Re: [PATCH v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-02-25 Thread Rik van Riel
On 02/25/2013 12:18 PM, Aaron Tomlin wrote: mm: slab: Verify the nodeid passed to cache_alloc_node If the nodeid is > num_online_nodes() this can cause an Oops and a panic(). The purpose of this patch is to assert if this condition is true to aid debugging efforts rather than some random

Re: [PATCH v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-02-25 Thread Aaron Tomlin
Hi, This patch is in response to bz#42967 [1]. Using VM_BUG_ON instead of a generic BUG_ON so it's used only when CONFIG_DEBUG_VM is set, given that cache_alloc_node() is a hot code path. Cheers, Aaron [1]: https://bugzilla.kernel.org/show_bug.cgi?id=42967 ---8<--- mm: slab: Verify the

Re: [PATCH v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-02-25 Thread Aaron Tomlin
Hi, This patch is in response to bz#42967 [1]. Using VM_BUG_ON instead of a generic BUG_ON so it's used only when CONFIG_DEBUG_VM is set, given that cache_alloc_node() is a hot code path. Cheers, Aaron [1]: https://bugzilla.kernel.org/show_bug.cgi?id=42967 ---8--- mm: slab: Verify the

Re: [PATCH v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-02-25 Thread Rik van Riel
On 02/25/2013 12:18 PM, Aaron Tomlin wrote: mm: slab: Verify the nodeid passed to cache_alloc_node If the nodeid is num_online_nodes() this can cause an Oops and a panic(). The purpose of this patch is to assert if this condition is true to aid debugging efforts rather than some random

Re: [PATCH v2] mm: slab: Verify the nodeid passed to ____cache_alloc_node

2013-02-25 Thread Christoph Lameter
On Mon, 25 Feb 2013, Rik van Riel wrote: On 02/25/2013 12:18 PM, Aaron Tomlin wrote: mm: slab: Verify the nodeid passed to cache_alloc_node If the nodeid is num_online_nodes() this can cause an Oops and a panic(). The purpose of this patch is to assert if this condition is true