Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

2020-08-07 Thread Jon Hunter
On 06/08/2020 08:30, Rajesh Gumasta wrote: > Adding GPC DMA controller driver for Tegra186 and Tegra194. The driver > supports dma transfers between memory to memory, IO peripheral to memory > and memory to IO peripheral. > > Signed-off-by: Pavan Kunapuli > Signed-off-by: Rajesh Gumasta > ---

Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

2020-08-07 Thread Jon Hunter
On 06/08/2020 08:30, Rajesh Gumasta wrote: > Adding GPC DMA controller driver for Tegra186 and Tegra194. The driver > supports dma transfers between memory to memory, IO peripheral to memory > and memory to IO peripheral. > > Signed-off-by: Pavan Kunapuli > Signed-off-by: Rajesh Gumasta > ---

RE: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

2020-08-06 Thread Rajesh Gumasta
rnel.org; linux- > te...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Krishna Yarlagadda ; Pavan Kunapuli > > Subject: Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver > > External email: Use caution opening links or attachments > > > 06.08.2020 10:30,

Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

2020-08-06 Thread Dmitry Osipenko
06.08.2020 16:56, Rajesh Gumasta пишет: ... >>> +static const struct __maybe_unused dev_pm_ops >> tegra_dma_dev_pm_ops = { >>> + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(tegra_dma_pm_suspend, >>> +tegra_dma_pm_resume) }; >> >> Please explain why this is needed. All DMA should be stopped (not >> paused) on

Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

2020-08-06 Thread Dmitry Osipenko
06.08.2020 10:30, Rajesh Gumasta пишет: ... > +/* > + * Save and restore csr and channel register on pm_suspend > + * and pm_resume respectively > + */ > +static int __maybe_unused tegra_dma_pm_suspend(struct device *dev) > +{ > + struct tegra_dma *tdma = dev_get_drvdata(dev); > + int i; >

Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

2020-08-06 Thread Dmitry Osipenko
06.08.2020 10:30, Rajesh Gumasta пишет: > +static int tegra_dma_program_sid(struct tegra_dma_channel *tdc, > + int chan, int stream_id) > +{ > + unsigned int reg_val = tdc_read(tdc, TEGRA_GPCDMA_CHAN_MCSEQ); > + > + reg_val &= ~(TEGRA_GPCDMA_MCSEQ_STREAM_ID_MAS

Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

2020-08-06 Thread Dmitry Osipenko
06.08.2020 10:30, Rajesh Gumasta пишет: > +static struct dma_async_tx_descriptor *tegra_dma_prep_dma_memset( > + struct dma_chan *dc, dma_addr_t dest, int value, size_t len, > + unsigned long flags) > +{ This looks and reads okay, although the following style of code's formatting is a bit

[Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver

2020-08-06 Thread Rajesh Gumasta
Adding GPC DMA controller driver for Tegra186 and Tegra194. The driver supports dma transfers between memory to memory, IO peripheral to memory and memory to IO peripheral. Signed-off-by: Pavan Kunapuli Signed-off-by: Rajesh Gumasta --- drivers/dma/Kconfig | 12 + drivers/dma/Makefile