Re: [Patch v2 3/3] firmware: dmi_scan: use direct access to static vars

2015-04-13 Thread Jean Delvare
On Wed, 18 Feb 2015 13:33:21 +0200, Ivan Khoronzhuk wrote: > There is no reason to pass static vars to function that can use > only them. > > The dmi_table() can use only dmi_len and dmi_num static vars, so use > them directly. In this case we can freely change their type in one > place and slight

Re: [Patch v2 3/3] firmware: dmi_scan: use direct access to static vars

2015-02-23 Thread Matt Fleming
On Wed, 18 Feb, at 01:33:21PM, Ivan Khoronzhuk wrote: > There is no reason to pass static vars to function that can use > only them. > > The dmi_table() can use only dmi_len and dmi_num static vars, so use > them directly. In this case we can freely change their type in one > place and slightly de

[Patch v2 3/3] firmware: dmi_scan: use direct access to static vars

2015-02-18 Thread Ivan Khoronzhuk
There is no reason to pass static vars to function that can use only them. The dmi_table() can use only dmi_len and dmi_num static vars, so use them directly. In this case we can freely change their type in one place and slightly decrease redundancy. Signed-off-by: Ivan Khoronzhuk --- drivers/f