Re: [Patch v2 5/7] media: i2c: ov2659: Add powerdown/reset gpio handling

2019-09-23 Thread Sakari Ailus
On Mon, Sep 23, 2019 at 12:05:57PM -0500, Benoit Parrot wrote: > Sakari Ailus wrote on Mon [2019-Sep-23 > 09:17:32 +0300]: > > Hi Benoit, > > > > On Fri, Sep 20, 2019 at 11:55:29AM -0500, Benoit Parrot wrote: > > ... > > > > > @@ -1400,6 +1440,18 @@ static int ov2659_probe(struct i2c_client >

Re: [Patch v2 5/7] media: i2c: ov2659: Add powerdown/reset gpio handling

2019-09-23 Thread Benoit Parrot
Sakari Ailus wrote on Mon [2019-Sep-23 09:17:32 +0300]: > Hi Benoit, > > On Fri, Sep 20, 2019 at 11:55:29AM -0500, Benoit Parrot wrote: > ... > > > > @@ -1400,6 +1440,18 @@ static int ov2659_probe(struct i2c_client > > > > *client) > > > > ov2659->xvclk_frequency > 2700) > > >

Re: [Patch v2 5/7] media: i2c: ov2659: Add powerdown/reset gpio handling

2019-09-23 Thread Sakari Ailus
Hi Benoit, On Fri, Sep 20, 2019 at 11:55:29AM -0500, Benoit Parrot wrote: ... > > > @@ -1400,6 +1440,18 @@ static int ov2659_probe(struct i2c_client *client) > > > ov2659->xvclk_frequency > 2700) > > > return -EINVAL; > > > > > > + /* Optional gpio don't fail if not present

Re: [Patch v2 5/7] media: i2c: ov2659: Add powerdown/reset gpio handling

2019-09-20 Thread Benoit Parrot
Sakari Ailus wrote on Fri [2019-Sep-20 13:17:06 +0300]: > Hi Benoit, > > Thanks for the update. > > On Thu, Sep 19, 2019 at 03:39:53PM -0500, Benoit Parrot wrote: > > On some board it is possible that the sensor 'powerdown' and or 'reset' > > pin might be controlled by gpio instead of being

Re: [Patch v2 5/7] media: i2c: ov2659: Add powerdown/reset gpio handling

2019-09-20 Thread Sakari Ailus
Hi Benoit, Thanks for the update. On Thu, Sep 19, 2019 at 03:39:53PM -0500, Benoit Parrot wrote: > On some board it is possible that the sensor 'powerdown' and or 'reset' > pin might be controlled by gpio instead of being tied. > > To implement we add pm_runtime support which will handle the

[Patch v2 5/7] media: i2c: ov2659: Add powerdown/reset gpio handling

2019-09-19 Thread Benoit Parrot
On some board it is possible that the sensor 'powerdown' and or 'reset' pin might be controlled by gpio instead of being tied. To implement we add pm_runtime support which will handle the power up/down sequence. Now originally the driver assumed tat the sensor would always stay powered and there