Re: [Patch v4 02/12] irqchip: axi-intc: Clean up irqdomain argument and read/write

2016-09-02 Thread Zubair Lutfullah Kakakhel
Hi, Thanks for the review. Comments inline. On 09/01/2016 06:15 PM, Marc Zyngier wrote: On 01/09/16 17:50, Zubair Lutfullah Kakakhel wrote: The drivers read/write function handling is a bit quirky. And the irqmask is passed directly to the handler. Add a new irqchip struct to pass to the hand

Re: [Patch v4 02/12] irqchip: axi-intc: Clean up irqdomain argument and read/write

2016-09-01 Thread kbuild test robot
Hi Zubair, [auto build test WARNING on tip/irq/core] [also build test WARNING on v4.8-rc4 next-20160825] [cannot apply to linus/master linux/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base=

[Patch v4 02/12] irqchip: axi-intc: Clean up irqdomain argument and read/write

2016-09-01 Thread Zubair Lutfullah Kakakhel
The drivers read/write function handling is a bit quirky. And the irqmask is passed directly to the handler. Add a new irqchip struct to pass to the handler and cleanup read/write handling. Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 Better error handling for kzalloc Erroring out if t

Re: [Patch v4 02/12] irqchip: axi-intc: Clean up irqdomain argument and read/write

2016-09-01 Thread Marc Zyngier
On 01/09/16 17:50, Zubair Lutfullah Kakakhel wrote: > The drivers read/write function handling is a bit quirky. > And the irqmask is passed directly to the handler. > > Add a new irqchip struct to pass to the handler and > cleanup read/write handling. > > Signed-off-by: Zubair Lutfullah Kakakhel