Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-11-01 Thread Bjorn Andersson
On Wed 18 Oct 09:38 PDT 2017, Srinivas Kandagatla wrote: > On 17/10/17 07:23, Bjorn Andersson wrote: > > On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: [..] > > > +static int slim_device_remove(struct device *dev) > > > +{ > > > + struct slim_device *sbdev; > > > + struct slim_

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-24 Thread Rishi Bhattacharya

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-24 Thread Stephen Boyd
On 10/06, srinivas.kandaga...@linaro.org wrote: > + > +SLIMbus example for Qualcomm's slimbus manager component: > + > + slim@2808 { > + compatible = "qcom,slim-msm"; > + reg = <0x2808 0x2000>, > + interrupts = <0 33 0>; > + clocks = <&lcc

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-23 Thread Mark Brown
On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: > --- > Documentation/devicetree/bindings/slimbus/bus.txt | 57 ++ > Documentation/slimbus/summary | 109 This is a 40k patch which is a bit offputting for review. Splitting the docs out wou

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-18 Thread Srinivas Kandagatla
Thanks for the Review Bjorn, On 17/10/17 07:23, Bjorn Andersson wrote: On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: [..] diff --git a/drivers/slimbus/slim-core.c b/drivers/slimbus/slim-core.c [..] +/** + * Report callbacks(device_up, device_down) are implemented by slim

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-16 Thread Bjorn Andersson
On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: [..] > diff --git a/drivers/slimbus/slim-core.c b/drivers/slimbus/slim-core.c [..] > +/** > + * Report callbacks(device_up, device_down) are implemented by > slimbus-devices. > + * The calls are scheduled into a workqueue to avoid

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-16 Thread Srinivas Kandagatla
On 13/10/17 20:26, Rob Herring wrote: On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia SLIMbus (Serial Low Power Interchip Media Bus) is a specification developed by MIPI (Mobile Industry Processor Interface) alliance. SLIMbus is a 2-wire imp

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-13 Thread Rob Herring
On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SLIMbus is a 2-wire implementation, which is used to com

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-12 Thread Srinivas Kandagatla
On 12/10/17 12:01, Sanyog Kale wrote: On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia +Per specification, Slimbus uses "clock gears" to do power management based on +current frequency and bandwidth requirements. There are 10 clock gears and

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-12 Thread Sanyog Kale
On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SLIMbus is a 2-wire implementation, which is used to com

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-11 Thread Srinivas Kandagatla
On 11/10/17 11:21, Vinod Koul wrote: ah which cases would those be. I was expecting that you would have a platform_device as a slimbus controller which would call slim_register? As of now there is only one controller which uses platform driver, but in future there might be more, but this is so

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-11 Thread Mark Brown
On Tue, Oct 10, 2017 at 01:34:48PM +0100, Srinivas Kandagatla wrote: > On 10/10/17 11:05, Charles Keepax wrote: Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrolling through

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-11 Thread Vinod Koul
On Wed, Oct 11, 2017 at 10:42:23AM +0100, Srinivas Kandagatla wrote: > On 11/10/17 05:07, Vinod Koul wrote: > >On Tue, Oct 10, 2017 at 06:21:34PM +0100, Srinivas Kandagatla wrote: > >>On 10/10/17 17:49, Vinod Koul wrote: > >>+/** > >>+ * slim_register_controller: Controller bring-up and re

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-11 Thread Srinivas Kandagatla
On 11/10/17 05:07, Vinod Koul wrote: On Tue, Oct 10, 2017 at 06:21:34PM +0100, Srinivas Kandagatla wrote: On 10/10/17 17:49, Vinod Koul wrote: +static int slim_device_probe(struct device *dev) +{ + struct slim_device *sbdev; + struct slim_driver *sbdrv; + int sta

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-10 Thread Vinod Koul
On Tue, Oct 10, 2017 at 06:21:34PM +0100, Srinivas Kandagatla wrote: > On 10/10/17 17:49, Vinod Koul wrote: > +static int slim_device_probe(struct device *dev) > +{ > + struct slim_device *sbdev; > + struct slim_driver *sbdrv; > + int status = 0; > + > + sbdev

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-10 Thread Srinivas Kandagatla
On 10/10/17 17:49, Vinod Koul wrote: On Tue, Oct 10, 2017 at 01:34:55PM +0100, Srinivas Kandagatla wrote: 9 files changed, 1192 insertions(+) thats a lot of code for review, consider splitting it up further for better reviews Its was suggested that parts of dtbindings and of_* wrapper me

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-10 Thread Vinod Koul
On Tue, Oct 10, 2017 at 01:34:55PM +0100, Srinivas Kandagatla wrote: > >> 9 files changed, 1192 insertions(+) > > > >thats a lot of code for review, consider splitting it up further for better > >reviews > > Its was suggested that parts of dtbindings and of_* wrapper merged into this > patch. In

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-10 Thread Charles Keepax
On Tue, Oct 10, 2017 at 01:34:48PM +0100, Srinivas Kandagatla wrote: > Thanks for the review comments. > > On 10/10/17 11:05, Charles Keepax wrote: > > On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org > > wrote: > > > +Required property for SLIMbus child node if it is pres

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-10 Thread Srinivas Kandagatla
Thanks for your review comments, On 10/10/17 11:45, Vinod Koul wrote: On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia SLIMbus (Serial Low Power Interchip Media Bus) is a specification developed by MIPI (Mobile Industry Processor Interface) al

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-10 Thread Srinivas Kandagatla
Thanks for the review comments. On 10/10/17 11:05, Charles Keepax wrote: On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia SLIMbus (Serial Low Power Interchip Media Bus) is a specification developed by MIPI (Mobile Industry Processor Interface)

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-10 Thread Vinod Koul
On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SLIMbus is a 2-wire implementation, which is used to com

Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-10 Thread Charles Keepax
On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SLIMbus is a 2-wire implementation, which is used to com

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-07 Thread Srinivas Kandagatla
Thanks for the comments. On 07/10/17 05:14, Jonathan Neuschäfer wrote: Hi, I have some more or less trivial comments below. On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia SLIMbus (Serial Low Power Interchip Media Bus) is a specification dev

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-06 Thread Jonathan Neuschäfer
Hi, I have some more or less trivial comments below. On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SL

[Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-06 Thread srinivas . kandagatla
From: Sagar Dharia SLIMbus (Serial Low Power Interchip Media Bus) is a specification developed by MIPI (Mobile Industry Processor Interface) alliance. SLIMbus is a 2-wire implementation, which is used to communicate with peripheral components like audio-codec. SLIMbus uses Time-Division-Multiplex