Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-19 Thread Bjorn Andersson
On Wed 18 Oct 09:39 PDT 2017, Srinivas Kandagatla wrote: > Thanks for Review Comments, > > > On 18/10/17 07:15, Bjorn Andersson wrote: > > On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: [..] > > > > > + if (!async) { > > > + txn->msg->comp_cb = NULL; > > > + txn->msg->ctx =

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-19 Thread Bjorn Andersson
On Wed 18 Oct 09:39 PDT 2017, Srinivas Kandagatla wrote: > Thanks for Review Comments, > > > On 18/10/17 07:15, Bjorn Andersson wrote: > > On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: [..] > > > > > + if (!async) { > > > + txn->msg->comp_cb = NULL; > > > + txn->msg->ctx =

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-18 Thread Srinivas Kandagatla
Thanks for Review Comments, On 18/10/17 07:15, Bjorn Andersson wrote: On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters (e.g. value element

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-18 Thread Srinivas Kandagatla
Thanks for Review Comments, On 18/10/17 07:15, Bjorn Andersson wrote: On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters (e.g. value element is used to represent

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-18 Thread Bjorn Andersson
On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > Slimbus devices use value-element, and information elements to > control device parameters (e.g. value element is used to represent > gain for codec, information element is used

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-18 Thread Bjorn Andersson
On Fri 06 Oct 08:51 PDT 2017, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > Slimbus devices use value-element, and information elements to > control device parameters (e.g. value element is used to represent > gain for codec, information element is used to represent interrupt >

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-11 Thread Srinivas Kandagatla
On 11/10/17 11:24, Vinod Koul wrote: On Wed, Oct 11, 2017 at 10:42:28AM +0100, Srinivas Kandagatla wrote: On 11/10/17 05:38, Vinod Koul wrote: On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: mutex_init(>m_ctrl); + spin_lock_init(>tx.lock); +

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-11 Thread Srinivas Kandagatla
On 11/10/17 11:24, Vinod Koul wrote: On Wed, Oct 11, 2017 at 10:42:28AM +0100, Srinivas Kandagatla wrote: On 11/10/17 05:38, Vinod Koul wrote: On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: mutex_init(>m_ctrl); + spin_lock_init(>tx.lock); +

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-11 Thread Vinod Koul
On Wed, Oct 11, 2017 at 10:42:28AM +0100, Srinivas Kandagatla wrote: > On 11/10/17 05:38, Vinod Koul wrote: > >On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org > >wrote: > > > >>mutex_init(>m_ctrl); > >>+ spin_lock_init(>tx.lock); > >>+ spin_lock_init(>rx.lock); >

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-11 Thread Vinod Koul
On Wed, Oct 11, 2017 at 10:42:28AM +0100, Srinivas Kandagatla wrote: > On 11/10/17 05:38, Vinod Koul wrote: > >On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org > >wrote: > > > >>mutex_init(>m_ctrl); > >>+ spin_lock_init(>tx.lock); > >>+ spin_lock_init(>rx.lock); >

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-11 Thread Srinivas Kandagatla
On 11/10/17 05:38, Vinod Koul wrote: On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: mutex_init(>m_ctrl); + spin_lock_init(>tx.lock); + spin_lock_init(>rx.lock); locks galore :) My assumption is that you want to optimize these? But given

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-11 Thread Srinivas Kandagatla
On 11/10/17 05:38, Vinod Koul wrote: On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: mutex_init(>m_ctrl); + spin_lock_init(>tx.lock); + spin_lock_init(>rx.lock); locks galore :) My assumption is that you want to optimize these? But given

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-11 Thread Arnd Bergmann
On Wed, Oct 11, 2017 at 6:38 AM, Vinod Koul wrote: > On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org > wrote: >> + ctrl->pending_wr = kcalloc((ctrl->tx.n - 1), >> +sizeof(struct slim_pending), >> +

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-11 Thread Arnd Bergmann
On Wed, Oct 11, 2017 at 6:38 AM, Vinod Koul wrote: > On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org > wrote: >> + ctrl->pending_wr = kcalloc((ctrl->tx.n - 1), >> +sizeof(struct slim_pending), >> +

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-10 Thread Vinod Koul
On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: > mutex_init(>m_ctrl); > + spin_lock_init(>tx.lock); > + spin_lock_init(>rx.lock); locks galore :) My assumption is that you want to optimize these? But given that audio user is going to be serialized

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-10 Thread Vinod Koul
On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: > mutex_init(>m_ctrl); > + spin_lock_init(>tx.lock); > + spin_lock_init(>rx.lock); locks galore :) My assumption is that you want to optimize these? But given that audio user is going to be serialized

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-10 Thread Srinivas Kandagatla
Thanks for the review comments, On 10/10/17 13:19, Charles Keepax wrote: On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters (e.g.

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-10 Thread Srinivas Kandagatla
Thanks for the review comments, On 10/10/17 13:19, Charles Keepax wrote: On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters (e.g. value element is used to

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-10 Thread Charles Keepax
On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > Slimbus devices use value-element, and information elements to > control device parameters (e.g. value element is used to represent > gain for codec, information

Re: [alsa-devel] [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-10 Thread Charles Keepax
On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > Slimbus devices use value-element, and information elements to > control device parameters (e.g. value element is used to represent > gain for codec, information element is used to represent

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Jonathan Neuschäfer
On Sat, Oct 07, 2017 at 11:24:33AM +0100, Srinivas Kandagatla wrote: > Thanks for the comments. > > On 07/10/17 07:42, Jonathan Neuschäfer wrote: > > Hi, > > > > On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org > > wrote: > > > From: Sagar Dharia

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Jonathan Neuschäfer
On Sat, Oct 07, 2017 at 11:24:33AM +0100, Srinivas Kandagatla wrote: > Thanks for the comments. > > On 07/10/17 07:42, Jonathan Neuschäfer wrote: > > Hi, > > > > On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org > > wrote: > > > From: Sagar Dharia [...] > > > +int

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Srinivas Kandagatla
Thanks for the comments. On 07/10/17 07:42, Jonathan Neuschäfer wrote: Hi, On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Srinivas Kandagatla
Thanks for the comments. On 07/10/17 07:42, Jonathan Neuschäfer wrote: Hi, On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters (e.g. value element is used

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Jonathan Neuschäfer
Hi, On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > Slimbus devices use value-element, and information elements to > control device parameters (e.g. value element is used to represent > gain for codec, information

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-07 Thread Jonathan Neuschäfer
Hi, On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > Slimbus devices use value-element, and information elements to > control device parameters (e.g. value element is used to represent > gain for codec, information element is used to

[Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-06 Thread srinivas . kandagatla
From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters (e.g. value element is used to represent gain for codec, information element is used to represent interrupt status for codec when codec interrupt fires). Messaging

[Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-06 Thread srinivas . kandagatla
From: Sagar Dharia Slimbus devices use value-element, and information elements to control device parameters (e.g. value element is used to represent gain for codec, information element is used to represent interrupt status for codec when codec interrupt fires). Messaging APIs are used to set/get