Re: [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers

2014-07-17 Thread Andy Gross
On Thu, Jul 17, 2014 at 06:30:24AM -0400, kiran.pad...@smartplayin.com wrote: > Hi, > > On Mon, Jun 30, 2014 at 9:33 PM, Andy Gross wrote: > > From: "Ivan T. Ivanov" > > > > These drivers handles control and configuration of the HS > > and SS USB PHY transceivers. They are part of the driver >

RE: [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers

2014-07-17 Thread kiran . padwal
Hi, On Mon, Jun 30, 2014 at 9:33 PM, Andy Gross wrote: > From: "Ivan T. Ivanov" > > These drivers handles control and configuration of the HS > and SS USB PHY transceivers. They are part of the driver . [snip] . > +#include > + > +/** > + * USB QSCRATCH Hardware registers > + */ unused defi

Re: [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers

2014-06-30 Thread Felipe Balbi
Hi, first of all, since this is a brand new PHY driver, could you guys use the generic phy framework instead ? (drivers/phy) On Mon, Jun 30, 2014 at 11:03:52AM -0500, Andy Gross wrote: > diff --git a/drivers/usb/phy/phy-qcom-hsusb.c > b/drivers/usb/phy/phy-qcom-hsusb.c > new file mode 100644 > i

[Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers

2014-06-30 Thread Andy Gross
From: "Ivan T. Ivanov" These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov Signed-off-by: Andy Gross --- drivers/usb/phy/K