Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-26 Thread Tomasz Nowicki
On 20.11.2015 11:18, Lorenzo Pieralisi wrote: Hi Jiang, On Sat, Nov 14, 2015 at 01:49:08AM +0800, Jiang Liu wrote: [...] Not really. My concern is that there might be platforms out there with an offset between the CPU and PCI physical address spaces, and if we remove the offset value in acpi_

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-23 Thread Sinan Kaya
On 11/6/2015 10:44 AM, Jiang Liu wrote: > On 2015/11/6 23:32, Jiang Liu wrote: >> On 2015/11/6 22:45, Lorenzo Pieralisi wrote: >>> On Fri, Nov 06, 2015 at 09:22:46PM +0800, Jiang Liu wrote: On 2015/11/6 20:40, Tomasz Nowicki wrote: > On 06.11.2015 12:46, Jiang Liu wrote: >> On 2015/11/

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-20 Thread Lorenzo Pieralisi
Hi Jiang, On Sat, Nov 14, 2015 at 01:49:08AM +0800, Jiang Liu wrote: [...] > > Not really. My concern is that there might be platforms out there with > > an offset between the CPU and PCI physical address spaces, and if we > > remove the offset value in acpi_decode_space we can break them, > > b

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-13 Thread Jiang Liu
On 2015/11/14 1:03, Lorenzo Pieralisi wrote: > Please trim your emails, thanks. > > On Fri, Nov 13, 2015 at 01:57:30PM +0100, Tomasz Nowicki wrote: >> On 12.11.2015 16:05, Jiang Liu wrote: > > [...] > > IA64 actually ignores the translation type flag and just assume it's > TypeTranslatio

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-13 Thread Lorenzo Pieralisi
Please trim your emails, thanks. On Fri, Nov 13, 2015 at 01:57:30PM +0100, Tomasz Nowicki wrote: > On 12.11.2015 16:05, Jiang Liu wrote: [...] > >>>IA64 actually ignores the translation type flag and just assume it's > >>>TypeTranslation, so there may be some IA64 BIOS implementations > >>>accid

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-13 Thread Tomasz Nowicki
On 12.11.2015 16:05, Jiang Liu wrote: On 2015/11/12 22:45, Tomasz Nowicki wrote: On 12.11.2015 15:04, Jiang Liu wrote: On 2015/11/12 21:21, Tomasz Nowicki wrote: On 12.11.2015 09:43, Jiang Liu wrote: On 2015/11/12 1:46, Lorenzo Pieralisi wrote: On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-12 Thread Jiang Liu
On 2015/11/12 22:45, Tomasz Nowicki wrote: > On 12.11.2015 15:04, Jiang Liu wrote: >> On 2015/11/12 21:21, Tomasz Nowicki wrote: >>> On 12.11.2015 09:43, Jiang Liu wrote: On 2015/11/12 1:46, Lorenzo Pieralisi wrote: > On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: > > [

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-12 Thread Tomasz Nowicki
On 12.11.2015 15:04, Jiang Liu wrote: On 2015/11/12 21:21, Tomasz Nowicki wrote: On 12.11.2015 09:43, Jiang Liu wrote: On 2015/11/12 1:46, Lorenzo Pieralisi wrote: On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: [...] In particular, I would like to understand, for an eg DWordIO d

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-12 Thread Jiang Liu
On 2015/11/12 21:21, Tomasz Nowicki wrote: > On 12.11.2015 09:43, Jiang Liu wrote: >> On 2015/11/12 1:46, Lorenzo Pieralisi wrote: >>> On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: >>> >>> [...] >>> >> In particular, I would like to understand, for an eg DWordIO >> descriptor,

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-12 Thread Tomasz Nowicki
On 12.11.2015 09:43, Jiang Liu wrote: On 2015/11/12 1:46, Lorenzo Pieralisi wrote: On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: [...] In particular, I would like to understand, for an eg DWordIO descriptor, what Range Minimum, Range Maximum and Translation Offset represent, they

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-12 Thread Lorenzo Pieralisi
On Wed, Nov 11, 2015 at 09:55:37PM +0100, Arnd Bergmann wrote: > On Wednesday 11 November 2015 17:46:47 Lorenzo Pieralisi wrote: > > On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: > > If we go with this approach though, you are not adding the offset to > > the resource when parsing the

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-12 Thread Jiang Liu
On 2015/11/12 1:46, Lorenzo Pieralisi wrote: > On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: > > [...] > In particular, I would like to understand, for an eg DWordIO descriptor, what Range Minimum, Range Maximum and Translation Offset represent, they can't mean differe

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-11 Thread Arnd Bergmann
On Wednesday 11 November 2015 17:46:47 Lorenzo Pieralisi wrote: > On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: > If we go with this approach though, you are not adding the offset to > the resource when parsing the memory spaces in acpi_decode_space(), are we > sure that's what we real

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-11 Thread Liviu Dudau
On Wed, Nov 11, 2015 at 05:46:47PM +, Lorenzo Pieralisi wrote: > On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: > > [...] > > > >> In particular, I would like to understand, for an eg DWordIO descriptor, > > >> what Range Minimum, Range Maximum and Translation Offset represent, >

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-11 Thread Lorenzo Pieralisi
On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: [...] > >> In particular, I would like to understand, for an eg DWordIO descriptor, > >> what Range Minimum, Range Maximum and Translation Offset represent, > >> they can't mean different things depending on the SW parsing them, > >> this

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-09 Thread Jiang Liu
On 2015/11/10 4:09, Arnd Bergmann wrote: > On Monday 09 November 2015 17:10:43 Lorenzo Pieralisi wrote: >> On Mon, Nov 09, 2015 at 03:07:38PM +0100, Tomasz Nowicki wrote: >>> On 06.11.2015 14:22, Jiang Liu wrote: On 2015/11/6 20:40, Tomasz Nowicki wrote: > On 06.11.2015 12:46, Jiang Liu wr

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 17:10:43 Lorenzo Pieralisi wrote: > On Mon, Nov 09, 2015 at 03:07:38PM +0100, Tomasz Nowicki wrote: > > On 06.11.2015 14:22, Jiang Liu wrote: > > >On 2015/11/6 20:40, Tomasz Nowicki wrote: > > >>On 06.11.2015 12:46, Jiang Liu wrote: > > >>>On 2015/11/6 18:37, Tomasz Nowic

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-09 Thread Lorenzo Pieralisi
[CC'ing Arnd] On Mon, Nov 09, 2015 at 03:07:38PM +0100, Tomasz Nowicki wrote: > On 06.11.2015 14:22, Jiang Liu wrote: > >On 2015/11/6 20:40, Tomasz Nowicki wrote: > >>On 06.11.2015 12:46, Jiang Liu wrote: > >>>On 2015/11/6 18:37, Tomasz Nowicki wrote: > On 06.11.2015 09:52, Jiang Liu wrote: >

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-09 Thread Tomasz Nowicki
On 06.11.2015 14:22, Jiang Liu wrote: On 2015/11/6 20:40, Tomasz Nowicki wrote: On 06.11.2015 12:46, Jiang Liu wrote: On 2015/11/6 18:37, Tomasz Nowicki wrote: On 06.11.2015 09:52, Jiang Liu wrote: Sure, ARM64 (0-16M IO space) QEMU example: DWordIO (ResourceProducer, MinFixed, MaxFixed, PosDec

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Jiang Liu
On 2015/11/6 23:32, Jiang Liu wrote: > On 2015/11/6 22:45, Lorenzo Pieralisi wrote: >> On Fri, Nov 06, 2015 at 09:22:46PM +0800, Jiang Liu wrote: >>> On 2015/11/6 20:40, Tomasz Nowicki wrote: On 06.11.2015 12:46, Jiang Liu wrote: > On 2015/11/6 18:37, Tomasz Nowicki wrote: >> On 06.11.

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Jiang Liu
On 2015/11/6 22:45, Lorenzo Pieralisi wrote: > On Fri, Nov 06, 2015 at 09:22:46PM +0800, Jiang Liu wrote: >> On 2015/11/6 20:40, Tomasz Nowicki wrote: >>> On 06.11.2015 12:46, Jiang Liu wrote: On 2015/11/6 18:37, Tomasz Nowicki wrote: > On 06.11.2015 09:52, Jiang Liu wrote: > Sure, ARM

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Lorenzo Pieralisi
On Fri, Nov 06, 2015 at 09:22:46PM +0800, Jiang Liu wrote: > On 2015/11/6 20:40, Tomasz Nowicki wrote: > > On 06.11.2015 12:46, Jiang Liu wrote: > >> On 2015/11/6 18:37, Tomasz Nowicki wrote: > >>> On 06.11.2015 09:52, Jiang Liu wrote: > >>> Sure, ARM64 (0-16M IO space) QEMU example: > >>> DWordIO

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Jiang Liu
On 2015/11/6 20:40, Tomasz Nowicki wrote: > On 06.11.2015 12:46, Jiang Liu wrote: >> On 2015/11/6 18:37, Tomasz Nowicki wrote: >>> On 06.11.2015 09:52, Jiang Liu wrote: >>> Sure, ARM64 (0-16M IO space) QEMU example: >>> DWordIO (ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange, >>>

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Lorenzo Pieralisi
On Fri, Nov 06, 2015 at 04:52:47PM +0800, Jiang Liu wrote: [...] > >>> +int acpi_pci_probe_root_resources(struct acpi_pci_root_info *info) > >>> +{ > >>> + int ret; > >>> + struct list_head *list = &info->resources; > >>> + struct acpi_device *device = info->bridge; > >>> + struct resource_entry

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Tomasz Nowicki
On 06.11.2015 12:46, Jiang Liu wrote: On 2015/11/6 18:37, Tomasz Nowicki wrote: On 06.11.2015 09:52, Jiang Liu wrote: On 2015/11/6 2:19, Lorenzo Pieralisi wrote: On Thu, Nov 05, 2015 at 03:21:34PM +0100, Tomasz Nowicki wrote: On 14.10.2015 08:29, Jiang Liu wrote: [...] +static void acpi_p

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Jiang Liu
On 2015/11/6 18:37, Tomasz Nowicki wrote: > On 06.11.2015 09:52, Jiang Liu wrote: >> On 2015/11/6 2:19, Lorenzo Pieralisi wrote: >>> On Thu, Nov 05, 2015 at 03:21:34PM +0100, Tomasz Nowicki wrote: On 14.10.2015 08:29, Jiang Liu wrote: >>> >>> [...] >>> > +static void acpi_pci_root_validate

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Tomasz Nowicki
On 06.11.2015 09:52, Jiang Liu wrote: On 2015/11/6 2:19, Lorenzo Pieralisi wrote: On Thu, Nov 05, 2015 at 03:21:34PM +0100, Tomasz Nowicki wrote: On 14.10.2015 08:29, Jiang Liu wrote: [...] +static void acpi_pci_root_validate_resources(struct device *dev, +

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Tomasz Nowicki
On 05.11.2015 19:19, Lorenzo Pieralisi wrote: On Thu, Nov 05, 2015 at 03:21:34PM +0100, Tomasz Nowicki wrote: On 14.10.2015 08:29, Jiang Liu wrote: [...] +static void acpi_pci_root_validate_resources(struct device *dev, +struct list_head *resources

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-06 Thread Jiang Liu
On 2015/11/6 2:19, Lorenzo Pieralisi wrote: > On Thu, Nov 05, 2015 at 03:21:34PM +0100, Tomasz Nowicki wrote: >> On 14.10.2015 08:29, Jiang Liu wrote: > > [...] > >>> +static void acpi_pci_root_validate_resources(struct device *dev, >>> +struct list_head *r

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-05 Thread Jiang Liu
On 2015/11/6 2:19, Lorenzo Pieralisi wrote: > On Thu, Nov 05, 2015 at 03:21:34PM +0100, Tomasz Nowicki wrote: >> On 14.10.2015 08:29, Jiang Liu wrote: > > [...] > >>> +static void acpi_pci_root_validate_resources(struct device *dev, >>> +struct list_head *r

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-05 Thread Jiang Liu
On 2015/11/5 22:21, Tomasz Nowicki wrote: > On 14.10.2015 08:29, Jiang Liu wrote: >> Introduce common interface acpi_pci_root_create() and related data >> structures to create PCI root bus for ACPI PCI host bridges. It will >> be used to kill duplicated arch specific code for IA64 and x86. It may >

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-05 Thread Lorenzo Pieralisi
On Thu, Nov 05, 2015 at 03:21:34PM +0100, Tomasz Nowicki wrote: > On 14.10.2015 08:29, Jiang Liu wrote: [...] > >+static void acpi_pci_root_validate_resources(struct device *dev, > >+ struct list_head *resources, > >+

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-05 Thread Tomasz Nowicki
On 14.10.2015 08:29, Jiang Liu wrote: Introduce common interface acpi_pci_root_create() and related data structures to create PCI root bus for ACPI PCI host bridges. It will be used to kill duplicated arch specific code for IA64 and x86. It may also help ARM64 in future. Reviewed-by: Lorenzo Pie

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Tomasz Nowicki
On 21.10.2015 13:42, Lorenzo Pieralisi wrote: On Wed, Oct 21, 2015 at 01:27:33PM +0200, Tomasz Nowicki wrote: On 21.10.2015 13:02, Liviu Dudau wrote: On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: On 14.10.2015 08:29, Jiang Liu wrote: Introduce common interface acpi_pci_root_

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Liviu Dudau
On Wed, Oct 21, 2015 at 07:49:13PM +0800, Jiang Liu wrote: > On 2015/10/21 19:27, Tomasz Nowicki wrote: > > On 21.10.2015 13:02, Liviu Dudau wrote: > >> On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > >>> On 14.10.2015 08:29, Jiang Liu wrote: > Introduce common interface acpi

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Jiang Liu
On 2015/10/21 19:27, Tomasz Nowicki wrote: > On 21.10.2015 13:02, Liviu Dudau wrote: >> On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: >>> On 14.10.2015 08:29, Jiang Liu wrote: Introduce common interface acpi_pci_root_create() and related data structures to create PCI roo

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Liviu Dudau
On Wed, Oct 21, 2015 at 01:27:33PM +0200, Tomasz Nowicki wrote: > On 21.10.2015 13:02, Liviu Dudau wrote: > >On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > >>On 14.10.2015 08:29, Jiang Liu wrote: > >>>Introduce common interface acpi_pci_root_create() and related data > >>>structu

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Lorenzo Pieralisi
On Wed, Oct 21, 2015 at 01:27:33PM +0200, Tomasz Nowicki wrote: > On 21.10.2015 13:02, Liviu Dudau wrote: > >On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > >>On 14.10.2015 08:29, Jiang Liu wrote: > >>>Introduce common interface acpi_pci_root_create() and related data > >>>structu

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Tomasz Nowicki
On 21.10.2015 13:02, Liviu Dudau wrote: On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: On 14.10.2015 08:29, Jiang Liu wrote: Introduce common interface acpi_pci_root_create() and related data structures to create PCI root bus for ACPI PCI host bridges. It will be used to kill d

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Liviu Dudau
On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > On 14.10.2015 08:29, Jiang Liu wrote: > >Introduce common interface acpi_pci_root_create() and related data > >structures to create PCI root bus for ACPI PCI host bridges. It will > >be used to kill duplicated arch specific code for

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Tomasz Nowicki
On 14.10.2015 08:29, Jiang Liu wrote: Introduce common interface acpi_pci_root_create() and related data structures to create PCI root bus for ACPI PCI host bridges. It will be used to kill duplicated arch specific code for IA64 and x86. It may also help ARM64 in future. Reviewed-by: Lorenzo Pie

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-15 Thread Bjorn Helgaas
On Wed, Oct 14, 2015 at 02:29:39PM +0800, Jiang Liu wrote: > Introduce common interface acpi_pci_root_create() and related data > structures to create PCI root bus for ACPI PCI host bridges. It will > be used to kill duplicated arch specific code for IA64 and x86. It may > also help ARM64 in future

[Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-13 Thread Jiang Liu
Introduce common interface acpi_pci_root_create() and related data structures to create PCI root bus for ACPI PCI host bridges. It will be used to kill duplicated arch specific code for IA64 and x86. It may also help ARM64 in future. Reviewed-by: Lorenzo Pieralisi Tested-by: Tony Luck Signed-off