Re: [QUESTION] balloon page isolation needs LRU lock?

2013-12-09 Thread Joonsoo Kim
On Fri, Dec 06, 2013 at 10:21:43AM -0200, Rafael Aquini wrote: > On Fri, Dec 06, 2013 at 05:53:31PM +0900, Joonsoo Kim wrote: > > Hello, Rafael. > > > > I looked at some compaction code and found that some oddity about > > balloon compaction. In isolate_migratepages_range(), if we meet > >

Re: [QUESTION] balloon page isolation needs LRU lock?

2013-12-09 Thread Joonsoo Kim
On Fri, Dec 06, 2013 at 10:21:43AM -0200, Rafael Aquini wrote: On Fri, Dec 06, 2013 at 05:53:31PM +0900, Joonsoo Kim wrote: Hello, Rafael. I looked at some compaction code and found that some oddity about balloon compaction. In isolate_migratepages_range(), if we meet !PageLRU(), we

Re: [QUESTION] balloon page isolation needs LRU lock?

2013-12-06 Thread Rafael Aquini
On Fri, Dec 06, 2013 at 05:53:31PM +0900, Joonsoo Kim wrote: > Hello, Rafael. > > I looked at some compaction code and found that some oddity about > balloon compaction. In isolate_migratepages_range(), if we meet > !PageLRU(), we check whether this page is for balloon compaction. > In this case,

[QUESTION] balloon page isolation needs LRU lock?

2013-12-06 Thread Joonsoo Kim
Hello, Rafael. I looked at some compaction code and found that some oddity about balloon compaction. In isolate_migratepages_range(), if we meet !PageLRU(), we check whether this page is for balloon compaction. In this case, code needs locked. Is the lock really needed? I can't find any

[QUESTION] balloon page isolation needs LRU lock?

2013-12-06 Thread Joonsoo Kim
Hello, Rafael. I looked at some compaction code and found that some oddity about balloon compaction. In isolate_migratepages_range(), if we meet !PageLRU(), we check whether this page is for balloon compaction. In this case, code needs locked. Is the lock really needed? I can't find any

Re: [QUESTION] balloon page isolation needs LRU lock?

2013-12-06 Thread Rafael Aquini
On Fri, Dec 06, 2013 at 05:53:31PM +0900, Joonsoo Kim wrote: Hello, Rafael. I looked at some compaction code and found that some oddity about balloon compaction. In isolate_migratepages_range(), if we meet !PageLRU(), we check whether this page is for balloon compaction. In this case, code