Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-10 Thread Benjamin Herrenschmidt
On Wed, 2007-04-11 at 15:41 +1000, Paul Mackerras wrote: > Benjamin Herrenschmidt writes: > > > > > For a 64K page size kernel, we have 3 level page tables and we use 3 > > > > caches: a PGD pages are 128 bytes (yeah, not big heh...), our pmd > > > > pages are 32K (half a page) and PTE pages are P

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-10 Thread Paul Mackerras
Benjamin Herrenschmidt writes: > > > For a 64K page size kernel, we have 3 level page tables and we use 3 > > > caches: a PGD pages are 128 bytes (yeah, not big heh...), our pmd > > > pages are 32K (half a page) and PTE pages are PAGE_SIZE (64K). > > > > Ok so use quicklists for the PTEs and slab

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-10 Thread Benjamin Herrenschmidt
On Tue, 2007-04-10 at 21:04 -0700, Christoph Lameter wrote: > On Tue, 10 Apr 2007, Benjamin Herrenschmidt wrote: > > > On Mon, 2007-04-09 at 11:25 -0700, Christoph Lameter wrote: > > > > > Quicklists for page table pages V5 > > > > Looks interesting, but unfortunately not very useful at this poi

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-10 Thread Christoph Lameter
On Tue, 10 Apr 2007, Benjamin Herrenschmidt wrote: > On Mon, 2007-04-09 at 11:25 -0700, Christoph Lameter wrote: > > > Quicklists for page table pages V5 > > Looks interesting, but unfortunately not very useful at this point for > powerpc unless you remove the assumption that quicklists contain

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-09 Thread Benjamin Herrenschmidt
On Mon, 2007-04-09 at 11:25 -0700, Christoph Lameter wrote: > Quicklists for page table pages V5 Looks interesting, but unfortunately not very useful at this point for powerpc unless you remove the assumption that quicklists contain pages... On powerpc, we currently use kmem cache slabs (though

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-09 Thread Christoph Lameter
On Mon, 9 Apr 2007, William Lee Irwin III wrote: > Basically, I'll help all this along. Thank you. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please rea

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-09 Thread William Lee Irwin III
On Mon, 9 Apr 2007, Andrew Morton wrote: >> So... we skipped i386 this time? >> I'd have gone squeamish if it was included, due to the mystery crash when >> we (effectively) set the list size to zero. Someone(tm) should look into >> that - who knows, it might indicate a problem in generic code.

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-09 Thread Christoph Lameter
On Mon, 9 Apr 2007, Andrew Morton wrote: > On Mon, 9 Apr 2007 11:25:09 -0700 (PDT) > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > Quicklists for page table pages V5 > > So... we skipped i386 this time? > > I'd have gone squeamish if it was included, due to the mystery crash when > we (ef

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-09 Thread Andrew Morton
On Mon, 9 Apr 2007 11:25:09 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > Quicklists for page table pages V5 So... we skipped i386 this time? I'd have gone squeamish if it was included, due to the mystery crash when we (effectively) set the list size to zero. Someone(tm) should lo

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-09 Thread Andrew Morton
On Mon, 9 Apr 2007 11:25:09 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > Quicklists for page table pages V5 > > ... > > +/* > + * The two key functions quicklist_alloc and quicklist_free are inline so > + * that they may be custom compiled for the platform. > + * Specifying a NULL

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-09 Thread Christoph Lameter
On Mon, 9 Apr 2007, Andrew Morton wrote: > On Mon, 9 Apr 2007 11:25:09 -0700 (PDT) > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > On x86_64 this cuts allocation overhead for page table pages down to > > a fraction (kernel compile / editing load. TSC based measurement > > of times spend in

Re: [QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-09 Thread Andrew Morton
On Mon, 9 Apr 2007 11:25:09 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On x86_64 this cuts allocation overhead for page table pages down to > a fraction (kernel compile / editing load. TSC based measurement > of times spend in each function): > > no quicklist > > pte_alloc

[QUICKLIST 1/4] Quicklists for page table pages V5

2007-04-09 Thread Christoph Lameter
Quicklists for page table pages V5 V4->V5 - Change rationale: Justify by performance numbers instead of code consolidation. - Drop i386 patch. Lets deal with that can of worms later. - x86_64: Also cache pte pages via quicklists. - Add quicklist_free_page for the cases in which we have a page