Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-02 Thread Eduardo Habkost
On Thu, Apr 02, 2015 at 09:09:07AM +0200, Michael Mueller wrote: > On Wed, 1 Apr 2015 20:05:24 -0300 > Eduardo Habkost wrote: > > > > > > > > > If you don't want to encode that knowledge in libvirt or other > > > > management software for s390, it looks like you need something like a > > > >

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-02 Thread Michael Mueller
On Wed, 1 Apr 2015 20:05:24 -0300 Eduardo Habkost wrote: > > > > > > If you don't want to encode that knowledge in libvirt or other > > > management software for s390, it looks like you need something like a > > > "stable-abi-safe" field on CpuDefinitionInfo? > > > > Exactly that fulfills

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-02 Thread Michael Mueller
On Wed, 1 Apr 2015 20:05:24 -0300 Eduardo Habkost ehabk...@redhat.com wrote: If you don't want to encode that knowledge in libvirt or other management software for s390, it looks like you need something like a stable-abi-safe field on CpuDefinitionInfo? Exactly that fulfills

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-02 Thread Eduardo Habkost
On Thu, Apr 02, 2015 at 09:09:07AM +0200, Michael Mueller wrote: On Wed, 1 Apr 2015 20:05:24 -0300 Eduardo Habkost ehabk...@redhat.com wrote: If you don't want to encode that knowledge in libvirt or other management software for s390, it looks like you need something like a

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Eduardo Habkost
On Wed, Apr 01, 2015 at 09:05:31PM +0200, Michael Mueller wrote: > On Wed, 1 Apr 2015 13:59:05 -0300 > Eduardo Habkost wrote: > > > > Not directly invalid as "-cpu none" will be the same as omitting the -cpu > > > option. > > > KVM will setup the vcpu properties withou any QEMU control to

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 21:05:31 +0200 Michael Mueller wrote: > And cpu model "none" just means that QEMU does not manage the cpu model. > That's also > the reason why I initially returned an empty "[]" model and not "none". This > somewhat > convinces me to go back to this approach... And for

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 13:59:05 -0300 Eduardo Habkost wrote: > > Not directly invalid as "-cpu none" will be the same as omitting the -cpu > > option. > > KVM will setup the vcpu properties withou any QEMU control to whatever the > > hosting > > machine and the kvm kernel code offers. That will

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Eduardo Habkost
(CCing libvir-list and Jiri Denemark for libvirt-related discussion about -cpu host/none, and live-migration safety expectations) On Wed, Apr 01, 2015 at 06:31:23PM +0200, Michael Mueller wrote: > On Wed, 1 Apr 2015 10:01:13 -0300 > Eduardo Habkost wrote: > > > On Tue, Mar 31, 2015 at

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 10:01:13 -0300 Eduardo Habkost wrote: > On Tue, Mar 31, 2015 at 10:09:09PM +0200, Michael Mueller wrote: > > On Tue, 31 Mar 2015 15:35:26 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > > > This patch implements

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 10:01:13 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Tue, Mar 31, 2015 at 10:09:09PM +0200, Michael Mueller wrote: On Tue, 31 Mar 2015 15:35:26 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote:

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Eduardo Habkost
(CCing libvir-list and Jiri Denemark for libvirt-related discussion about -cpu host/none, and live-migration safety expectations) On Wed, Apr 01, 2015 at 06:31:23PM +0200, Michael Mueller wrote: On Wed, 1 Apr 2015 10:01:13 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Tue, Mar 31,

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 13:59:05 -0300 Eduardo Habkost ehabk...@redhat.com wrote: Not directly invalid as -cpu none will be the same as omitting the -cpu option. KVM will setup the vcpu properties withou any QEMU control to whatever the hosting machine and the kvm kernel code offers. That

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 21:05:31 +0200 Michael Mueller m...@linux.vnet.ibm.com wrote: And cpu model none just means that QEMU does not manage the cpu model. That's also the reason why I initially returned an empty [] model and not none. This somewhat convinces me to go back to this approach...

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Eduardo Habkost
On Wed, Apr 01, 2015 at 09:05:31PM +0200, Michael Mueller wrote: On Wed, 1 Apr 2015 13:59:05 -0300 Eduardo Habkost ehabk...@redhat.com wrote: Not directly invalid as -cpu none will be the same as omitting the -cpu option. KVM will setup the vcpu properties withou any QEMU control to

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Eduardo Habkost
On Tue, Mar 31, 2015 at 01:21:05PM +0200, Michael Mueller wrote: > On Mon, 30 Mar 2015 17:17:21 -0300 > Eduardo Habkost wrote: > > > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > > This patch implements a new QMP request named 'query-cpu-model'. > > > It returns the cpu

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Eduardo Habkost
On Mon, Mar 30, 2015 at 02:20:43PM -0600, Eric Blake wrote: > On 03/30/2015 02:17 PM, Eduardo Habkost wrote: > > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > >> This patch implements a new QMP request named 'query-cpu-model'. > >> It returns the cpu model of cpu 0 and its

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
On Mon, 30 Mar 2015 17:17:21 -0300 Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > This patch implements a new QMP request named 'query-cpu-model'. > > It returns the cpu model of cpu 0 and its backing accelerator. > > > > request: > > {"execute"

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
On Mon, 30 Mar 2015 16:50:20 -0300 Eduardo Habkost wrote: Hello Eduardo, > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > [...] > > diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c > > index 829945d..1698b52 100644 > > --- a/target-s390x/cpu.c > > +++

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 30 Mar 2015 14:19:27 -0600 Eric Blake wrote: > On 03/30/2015 08:28 AM, Michael Mueller wrote: > > This patch implements a new QMP request named 'query-cpu-model'. > > It returns the cpu model of cpu 0 and its backing accelerator. > > > >

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
On Mon, 30 Mar 2015 16:50:20 -0300 Eduardo Habkost ehabk...@redhat.com wrote: Hello Eduardo, On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: [...] diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c index 829945d..1698b52 100644 --- a/target-s390x/cpu.c +++

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 30 Mar 2015 14:19:27 -0600 Eric Blake ebl...@redhat.com wrote: On 03/30/2015 08:28 AM, Michael Mueller wrote: This patch implements a new QMP request named 'query-cpu-model'. It returns the cpu model of cpu 0 and its backing accelerator.

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
On Mon, 30 Mar 2015 17:17:21 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: This patch implements a new QMP request named 'query-cpu-model'. It returns the cpu model of cpu 0 and its backing accelerator. request:

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Eduardo Habkost
On Tue, Mar 31, 2015 at 01:21:05PM +0200, Michael Mueller wrote: On Mon, 30 Mar 2015 17:17:21 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: This patch implements a new QMP request named 'query-cpu-model'. It returns

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Eduardo Habkost
On Mon, Mar 30, 2015 at 02:20:43PM -0600, Eric Blake wrote: On 03/30/2015 02:17 PM, Eduardo Habkost wrote: On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: This patch implements a new QMP request named 'query-cpu-model'. It returns the cpu model of cpu 0 and its backing

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Eric Blake
On 03/30/2015 02:17 PM, Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: >> This patch implements a new QMP request named 'query-cpu-model'. >> It returns the cpu model of cpu 0 and its backing accelerator. >> >> request: >> {"execute" : "query-cpu-model"

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Eric Blake
On 03/30/2015 08:28 AM, Michael Mueller wrote: > This patch implements a new QMP request named 'query-cpu-model'. > It returns the cpu model of cpu 0 and its backing accelerator. > > request: > {"execute" : "query-cpu-model" } > > answer: > {"return" : {"name": "2827-ga2", "accel": "kvm" }}

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Eric Blake
On 03/30/2015 02:17 PM, Eduardo Habkost wrote: On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: This patch implements a new QMP request named 'query-cpu-model'. It returns the cpu model of cpu 0 and its backing accelerator. request: {execute : query-cpu-model } answer:

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Eric Blake
On 03/30/2015 08:28 AM, Michael Mueller wrote: This patch implements a new QMP request named 'query-cpu-model'. It returns the cpu model of cpu 0 and its backing accelerator. request: {execute : query-cpu-model } answer: {return : {name: 2827-ga2, accel: kvm }} Alias names are