Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 14:19:13 +0200 Cornelia Huck wrote: > > > >> Would it make sense to do the cast here > > > > > > > > cpu_model_get/set() is used to handle both attributes, > > > > KVM_S390_VM_CPU_MACHINE and KVM_S390_VM_CPU_PROCESSOR. > > > > Both require a different type in the signat

Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Cornelia Huck
On Mon, 27 Apr 2015 13:07:58 +0200 Michael Mueller wrote: > On Mon, 27 Apr 2015 12:52:54 +0200 > Christian Borntraeger wrote: > > > Am 27.04.2015 um 11:43 schrieb Michael Mueller: > > > On Mon, 27 Apr 2015 10:15:47 +0200 > > > Christian Borntraeger wrote: > > > > > >> Am 13.04.2015 um 15:56 s

Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 12:52:54 +0200 Christian Borntraeger wrote: > Am 27.04.2015 um 11:43 schrieb Michael Mueller: > > On Mon, 27 Apr 2015 10:15:47 +0200 > > Christian Borntraeger wrote: > > > >> Am 13.04.2015 um 15:56 schrieb Michael Mueller: > >> [...] > >>> +static int cpu_model_get(KVMState

Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Christian Borntraeger
Am 27.04.2015 um 11:43 schrieb Michael Mueller: > On Mon, 27 Apr 2015 10:15:47 +0200 > Christian Borntraeger wrote: > >> Am 13.04.2015 um 15:56 schrieb Michael Mueller: >> [...] >>> +static int cpu_model_get(KVMState *s, uint64_t attr, uint64_t addr) >>> +{ >>> +int rc = -ENOSYS; >>> +str

Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 10:15:47 +0200 Christian Borntraeger wrote: > Am 13.04.2015 um 15:56 schrieb Michael Mueller: > [...] > > +static int cpu_model_get(KVMState *s, uint64_t attr, uint64_t addr) > > +{ > > +int rc = -ENOSYS; > > +struct kvm_device_attr dev_attr = { > > +.group = K

Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Christian Borntraeger
Am 13.04.2015 um 15:56 schrieb Michael Mueller: [...] > +static int cpu_model_get(KVMState *s, uint64_t attr, uint64_t addr) > +{ > +int rc = -ENOSYS; > +struct kvm_device_attr dev_attr = { > +.group = KVM_S390_VM_CPU_MODEL, > +.attr = attr, > +.addr = addr, Would i