Re: [Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-09 Thread Namhyung Kim
On Mon, Jul 9, 2012 at 3:48 PM, Peter Zijlstra wrote: > On Mon, 2012-07-09 at 09:50 +0900, Namhyung Kim wrote: >> On Sat, 07 Jul 2012 21:29:19 -0400, Steven Rostedt wrote: >> > On Sat, 2012-07-07 at 14:44 +0900, Namhyung Kim wrote: >> >> Hi, >> >> >> >> I have a question on the code below: >> >>

Re: [Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-09 Thread Peter Zijlstra
On Mon, 2012-07-09 at 09:50 +0900, Namhyung Kim wrote: > On Sat, 07 Jul 2012 21:29:19 -0400, Steven Rostedt wrote: > > On Sat, 2012-07-07 at 14:44 +0900, Namhyung Kim wrote: > >> Hi, > >> > >> I have a question on the code below: > >> > >> void rt_mutex_setprio(struct task_struct *p, int prio) >

Re: [Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-09 Thread Peter Zijlstra
On Mon, 2012-07-09 at 09:50 +0900, Namhyung Kim wrote: On Sat, 07 Jul 2012 21:29:19 -0400, Steven Rostedt wrote: On Sat, 2012-07-07 at 14:44 +0900, Namhyung Kim wrote: Hi, I have a question on the code below: void rt_mutex_setprio(struct task_struct *p, int prio) { ...

Re: [Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-09 Thread Namhyung Kim
On Mon, Jul 9, 2012 at 3:48 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, 2012-07-09 at 09:50 +0900, Namhyung Kim wrote: On Sat, 07 Jul 2012 21:29:19 -0400, Steven Rostedt wrote: On Sat, 2012-07-07 at 14:44 +0900, Namhyung Kim wrote: Hi, I have a question on the code below:

Re: [Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-08 Thread Namhyung Kim
On Sat, 07 Jul 2012 21:29:19 -0400, Steven Rostedt wrote: > On Sat, 2012-07-07 at 14:44 +0900, Namhyung Kim wrote: >> Hi, >> >> I have a question on the code below: >> >> void rt_mutex_setprio(struct task_struct *p, int prio) >> { >> ... >> if (on_rq) >>

Re: [Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-08 Thread Namhyung Kim
On Sat, 07 Jul 2012 21:29:19 -0400, Steven Rostedt wrote: On Sat, 2012-07-07 at 14:44 +0900, Namhyung Kim wrote: Hi, I have a question on the code below: void rt_mutex_setprio(struct task_struct *p, int prio) { ... if (on_rq) enqueue_task(rq, p, oldprio prio

Re: [Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-07 Thread Steven Rostedt
On Sat, 2012-07-07 at 14:44 +0900, Namhyung Kim wrote: > Hi, > > I have a question on the code below: > > void rt_mutex_setprio(struct task_struct *p, int prio) > { > ... > if (on_rq) > enqueue_task(rq, p, oldprio < prio ? ENQUEUE_HEAD : 0); > > When enqueueing @p

Re: [Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-07 Thread Steven Rostedt
On Sat, 2012-07-07 at 14:44 +0900, Namhyung Kim wrote: Hi, I have a question on the code below: void rt_mutex_setprio(struct task_struct *p, int prio) { ... if (on_rq) enqueue_task(rq, p, oldprio prio ? ENQUEUE_HEAD : 0); When enqueueing @p with new

[Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-06 Thread Namhyung Kim
Hi, I have a question on the code below: void rt_mutex_setprio(struct task_struct *p, int prio) { ... if (on_rq) enqueue_task(rq, p, oldprio < prio ? ENQUEUE_HEAD : 0); When enqueueing @p with new @prio, it seems put @p at the head of a rq if appropriate. I guess

[Question] sched/rt_mutex: re-enqueue_task on rt_mutex_setprio()

2012-07-06 Thread Namhyung Kim
Hi, I have a question on the code below: void rt_mutex_setprio(struct task_struct *p, int prio) { ... if (on_rq) enqueue_task(rq, p, oldprio prio ? ENQUEUE_HEAD : 0); When enqueueing @p with new @prio, it seems put @p at the head of a rq if appropriate. I guess