Re: [REF PATCH] mm/swap: fix swapon failure

2020-11-09 Thread Alex Shi
在 2020/11/9 下午8:17, Alex Shi 写道: > > > 在 2020/11/9 下午8:07, Matthew Wilcox 写道: >> On Mon, Nov 09, 2020 at 07:47:16PM +0800, Alex Shi wrote: >>> Go through the context I found the exit_swap_address_space(p->type) >>> shouldn't be used in good result path. So just move it to error path. >> >>

Re: [REF PATCH] mm/swap: fix swapon failure

2020-11-09 Thread Alex Shi
在 2020/11/9 下午8:07, Matthew Wilcox 写道: > On Mon, Nov 09, 2020 at 07:47:16PM +0800, Alex Shi wrote: >> Go through the context I found the exit_swap_address_space(p->type) >> shouldn't be used in good result path. So just move it to error path. > > But ... it's not used in the success path.

Re: [REF PATCH] mm/swap: fix swapon failure

2020-11-09 Thread linmiaohe
Hi: Alex Shi wrote: > One of my VM guest has a swapon issue: > root #swapon -v -f /swap1 > swapon /swap1 > swapon: /swap1: found swap signature: version 1, page-size 4, same byte order > swapon: /swap1: pagesize=4096, swapsize=1607467008, devsize=1607467008 > swapon: /swap1: swapon failed:

Re: [REF PATCH] mm/swap: fix swapon failure

2020-11-09 Thread Matthew Wilcox
On Mon, Nov 09, 2020 at 07:47:16PM +0800, Alex Shi wrote: > Go through the context I found the exit_swap_address_space(p->type) > shouldn't be used in good result path. So just move it to error path. But ... it's not used in the success path. There's a 'goto' right before it. Does this really

[REF PATCH] mm/swap: fix swapon failure

2020-11-09 Thread Alex Shi
One of my VM guest has a swapon issue: root #swapon -v -f /swap1 swapon /swap1 swapon: /swap1: found swap signature: version 1, page-size 4, same byte order swapon: /swap1: pagesize=4096, swapsize=1607467008, devsize=1607467008 swapon: /swap1: swapon failed: Invalid argument and bisection report