Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-03-08 Thread Richard Genoud
Cc += Al Viro 2017-02-12 16:44 GMT+01:00 Dmitry Romanov : > On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: >> >> 1) Sometimes process accounting does not work at all. >> >> The acct() system call (to activate process accounting) return value 0, >> which

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-03-08 Thread Richard Genoud
Cc += Al Viro 2017-02-12 16:44 GMT+01:00 Dmitry Romanov : > On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: >> >> 1) Sometimes process accounting does not work at all. >> >> The acct() system call (to activate process accounting) return value 0, >> which means that process

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-02-12 Thread Dmitry Romanov
On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > 1) Sometimes process accounting does not work at all. > > The acct() system call (to activate process accounting) return value 0, > which means that process accounting is activated successfully. > However, no process

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-02-12 Thread Dmitry Romanov
On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > 1) Sometimes process accounting does not work at all. > > The acct() system call (to activate process accounting) return value 0, > which means that process accounting is activated successfully. > However, no process

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-02-10 Thread Dmitry Romanov
On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > 1) Sometimes process accounting does not work at all. > > The acct() system call (to activate process accounting) return value 0, > which means that process accounting is activated successfully. > However, no process

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-02-10 Thread Dmitry Romanov
On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > 1) Sometimes process accounting does not work at all. > > The acct() system call (to activate process accounting) return value 0, > which means that process accounting is activated successfully. > However, no process

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-02-06 Thread Tejun Heo
Hello, On Mon, Feb 06, 2017 at 11:39:04AM +0100, Martin Steigerwald wrote: > > Ben Hutchings reports: > > > > "It looks like the taskstats bug was introduced by 513e3d2d11c9 as that > > means cpumask_parse() may not initialise as many bits as > > cpumask_subset() compares" I see, so that patch

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-02-06 Thread Tejun Heo
Hello, On Mon, Feb 06, 2017 at 11:39:04AM +0100, Martin Steigerwald wrote: > > Ben Hutchings reports: > > > > "It looks like the taskstats bug was introduced by 513e3d2d11c9 as that > > means cpumask_parse() may not initialise as many bits as > > cpumask_subset() compares" I see, so that patch

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-02-06 Thread Martin Steigerwald
Am Montag, 19. Dezember 2016, 18:25:49 CET schrieb Peter Zijlstra: > On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > 2) When using the NETLINK inface, the command TASKSTATS_CMD_GET > > consequently returns -EINVAL. > > > > The code that is used by the atopacctd daemon is

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-02-06 Thread Martin Steigerwald
Am Montag, 19. Dezember 2016, 18:25:49 CET schrieb Peter Zijlstra: > On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > 2) When using the NETLINK inface, the command TASKSTATS_CMD_GET > > consequently returns -EINVAL. > > > > The code that is used by the atopacctd daemon is

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Peter Zijlstra
On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > 2) When using the NETLINK inface, the command TASKSTATS_CMD_GET > consequently returns -EINVAL. > > The code that is used by the atopacctd daemon is based on the demo code > 'getdelays.c' that can be found in the kernel

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Peter Zijlstra
On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > 2) When using the NETLINK inface, the command TASKSTATS_CMD_GET > consequently returns -EINVAL. > > The code that is used by the atopacctd daemon is based on the demo code > 'getdelays.c' that can be found in the kernel

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Peter Zijlstra
On Mon, Dec 19, 2016 at 02:50:25PM +0100, Martin Steigerwald wrote: > Am Montag, 19. Dezember 2016, 14:19:11 CET schrieb Peter Zijlstra: > > On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > > Hello Ingo, Peter, Nicolas, Andrew, Balbir, Shailabh, Jay, Gerlof and > > > Marc,

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Peter Zijlstra
On Mon, Dec 19, 2016 at 02:50:25PM +0100, Martin Steigerwald wrote: > Am Montag, 19. Dezember 2016, 14:19:11 CET schrieb Peter Zijlstra: > > On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > > Hello Ingo, Peter, Nicolas, Andrew, Balbir, Shailabh, Jay, Gerlof and > > > Marc,

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Martin Steigerwald
Am Montag, 19. Dezember 2016, 14:19:11 CET schrieb Peter Zijlstra: > On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > Hello Ingo, Peter, Nicolas, Andrew, Balbir, Shailabh, Jay, Gerlof and > > Marc, > > > > starting from a Debian bug report of mine, Gerlof Langeveld,

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Martin Steigerwald
Am Montag, 19. Dezember 2016, 14:19:11 CET schrieb Peter Zijlstra: > On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > > Hello Ingo, Peter, Nicolas, Andrew, Balbir, Shailabh, Jay, Gerlof and > > Marc, > > > > starting from a Debian bug report of mine, Gerlof Langeveld,

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Peter Zijlstra
On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > Hello Ingo, Peter, Nicolas, Andrew, Balbir, Shailabh, Jay, Gerlof and Marc, > > starting from a Debian bug report of mine, Gerlof Langeveld, developer of > system and process monitor atop¹, found two issues with process

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Peter Zijlstra
On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: > Hello Ingo, Peter, Nicolas, Andrew, Balbir, Shailabh, Jay, Gerlof and Marc, > > starting from a Debian bug report of mine, Gerlof Langeveld, developer of > system and process monitor atop¹, found two issues with process

[REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Martin Steigerwald
Hello Ingo, Peter, Nicolas, Andrew, Balbir, Shailabh, Jay, Gerlof and Marc, starting from a Debian bug report of mine, Gerlof Langeveld, developer of system and process monitor atop¹, found two issues with process accounting. [1] http://atoptool.nl/ I did some guess work on who might be the

[REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2016-12-19 Thread Martin Steigerwald
Hello Ingo, Peter, Nicolas, Andrew, Balbir, Shailabh, Jay, Gerlof and Marc, starting from a Debian bug report of mine, Gerlof Langeveld, developer of system and process monitor atop¹, found two issues with process accounting. [1] http://atoptool.nl/ I did some guess work on who might be the