Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Oleksandr Natalenko
Sure, but after catching the stacktrace. On середа, 6 січня 2016 р. 10:43:45 EET Yuchung Cheng wrote: > Could you turn off ecn (sysctl net.ipv4.tcp_ecn=0) to see if this still > happen? > >> On December 22, 2015 4:10:32 AM EET, Yuchung Cheng wrote: > >> >On Mon, Dec 21, 2015 at 12:25 PM,

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Yuchung Cheng
On Wed, Jan 6, 2016 at 10:19 AM, Yuchung Cheng wrote: > On Wed, Jan 6, 2016 at 8:50 AM, Oleksandr Natalenko > wrote: >> >> Unfortunately, the patch didn't help -- I've got the same stacktrace with >> slightly different offset (+3) within the function. >> >> Now trying to get full stacktrace via

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Yuchung Cheng
On Wed, Jan 6, 2016 at 8:50 AM, Oleksandr Natalenko wrote: > > Unfortunately, the patch didn't help -- I've got the same stacktrace with > slightly different offset (+3) within the function. > > Now trying to get full stacktrace via netconsole. Need more time. > > Meanwhile, any other ideas on

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Oleksandr Natalenko
Unfortunately, the patch didn't help -- I've got the same stacktrace with slightly different offset (+3) within the function. Now trying to get full stacktrace via netconsole. Need more time. Meanwhile, any other ideas on what went wrong? On December 22, 2015 4:10:32 AM EET, Yuchung Cheng

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Yuchung Cheng
On Wed, Jan 6, 2016 at 8:50 AM, Oleksandr Natalenko wrote: > > Unfortunately, the patch didn't help -- I've got the same stacktrace with > slightly different offset (+3) within the function. > > Now trying to get full stacktrace via netconsole. Need more time. > >

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Yuchung Cheng
On Wed, Jan 6, 2016 at 10:19 AM, Yuchung Cheng wrote: > On Wed, Jan 6, 2016 at 8:50 AM, Oleksandr Natalenko > wrote: >> >> Unfortunately, the patch didn't help -- I've got the same stacktrace with >> slightly different offset (+3) within the

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Oleksandr Natalenko
Sure, but after catching the stacktrace. On середа, 6 січня 2016 р. 10:43:45 EET Yuchung Cheng wrote: > Could you turn off ecn (sysctl net.ipv4.tcp_ecn=0) to see if this still > happen? > >> On December 22, 2015 4:10:32 AM EET, Yuchung Cheng wrote: > >> >On Mon, Dec 21,

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Oleksandr Natalenko
Unfortunately, the patch didn't help -- I've got the same stacktrace with slightly different offset (+3) within the function. Now trying to get full stacktrace via netconsole. Need more time. Meanwhile, any other ideas on what went wrong? On December 22, 2015 4:10:32 AM EET, Yuchung Cheng

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-22 Thread Oleksandr Natalenko
That is correct, I have net.ipv4.tcp_ecn set to 1. I've recompiled the kernel with proposed patch, now still waiting for issue to be triggered. Could I manually simulate the erroneous TCP ECN behavior to speed up the debugging? On понеділок, 21 грудня 2015 р. 18:10:32 EET Yuchung Cheng wrote:

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-22 Thread Oleksandr Natalenko
That is correct, I have net.ipv4.tcp_ecn set to 1. I've recompiled the kernel with proposed patch, now still waiting for issue to be triggered. Could I manually simulate the erroneous TCP ECN behavior to speed up the debugging? On понеділок, 21 грудня 2015 р. 18:10:32 EET Yuchung Cheng wrote:

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-21 Thread Yuchung Cheng
On Mon, Dec 21, 2015 at 12:25 PM, Oleksandr Natalenko wrote: > Commit 3759824da87b30ce7a35b4873b62b0ba38905ef5 (tcp: PRR uses CRB mode by > default and SS mode conditionally) introduced changes to net/ipv4/tcp_input.c > tcp_cwnd_reduction() that, possibly, cause division by zero, and therefore, >

[REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-21 Thread Oleksandr Natalenko
Commit 3759824da87b30ce7a35b4873b62b0ba38905ef5 (tcp: PRR uses CRB mode by default and SS mode conditionally) introduced changes to net/ipv4/tcp_input.c tcp_cwnd_reduction() that, possibly, cause division by zero, and therefore, kernel panic in interrupt handler [1]. Reverting

[REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-21 Thread Oleksandr Natalenko
Commit 3759824da87b30ce7a35b4873b62b0ba38905ef5 (tcp: PRR uses CRB mode by default and SS mode conditionally) introduced changes to net/ipv4/tcp_input.c tcp_cwnd_reduction() that, possibly, cause division by zero, and therefore, kernel panic in interrupt handler [1]. Reverting

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-21 Thread Yuchung Cheng
On Mon, Dec 21, 2015 at 12:25 PM, Oleksandr Natalenko wrote: > Commit 3759824da87b30ce7a35b4873b62b0ba38905ef5 (tcp: PRR uses CRB mode by > default and SS mode conditionally) introduced changes to net/ipv4/tcp_input.c > tcp_cwnd_reduction() that, possibly, cause division